Moved custom Institutional configs to nf-core configs on github #212
Conversation
| @@ -1,5 +1,13 @@ | |||
| # nf-core/tools: Changelog | |||
|
|
|||
| ## v1.3dev | |||
There was a problem hiding this comment.
| ## v1.3dev | |
| ## v1.4dev |
There was a problem hiding this comment.
Sorry. Thats exactly what I meant!
There was a problem hiding this comment.
How do you make these changes after merging @apeltzer? My naive brain is trying to work it out!
There was a problem hiding this comment.
My bad - I've merged before really thinking as I thought the commit was fine and good (expect for these smallish typos). I guess just make a new PR with just these two then and I'll merge it in... sorry about that.
Normally you can simply click "accept" and thats it... :-)
There was a problem hiding this comment.
No worries. I have fixed this in #214 whilst I was dealing with another issue.
| * These will now be maintained centrally as opposed to being shipped with the pipelines in `conf/` | ||
| * Load `base.config` by default for all profiles | ||
| * Removed profiles named `standard` and `none` | ||
| * Added parameter `--igenomesIgnore` so `igenomes.config` isnt loaded if parameter clashes are observed |
There was a problem hiding this comment.
| * Added parameter `--igenomesIgnore` so `igenomes.config` isnt loaded if parameter clashes are observed | |
| * Added parameter `--igenomesIgnore` so `igenomes.config` isn't loaded if parameter clashes are observed |
|
Super nice work @drpatelh! Please can you describe this change in |
|
Sorry got started with some of this and had to prep for presenting the pipeline to our User Committee. Back to reality! I did put some description in the CHANGELOG.md. Did I miss something? Assuming you mean adding the parameters in here: And a description here: |
|
Added some description as requested and a bunch of other stuff I had noticed whilst writing |
|
You did indeed add something to the changelog, correct. Not sure how I missed that, sorry! For the docs I more meant something specifically describing that the configs are fetched from a separate repository and people can add their clusters their so that they're available for all pipelines. |
|
Note to self: refresh half-written replies on GitHub before posting. This is great! I will stop talking now. |
Many thanks to contributing to nf-core/tools!
Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).
PR checklist
docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: https://github.com/nf-core/tools/tree/master/.github/CONTRIBUTING.md
We can now centrally store and maintain custom configs that are specific to individual Institutions. Config files have been moved to
nf-core/configsand will be pulled by nextflow before pipeline execution.