Add singularity.registry = 'quay.io' to pipeline template #2305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #2305 +/- ##
==========================================
+ Coverage 72.84% 72.90% +0.05%
==========================================
Files 78 78
Lines 8750 8761 +11
==========================================
+ Hits 6374 6387 +13
+ Misses 2376 2374 -2
|
adamrtalbot
reviewed
Jun 8, 2023
Contributor
adamrtalbot
left a comment
There was a problem hiding this comment.
I'm happy with the code but what is the consensus on the Nextflow version? It seems very recent to me.
ewels
reviewed
Jun 12, 2023
| description = """{{ description }}""" | ||
| mainScript = 'main.nf' | ||
| nextflowVersion = '!>=22.10.1' | ||
| nextflowVersion = '!>=23.04.0' |
Member
There was a problem hiding this comment.
How about a compromise of not making it a !>= but instead just a >=?
Member
Author
There was a problem hiding this comment.
This might break if an older version of NF is used in a pipeline that actually requires singularity.registry?
sateeshperi
approved these changes
Jun 13, 2023
mirpedrol
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2303
See nf-core/modules#3499