fix: Respect label order in precomputed derivatives #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #478 +/- ##
===========================================
+ Coverage 63.21% 74.37% +11.15%
===========================================
Files 25 25
Lines 1952 1955 +3
Branches 244 247 +3
===========================================
+ Hits 1234 1454 +220
+ Misses 679 435 -244
- Partials 39 66 +27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I've confirmed that the issue is resolved in a local test. |
mgxd
approved these changes
May 6, 2025
|
I don't think pybids should make any particular commitment to an ordering. I'm okay removing the natural sort, or allowing for a sorting parameter, but I think it's best to code defensively on this end, regardless. |
effigies
added a commit
that referenced
this pull request
May 13, 2025
0.18.0 (May 08, 2025) New feature release in the 0.18.x series. This release patches the FSL FAST interface to disable bias field correction, which is redundant with N4 and can cause problems in some populations. * FIX: Respect label order in precomputed derivatives (#478) * FIX: Set FAST bias_iters parameter to 0 (#472) * ENH: Tag structural workflows (#476) * MNT: Update pinned environment, use conda-forge connectome-workbench (#468)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BIDSLayoutdoes anatural_sorton allget()query results, which breaks ordering encoded in the query itself. This PR looks for the label entity in the query and re-sorts by the label list to ensure that values are returned as expected.A more robust refactor might either carry around a list of tissue labels or re-order probsegs, but doing that right would be a nontrivial effort, and introduce opportunities for new bugs. This narrowly targets a known bug.
This is a bug-fix candidate PR.
Fixes #474.