Codestin Search App

Rezney · 2019-11-12T11:29:14Z

At the end of "leapp upgrade" run we do not print message
about generated reports, in contrast to "leapp preupgrade"
where we do.

Rezney · 2019-11-12T11:29:29Z

@drehak @bocekm please take a look...

centos-ci · 2019-11-12T11:30:09Z

Can one of the admins verify this patch?

drehak · 2019-11-12T16:38:41Z

Tested, LGMT.

drehak · 2019-11-12T16:40:51Z

@examon @vojtechsokol Are these linter issues false positives or not?

bocekm

When running leapp upgrade --debug, I now get:

============================================================
                           REPORT                           
============================================================

A report has been generated at /var/log/leapp/leapp-report.json
A report has been generated at /var/log/leapp/leapp-report.txt
A report has been generated at /var/log/leapp/leapp-upgrade.log

============================================================
                       END OF REPORT                        
============================================================

The /var/log/leapp/leapp-upgrade.log shouldn't be there. That's not a report. The debug log should not be of any interest to users by default.
@Rezney would like to have a bigger quorum, so @shaded-enmity, @pirat89, do you agree with removing it?

Rezney · 2019-11-13T11:19:52Z

When running leapp upgrade --debug, I now get:

============================================================
                           REPORT                           
============================================================

A report has been generated at /var/log/leapp/leapp-report.json
A report has been generated at /var/log/leapp/leapp-report.txt
A report has been generated at /var/log/leapp/leapp-upgrade.log

============================================================
                       END OF REPORT                        
============================================================

The /var/log/leapp/leapp-upgrade.log shouldn't be there. That's not a report.

If you run "leapp preupgrade --debug", what do you see?

Rezney · 2020-01-08T12:11:02Z

@bocekm how do we move forward with this PR?

pirat89 · 2020-01-08T15:31:53Z

The /var/log/leapp/leapp-upgrade.log shouldn't be there. That's not a report. The debug log should not be of any interest to users by default.
@Rezney would like to have a bigger quorum, so @shaded-enmity, @pirat89, do you agree with removing it?

Agree with Michal. log file should not be there.

shaded-enmity · 2020-01-08T17:12:10Z

I don't mind the log file if we show it differently:

============================================================
                           REPORT                           
============================================================

A report has been generated at /var/log/leapp/leapp-report.json
A report has been generated at /var/log/leapp/leapp-report.txt

============================================================
                       END OF REPORT                        
============================================================

Debug output written to /var/log/leapp/leapp-upgrade.log

Changes requested have been applied

fernflower

lgtm, one nit inline but up to you.
Will do a fullstack run before approval

fernflower · 2020-01-27T09:05:15Z

leapp/cli/upgrade/__init__.py

+    files = []
+    for file_ in cfg.get(section, 'files').split(','):
+        file_path = os.path.join(cfg.get(section, 'dir'), file_)
+        if not must_exist:


Nit: I'd put it as one condition

if not must_exist or must_exist and os.path.isfile(file_path): files.append(file_path)

makes sense, will apply...

Rezney · 2020-01-27T12:41:50Z

leapp-ci build

Rezney · 2020-01-27T15:05:56Z

rebased...

drehak · 2020-01-28T14:17:11Z

leapp/config.py

+# debug logs that will get reported at the end of a preupgrade/upgrade run if they were created/modified during it
+_LOGS = [
+    'leapp-upgrade.log',
+    'leapp-preupgrade.log'


These two files could be sorted, although that's just a tiny nitpick.

drehak · 2020-01-28T14:38:56Z

leapp/utils/output.py

+    if log_paths:
+        for log_path in log_paths:
+            sys.stdout.write("Debug output written to {path}\n".format(path=log_path))
+        sys.stdout.write("\n")


I'd move this newline above if log_paths:. Currently there's 0 newlines above Debug output... and 2 newlines below:

[...] Transaction Summary ================================================================================ Install 325 Packages Upgrade 441 Packages Remove 89 Packages Downgrade 5 Packages Total size: 631 M Total download size: 524 M Downloading Packages: Check completed. Debug output written to /var/log/leapp/leapp-preupgrade.log ============================================================ REPORT ============================================================ [...]

At the end of "leapp upgrade" run we do not print message about generated reports, in contrast to "leapp preupgrade" where we do.

Rezney · 2020-01-28T15:28:42Z

@drehak newline done

## Packaging - Add BuildRequires on python2-setuptools - Add new dependency on python?-requests - Add unversioned dependency on leapp-repository and provide the leapp-framework capability in python2-leapp (see docs about "new dependency mechanism") (oamg#591) - Move all leapp and snactor files into related rpms istead of python?-leapp (oamg#591) - Remove dependency on Jinja2 ## Framework ### Fixes - Fix json export capabilities using serialization (oamg#598) ### Enhancements - Add the DESKTOP tag for the leapp report (oamg#612) - Dialogs are non-interactive and redesigned significantly; but in beta support (see the known issue) - Introduce DialogModel that could be processed by actors to add related information into the report (oamg#589) - Introduce Workflow API (see the tutorial) (oamg#618) - Report inhibitors seprately from errors on stdout (oamg#620) - Show progress in non verbose executions (oamg#621) ### Known issue - The answerfile is not generated on some machines after the run of leapp. Currently it's under investigation and it will be fixed definitely in the next release. ## Leapp ### Fixes - Print message about generated report when `leapp upgrade` ends, as we do for `leapp preupgrade` (oamg#573) ### Enhancements - Add `leapp answer` to answer Dialog questions on CLI (oamg#592) - Add the --no-rhsm option for (pre)upgrade commands (oamg#622) - Display warning when leapp is used in unsupported (devel/testing) mode (oamg#577) - Print errors on stdout in pretty format (oamg#593) - The error messages are part of the preupgrade report - The verbosity options (--verbose | --debug) are available for leapp commands as well ## Snactor ### Fixes ### Enhancements ## stdlib ### Fixes ### Enhancements - Add `stdin` and `encoding` parameters in the run function (oamg#583, oamg#595) ## Modifications - Code is compatible with Python3 pylint

## Packaging - Add BuildRequires on python2-setuptools - Add new dependency on python2-requests - Add unversioned dependency on leapp-repository and provide the leapp-framework capability in python2-leapp (see docs about "new dependency mechanism") (oamg#591) - Move all leapp and snactor files into related rpms instead of python?-leapp (oamg#591) - Remove dependency on Jinja2 ## Framework ### Fixes - Fix json export capabilities using serialization (oamg#598) ### Enhancements - Add the DESKTOP tag for the leapp report (oamg#612) - Dialogs are non-interactive and redesigned significantly; but in beta support (see the known issue) - Introduce DialogModel that could be processed by actors to add related information into the report (oamg#589) - Introduce Workflow API (see the Workflow APIs tutorial) (oamg#618) - Report inhibitors separately from errors on stdout (oamg#620) - Show progress in non-verbose executions (oamg#621) ### Known issue - The answerfile is not generated on some machines after the run of leapp. Currently it's under investigation. ## Leapp ### Fixes - Print message about generated report when `leapp upgrade` ends, as we do for `leapp preupgrade` (oamg#573) ### Enhancements - Add `leapp answer` to answer Dialog questions in CLI (oamg#592) - Add the --no-rhsm option for (pre)upgrade commands (oamg#622) - Add the --enablerepo option for Leapp to use an existing custom yum/dnf repository during the upgrade - Display a warning when leapp is used in an unsupported (devel/testing) mode (oamg#577) - Print errors on stdout in pretty format (oamg#593) - Error messages are now part of the preupgrade report - The verbosity options (--verbose | --debug) are available for leapp commands as well ## stdlib ### Enhancements - Add `stdin` and `encoding` parameters in the run function (oamg#583, oamg#595) ## Modifications - Code is compatible with Python3 pylint

## Packaging - Add BuildRequires on python2-setuptools - Add new dependency on python2-requests - Add unversioned dependency on leapp-repository and provide the leapp-framework capability in python2-leapp (see docs about "new dependency mechanism") (#591) - Move all leapp and snactor files into related rpms instead of python?-leapp (#591) - Remove dependency on Jinja2 ## Framework ### Fixes - Fix json export capabilities using serialization (#598) ### Enhancements - Add the DESKTOP tag for the leapp report (#612) - Dialogs are non-interactive and redesigned significantly; but in beta support (see the known issue) - Introduce DialogModel that could be processed by actors to add related information into the report (#589) - Introduce Workflow API (see the Workflow APIs tutorial) (#618) - Report inhibitors separately from errors on stdout (#620) - Show progress in non-verbose executions (#621) ### Known issue - The answerfile is not generated on some machines after the run of leapp. Currently it's under investigation. ## Leapp ### Fixes - Print message about generated report when `leapp upgrade` ends, as we do for `leapp preupgrade` (#573) ### Enhancements - Add `leapp answer` to answer Dialog questions in CLI (#592) - Add the --no-rhsm option for (pre)upgrade commands (#622) - Add the --enablerepo option for Leapp to use an existing custom yum/dnf repository during the upgrade - Display a warning when leapp is used in an unsupported (devel/testing) mode (#577) - Print errors on stdout in pretty format (#593) - Error messages are now part of the preupgrade report - The verbosity options (--verbose | --debug) are available for leapp commands as well ## stdlib ### Enhancements - Add `stdin` and `encoding` parameters in the run function (#583, #595) ## Modifications - Code is compatible with Python3 pylint

drehak previously approved these changes Nov 12, 2019

View reviewed changes

bocekm previously requested changes Nov 12, 2019

View reviewed changes

Rezney dismissed drehak’s stale review via 563b20c January 23, 2020 13:26

Rezney force-pushed the show_reports_fix branch from df0e349 to 563b20c Compare January 23, 2020 13:26

Rezney changed the title ~~Fix: report msg not generated at the end of run~~ WIP: Fix: report msg not generated at the end of run Jan 23, 2020

Rezney force-pushed the show_reports_fix branch 4 times, most recently from 5329f5b to 5e3b066 Compare January 23, 2020 20:39

Rezney force-pushed the show_reports_fix branch 4 times, most recently from b28c95d to cbfc2c1 Compare January 27, 2020 11:38

fernflower reviewed Jan 27, 2020

View reviewed changes

fernflower previously approved these changes Jan 27, 2020

View reviewed changes

Rezney changed the title ~~WIP: Fix: report msg not generated at the end of run~~ Fix: report msg not generated at the end of run Jan 27, 2020

Rezney dismissed fernflower’s stale review via 9309e0a January 27, 2020 12:49

Rezney force-pushed the show_reports_fix branch 2 times, most recently from 9309e0a to fd7bf98 Compare January 27, 2020 15:04

drehak requested changes Jan 28, 2020

View reviewed changes

Fix: report msg not generated at the end of run

f778db7

At the end of "leapp upgrade" run we do not print message about generated reports, in contrast to "leapp preupgrade" where we do.

Rezney force-pushed the show_reports_fix branch from fd7bf98 to f778db7 Compare January 28, 2020 15:23

fernflower approved these changes Jan 28, 2020

View reviewed changes

drehak approved these changes Jan 28, 2020

View reviewed changes

drehak merged commit 27dca40 into oamg:master Jan 28, 2020

pirat89 mentioned this pull request Apr 16, 2020

Release 0.10.0 #624

Merged

Comments

Conversation

Rezney commented Nov 12, 2019

Uh oh!

Rezney commented Nov 12, 2019

Uh oh!

centos-ci commented Nov 12, 2019

Uh oh!

drehak commented Nov 12, 2019

Uh oh!

drehak commented Nov 12, 2019

Uh oh!

bocekm left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rezney commented Nov 13, 2019

Uh oh!

Rezney commented Jan 8, 2020

Uh oh!

pirat89 commented Jan 8, 2020

Uh oh!

shaded-enmity commented Jan 8, 2020

Uh oh!

fernflower left a comment

Choose a reason for hiding this comment

Uh oh!

fernflower Jan 27, 2020

Choose a reason for hiding this comment

Uh oh!

Rezney Jan 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rezney commented Jan 27, 2020

Uh oh!

Rezney commented Jan 27, 2020

Uh oh!

drehak Jan 28, 2020

Choose a reason for hiding this comment

Uh oh!

drehak Jan 28, 2020

Choose a reason for hiding this comment

Uh oh!

Rezney commented Jan 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

bocekm left a comment •

edited

Loading

Rezney Jan 27, 2020 •

edited

Loading