Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Python get_stats returns float or int instead of single element numpy array and fix cython for custom path #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 29, 2023
Merged

Python get_stats returns float or int instead of single element numpy array and fix cython for custom path #961

merged 7 commits into from
Aug 29, 2023

Conversation

@aghezz1
Copy link
Contributor

@aghezz1 aghezz1 commented Aug 24, 2023 •
edited by FreyJo
Loading

  • Get statistics with their correct types in both python and cython interface - avoid creation of 1-dim numpy array
  • Make cython interface working with custom path of the code_export_directory

For Release notes:

  • BREAKING: change return types of get_stats in Python

@aghezz1 aghezz1 requested a review from sandmaennchen August 24, 2023 14:06
sandmaennchen
sandmaennchen approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@sandmaennchen sandmaennchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@FreyJo FreyJo changed the title Correct get_stats and fix cython for custom path Python get_stats returns double or int instead of single element numpy array and fix cython for custom path Aug 29, 2023
@FreyJo FreyJo changed the title Python get_stats returns double or int instead of single element numpy array and fix cython for custom path Python get_stats returns float or int instead of single element numpy array and fix cython for custom path Aug 29, 2023
@FreyJo FreyJo merged commit cd4ed15 into acados:master Aug 29, 2023
@aghezz1 aghezz1 deleted the andrea-pr branch November 19, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sandmaennchen sandmaennchen sandmaennchen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aghezz1 @sandmaennchen @FreyJo