update goreleaser with windows checksums #740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Phillips <[email protected]>
Signed-off-by: Christopher Phillips <[email protected]>
Signed-off-by: Christopher Phillips <[email protected]>
Signed-off-by: Christopher Phillips <[email protected]>
Benchmark Test ResultsBenchmark results from the latest changes vs base branch |
kzantow
approved these changes
Jan 10, 2022
| goarch: | ||
| - amd64 | ||
| - arm64 | ||
| # Set the modified timestamp on the output binary to the git timestamp (to ensure a reproducible build) |
There was a problem hiding this comment.
does this somehow lose the reproducible build now? does it matter?
There was a problem hiding this comment.
I don't think anything was deleted here. We had two blocks that were doing the builds for windows/linux and I just zipped them into one. mod_timestamp is still in the file. id: syft-win was removed and everything was consolodated under id: syft
spiffcs
commented
Jan 10, 2022
| - amd64 | ||
| - arm64 | ||
| # Set the modified timestamp on the output binary to the git timestamp (to ensure a reproducible build) | ||
| mod_timestamp: '{{ .CommitTimestamp }}' |
There was a problem hiding this comment.
@kzantow mod_timestamp should still exist here on this line - This PR took the two builds sections and consolidated them into a single one
|
This works all the way through generating a snapshot, but before I merge @wagoodman if there is anything else you'd like to see tested since it affects our release process? |
spiffcs
added a commit
that referenced
this pull request
Jan 19, 2022
…hub.com/hectorj2f/syft into hectorj2f/add_dependencies_to_cyclonedx * 'hectorj2f/add_dependencies_to_cyclonedx' of https://github.com/hectorj2f/syft: (29 commits) Improve CycloneDX format output (#710) Add additional PHP metadata (#753) Update Syft formats for SyftJson (#752) Add support for "file" source type in syftjson unmarshaling (#750) remove contains file from spdx dependency generation support .sar for java ecosystem (#748) Start developer documentation (#746) Align SPDX export more with SPDX 2.2 specification (#743) Replace distro type (#742) update goreleaser with windows checksums (#740) bump stereoscope version to remove old containerd (#741) Add support for multiple output files in different formats (#732) Add support for searching for jars within archives (#734) 683 windows filepath (#735) Fix CPE encode/decode when it contains special chars (#714) support .par for java ecosystems (#727) Add arm64 support to install script (#729) Revert "bump goreleaser to v1.2 (#720)" (#731) Add a version flag (#722) Add lpkg as java package format (#694) ...
| id: syft | ||
| replacements: | ||
| windows: Windows | ||
| amd64: x86_64 |
There was a problem hiding this comment.
fengshunli
pushed a commit
to fengshunli/syft
that referenced
this pull request
Jan 24, 2022
* update goreleaser with windows checksums Signed-off-by: Christopher Phillips <[email protected]> * update format to be closer to our previous implementation Signed-off-by: Christopher Phillips <[email protected]> * remove linux replacement Signed-off-by: Christopher Phillips <[email protected]> * typo Signed-off-by: Christopher Phillips <[email protected]> Signed-off-by: fsl <[email protected]>
spiffcs
added a commit
that referenced
this pull request
Jan 24, 2022
* update goreleaser with windows checksums Signed-off-by: Christopher Phillips <[email protected]> * update format to be closer to our previous implementation Signed-off-by: Christopher Phillips <[email protected]> * remove linux replacement Signed-off-by: Christopher Phillips <[email protected]> * typo Signed-off-by: Christopher Phillips <[email protected]>
spiffcs
added a commit
that referenced
this pull request
Jan 25, 2022
* update goreleaser with windows checksums Signed-off-by: Christopher Phillips <[email protected]> * update format to be closer to our previous implementation Signed-off-by: Christopher Phillips <[email protected]> * remove linux replacement Signed-off-by: Christopher Phillips <[email protected]> * typo Signed-off-by: Christopher Phillips <[email protected]>
jonasagx
pushed a commit
to jonasagx/syft
that referenced
this pull request
Jan 28, 2022
* update goreleaser with windows checksums Signed-off-by: Christopher Phillips <[email protected]> * update format to be closer to our previous implementation Signed-off-by: Christopher Phillips <[email protected]> * remove linux replacement Signed-off-by: Christopher Phillips <[email protected]> * typo Signed-off-by: Christopher Phillips <[email protected]>
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
* update goreleaser with windows checksums Signed-off-by: Christopher Phillips <[email protected]> * update format to be closer to our previous implementation Signed-off-by: Christopher Phillips <[email protected]> * remove linux replacement Signed-off-by: Christopher Phillips <[email protected]> * typo Signed-off-by: Christopher Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor goreleaser syntax for checksums
How to test
Run
make snapeshoton this branch. Undersnapshotthere should be a file calledsyft_0.35.0-SNAPSHOT-5e5312c_checksums.txtBelow is the output for that file.
Previously you would only see:
Signed-off-by: Christopher Phillips [email protected]