Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@wagoodman
Copy link
Contributor

The latest release did not properly update the checksums for all of the darwin-related assets. This appears to be due to the specific goreleaser configuration we have, however, testing changes to this is non-obvious since it overlaps with behavior in the signing section (which is notoriously hard to test).

We need to get the mac signing process into a state where we can confidently test process changes without needing production secrets or testing on a real release. I can follow up with details in a future PR, however, for the meantime we should fallback to the old release of goreleaser until we have made the proper configuration updates.

This reverts commit 8535ee5.

Signed-off-by: Alex Goodman <[email protected]>
@wagoodman wagoodman force-pushed the revert-720-bump-goreleaser-1.2 branch from 8bf8260 to 70ac0a2 Compare January 3, 2022 15:11
@wagoodman wagoodman enabled auto-merge (squash) January 3, 2022 15:14
@github-actions
Copy link

github-actions bot commented Jan 3, 2022

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name                                                       time/op
ImagePackageCatalogers/ruby-gemspec-cataloger-2            1.29ms ± 1%
ImagePackageCatalogers/python-package-cataloger-2          2.71ms ± 0%
ImagePackageCatalogers/php-composer-installed-cataloger-2   866µs ± 0%
ImagePackageCatalogers/javascript-package-cataloger-2       809µs ± 0%
ImagePackageCatalogers/dpkgdb-cataloger-2                   928µs ± 0%
ImagePackageCatalogers/rpmdb-cataloger-2                    839µs ± 0%
ImagePackageCatalogers/java-cataloger-2                    11.4ms ± 1%
ImagePackageCatalogers/apkdb-cataloger-2                   1.22ms ± 1%
ImagePackageCatalogers/go-module-binary-cataloger-2        1.93µs ± 1%

name                                                       alloc/op
ImagePackageCatalogers/ruby-gemspec-cataloger-2             252kB ± 0%
ImagePackageCatalogers/python-package-cataloger-2          1.05MB ± 0%
ImagePackageCatalogers/php-composer-installed-cataloger-2   227kB ± 0%
ImagePackageCatalogers/javascript-package-cataloger-2       207kB ± 0%
ImagePackageCatalogers/dpkgdb-cataloger-2                   252kB ± 0%
ImagePackageCatalogers/rpmdb-cataloger-2                    233kB ± 0%
ImagePackageCatalogers/java-cataloger-2                    3.34MB ± 0%
ImagePackageCatalogers/apkdb-cataloger-2                   1.30MB ± 0%
ImagePackageCatalogers/go-module-binary-cataloger-2          560B ± 0%

name                                                       allocs/op
ImagePackageCatalogers/ruby-gemspec-cataloger-2             6.28k ± 0%
ImagePackageCatalogers/python-package-cataloger-2           21.0k ± 0%
ImagePackageCatalogers/php-composer-installed-cataloger-2   5.98k ± 0%
ImagePackageCatalogers/javascript-package-cataloger-2       5.32k ± 0%
ImagePackageCatalogers/dpkgdb-cataloger-2                   7.04k ± 0%
ImagePackageCatalogers/rpmdb-cataloger-2                    6.78k ± 0%
ImagePackageCatalogers/java-cataloger-2                     59.9k ± 0%
ImagePackageCatalogers/apkdb-cataloger-2                    7.28k ± 0%
ImagePackageCatalogers/go-module-binary-cataloger-2          13.0 ± 0%

@wagoodman wagoodman merged commit a18fbac into main Jan 3, 2022
@wagoodman wagoodman deleted the revert-720-bump-goreleaser-1.2 branch January 3, 2022 15:19
spiffcs pushed a commit that referenced this pull request Jan 4, 2022
This reverts commit 8535ee5.

Signed-off-by: Alex Goodman <[email protected]>
spiffcs pushed a commit that referenced this pull request Jan 4, 2022
This reverts commit 8535ee5.

Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Christopher Angelo Phillips <[email protected]>
spiffcs pushed a commit that referenced this pull request Jan 4, 2022
This reverts commit 8535ee5.

Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Christopher Angelo Phillips <[email protected]>
spiffcs added a commit that referenced this pull request Jan 19, 2022
…hub.com/hectorj2f/syft into hectorj2f/add_dependencies_to_cyclonedx

* 'hectorj2f/add_dependencies_to_cyclonedx' of https://github.com/hectorj2f/syft: (29 commits)
  Improve CycloneDX format output (#710)
  Add additional PHP metadata (#753)
  Update Syft formats for SyftJson (#752)
  Add support for "file" source type in syftjson unmarshaling (#750)
  remove contains file from spdx dependency generation
  support .sar for java ecosystem (#748)
  Start developer documentation (#746)
  Align SPDX export more with SPDX 2.2 specification (#743)
  Replace distro type (#742)
  update goreleaser with windows checksums (#740)
  bump stereoscope version to remove old containerd (#741)
  Add support for multiple output files in different formats (#732)
  Add support for searching for jars within archives (#734)
  683 windows filepath (#735)
  Fix CPE encode/decode when it contains special chars (#714)
  support .par for java ecosystems (#727)
  Add arm64 support to install script (#729)
  Revert "bump goreleaser to v1.2 (#720)" (#731)
  Add a version flag (#722)
  Add lpkg as java package format (#694)
  ...
fengshunli pushed a commit to fengshunli/syft that referenced this pull request Jan 24, 2022
This reverts commit 8535ee5.

Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: fsl <[email protected]>
spiffcs pushed a commit that referenced this pull request Jan 24, 2022
This reverts commit 8535ee5.

Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Christopher Phillips <[email protected]>
spiffcs pushed a commit that referenced this pull request Jan 25, 2022
This reverts commit 8535ee5.

Signed-off-by: Alex Goodman <[email protected]>
jonasagx pushed a commit to jonasagx/syft that referenced this pull request Jan 28, 2022
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants