Add support for multiple output files in different formats #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
kzantow
commented
Jan 4, 2022
kzantow
commented
Jan 4, 2022
kzantow
commented
Jan 4, 2022
kzantow
commented
Jan 4, 2022
| flags.StringP( | ||
| "file", "", "", | ||
| "file to write the report output to (default is STDOUT)", | ||
| "file to write the default report output to (default is STDOUT)", |
There was a problem hiding this comment.
should this be deprecated? if so, how would that be done? just updates to this and the readme?
There was a problem hiding this comment.
Is -o intended to replace --file?
There was a problem hiding this comment.
I don't really know, but the functionality is redundant. it would seem outputting a table to a file is fairly useless, so generally a user would have to do -o spdx-json --file <output-file>, for example. But this is already covered by the -o spdx-json=<output-file>...
There was a problem hiding this comment.
I see your point on redundancy.
My take: I think it makes sense to leave the --file flag as it's not harming anything by leaving it. We probably don't need to add a deprecation notice if we aren't removing it (we could always decide to remove it in the future).
kzantow
commented
Jan 4, 2022
kzantow
commented
Jan 4, 2022
kzantow
commented
Jan 4, 2022
kzantow
commented
Jan 4, 2022
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
wagoodman
reviewed
Jan 6, 2022
wagoodman
reviewed
Jan 6, 2022
wagoodman
reviewed
Jan 6, 2022
wagoodman
reviewed
Jan 6, 2022
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
wagoodman
reviewed
Jan 6, 2022
wagoodman
approved these changes
Jan 6, 2022
|
Great addition; thanks! 😃 |
spiffcs
added a commit
that referenced
this pull request
Jan 19, 2022
…hub.com/hectorj2f/syft into hectorj2f/add_dependencies_to_cyclonedx * 'hectorj2f/add_dependencies_to_cyclonedx' of https://github.com/hectorj2f/syft: (29 commits) Improve CycloneDX format output (#710) Add additional PHP metadata (#753) Update Syft formats for SyftJson (#752) Add support for "file" source type in syftjson unmarshaling (#750) remove contains file from spdx dependency generation support .sar for java ecosystem (#748) Start developer documentation (#746) Align SPDX export more with SPDX 2.2 specification (#743) Replace distro type (#742) update goreleaser with windows checksums (#740) bump stereoscope version to remove old containerd (#741) Add support for multiple output files in different formats (#732) Add support for searching for jars within archives (#734) 683 windows filepath (#735) Fix CPE encode/decode when it contains special chars (#714) support .par for java ecosystems (#727) Add arm64 support to install script (#729) Revert "bump goreleaser to v1.2 (#720)" (#731) Add a version flag (#722) Add lpkg as java package format (#694) ...
fengshunli
pushed a commit
to fengshunli/syft
that referenced
this pull request
Jan 24, 2022
spiffcs
pushed a commit
that referenced
this pull request
Jan 24, 2022
Signed-off-by: Christopher Phillips <[email protected]>
spiffcs
pushed a commit
that referenced
this pull request
Jan 25, 2022
jonasagx
pushed a commit
to jonasagx/syft
that referenced
this pull request
Jan 28, 2022
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for multiple
-o/--outputoptions (and similarly in yaml). It continues to support the yaml syntax with a single option ofoutput: 'json'. Additionally, each output option can specify a file by appending=<file>. For example, to output a Syft JSON and SPDX JSON, one could use:syft -o json=my.syft.json -o spdx-json=my.spdx.jsonTODO: