Add pURL generation for java packages + fix NPM pURL generation #812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Benchmark Test ResultsBenchmark results from the latest changes vs base branch |
Signed-off-by: Alex Goodman <[email protected]>
kzantow
approved these changes
Feb 10, 2022
| } | ||
|
|
||
| pURL := packageurl.NewPackageURL( | ||
| packageurl.TypeMaven, // TODO: should we filter down by package types here? |
There was a problem hiding this comment.
is this always maven? ... I see the purl spec doesn't seem to have any other java types, which is probably ok
There was a problem hiding this comment.
I'm also mixed on this.
I see the purl spec doesn't seem to have any other java types
That's what made me pause on excluding these. If we don't have a pURL for these packages, then package type extraction will be impossible. So it seems right to at least include a purl that matches the java ecosystem. (I suspect in the future this will change)
spiffcs
added a commit
that referenced
this pull request
Feb 17, 2022
…hore/syft into 510-attach-sbomb-attestation * '510-attach-sbomb-attestation' of https://github.com/anchore/syft: Upgrade install.sh to support installations for previous versions (#830) remove duplicate manifest lines (#828) bump stereoscope to include functional options (#823) update golang crypto library dependency (#815) deduplicate SPDX tag-value package IDs (#813) Add pURL generation for java packages + fix NPM pURL generation (#812)
spiffcs
added a commit
that referenced
this pull request
Feb 17, 2022
* main: Upgrade install.sh to support installations for previous versions (#830) remove duplicate manifest lines (#828) bump stereoscope to include functional options (#823) update golang crypto library dependency (#815) deduplicate SPDX tag-value package IDs (#813) Add pURL generation for java packages + fix NPM pURL generation (#812) Signed-off-by: Christopher Phillips <[email protected]>
spiffcs
pushed a commit
that referenced
this pull request
Feb 18, 2022
* enhance pURL generation for java packages Signed-off-by: Alex Goodman <[email protected]> * optionally split out npm namespaces for pURL generation Signed-off-by: Alex Goodman <[email protected]> * nit updates Signed-off-by: Alex Goodman <[email protected]> Signed-off-by: Christopher Phillips <[email protected]>
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
…ore#812) * enhance pURL generation for java packages Signed-off-by: Alex Goodman <[email protected]> * optionally split out npm namespaces for pURL generation Signed-off-by: Alex Goodman <[email protected]> * nit updates Signed-off-by: Alex Goodman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances pURL generation in the following ways:
pom.propertiesfile. Note: enough parser-specific logic was needed that this is synthesized in the java cataloger package and persisted in the java.Metadata.the 'namespace' is used for the scope of a scoped NPM package. So the package name@angular/animationshould be split such that the pURL namespace is@angularinstead of encoding the full name into the pURL package name.Related to anchore/grype#395