Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@wagoodman
Copy link
Contributor

@wagoodman wagoodman commented Feb 15, 2022

The sbom-action installation failed in the latest release run: https://github.com/anchore/syft/runs/5204811566?check_suite_focus=true

[info] checking github for release tag='v0.33.0' 
[debug] http_download(url=[anchore/syft/releases/v0.33.0)](https://github.com/anchore/syft/releases/v0.33.0)) 
[info] using release tag='v0.33.0' version='0.33.0' os='darwin' arch='amd64' 
[debug] downloading files into /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmp.97tmb50y 
[debug] http_download(url=[v0.33.0 syft_0.33.0_checksums.txt) (download)](https://github.com/anchore/syft/releases/download/v0.33.0/syft_0.33.0_checksums.txt)) 
Error:  could not find release asset for os='darwin' arch='amd64' format='tar.gz'  
Error:  failed to install syft 
Error: ENOENT: no such file or directory, stat '/Users/runner/work/_temp/901a0c5a-dc08-47a2-bc9b-a747910548f2_syft/syft'

This is because install.sh is narrowly focused at being able to install assets for the current release. This update makes it so that install.sh will curl down the specific install.sh script for the release tag that has been resolved and uses that script.

A test for installing against v0.33.0 (which fails with todays install.sh without these additions from this branch) has been added as a regression test.

@wagoodman wagoodman requested a review from a team February 15, 2022 21:26
@wagoodman wagoodman self-assigned this Feb 15, 2022
@github-actions
Copy link

github-actions bot commented Feb 15, 2022

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.34ms ± 5%    1.78ms ± 1%  +32.71%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            3.02ms ± 2%    4.18ms ±13%  +38.39%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.04ms ± 2%    1.40ms ± 4%  +34.01%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         814µs ± 2%    1078µs ± 2%  +32.45%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     947µs ± 1%    1274µs ± 3%  +34.55%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      857µs ± 1%    1145µs ± 2%  +33.53%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      23.4ms ± 1%    29.1ms ± 3%  +24.74%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.27ms ± 1%    1.67ms ± 3%  +31.41%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          2.01µs ± 1%    2.59µs ± 2%  +28.45%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               252kB ± 0%     253kB ± 0%   +0.24%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            1.07MB ± 0%    1.07MB ± 0%     ~     (p=0.548 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     253kB ± 0%     253kB ± 0%   +0.20%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         208kB ± 0%     208kB ± 0%   +0.17%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     254kB ± 0%     255kB ± 0%   +0.34%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      235kB ± 0%     236kB ± 0%   +0.30%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      4.19MB ± 0%    4.19MB ± 0%     ~     (p=0.310 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.30MB ± 0%    1.30MB ± 0%   +0.09%  (p=0.016 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            608B ± 0%      608B ± 0%     ~     (all equal)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               6.33k ± 0%     6.33k ± 0%     ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2             21.4k ± 0%     21.4k ± 0%     ~     (p=0.825 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     7.25k ± 0%     7.25k ± 0%     ~     (p=0.556 n=5+4)
ImagePackageCatalogers/javascript-package-cataloger-2         5.36k ± 0%     5.36k ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     7.10k ± 0%     7.10k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                      6.82k ± 0%     6.82k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       86.8k ± 0%     86.8k ± 0%     ~     (p=0.937 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      7.37k ± 0%     7.37k ± 0%     ~     (p=0.881 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            14.0 ± 0%      14.0 ± 0%     ~     (all equal)

@wagoodman wagoodman force-pushed the improve-install-across-versions branch from 22d09f4 to d08ef19 Compare February 15, 2022 21:41
@kzantow
Copy link
Contributor

kzantow commented Feb 15, 2022

Might be worth adding continue-on-error: true to the sbom-action step?

Signed-off-by: Alex Goodman <[email protected]>
@wagoodman wagoodman enabled auto-merge (squash) February 15, 2022 22:21
@wagoodman wagoodman merged commit 55c7f3d into main Feb 15, 2022
@wagoodman wagoodman deleted the improve-install-across-versions branch February 15, 2022 22:23
spiffcs added a commit that referenced this pull request Feb 17, 2022
…hore/syft into 510-attach-sbomb-attestation

* '510-attach-sbomb-attestation' of https://github.com/anchore/syft:
  Upgrade install.sh to support installations for previous versions (#830)
  remove duplicate manifest lines (#828)
  bump stereoscope to include functional options (#823)
  update golang crypto library dependency (#815)
  deduplicate SPDX tag-value package IDs (#813)
  Add pURL generation for java packages + fix NPM pURL generation (#812)
spiffcs added a commit that referenced this pull request Feb 17, 2022
* main:
  Upgrade install.sh to support installations for previous versions (#830)
  remove duplicate manifest lines (#828)
  bump stereoscope to include functional options (#823)
  update golang crypto library dependency (#815)
  deduplicate SPDX tag-value package IDs (#813)
  Add pURL generation for java packages + fix NPM pURL generation (#812)

Signed-off-by: Christopher Phillips <[email protected]>
spiffcs pushed a commit that referenced this pull request Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants