Thanks to visit codestin.com
Credit goes to github.com

Skip to content

remove duplicate manifest lines #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2022
Merged

remove duplicate manifest lines #828

merged 1 commit into from
Feb 15, 2022

Conversation

@spiffcs
Copy link
Contributor

@spiffcs spiffcs commented Feb 15, 2022

Signed-off-by: Christopher Phillips [email protected]

@spiffcs
remove duplicate manifest lines
d3e8c13 
Signed-off-by: Christopher Phillips <[email protected]>
@github-actions
Copy link

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.85ms ± 3%    1.29ms ± 1%  -29.92%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            4.24ms ± 8%    3.05ms ± 7%  -27.96%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.40ms ± 7%    1.03ms ± 1%  -26.52%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2        1.06ms ± 2%    0.81ms ± 2%  -23.69%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                    1.27ms ± 3%    0.95ms ± 1%  -25.32%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                     1.12ms ± 2%    0.85ms ± 1%  -23.83%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      29.2ms ± 3%    23.4ms ± 1%  -19.84%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.64ms ± 1%    1.28ms ± 1%  -21.65%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          2.46µs ± 3%    2.05µs ± 1%  -16.53%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               253kB ± 0%     252kB ± 0%   -0.29%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            1.07MB ± 0%    1.06MB ± 0%   -0.16%  (p=0.032 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     253kB ± 0%     253kB ± 0%     ~     (p=0.056 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         208kB ± 0%     208kB ± 0%   -0.33%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     255kB ± 0%     254kB ± 0%   -0.47%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      236kB ± 0%     235kB ± 0%   -0.25%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      4.20MB ± 0%    4.19MB ± 0%   -0.31%  (p=0.016 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.30MB ± 0%    1.30MB ± 0%   -0.10%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            608B ± 0%      608B ± 0%     ~     (all equal)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               6.33k ± 0%     6.33k ± 0%     ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2             21.4k ± 0%     21.4k ± 0%     ~     (p=0.968 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     7.25k ± 0%     7.25k ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         5.36k ± 0%     5.36k ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     7.10k ± 0%     7.10k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                      6.82k ± 0%     6.82k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       86.8k ± 0%     86.8k ± 0%     ~     (p=0.079 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      7.37k ± 0%     7.37k ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            14.0 ± 0%      14.0 ± 0%     ~     (all equal)

@wagoodman wagoodman linked an issue Feb 15, 2022 that may be closed by this pull request
Deduplicate docker image manifests #825
Closed
@wagoodman wagoodman merged commit 52d2e62 into main Feb 15, 2022
@wagoodman wagoodman deleted the remove-duplicate-manifest branch February 15, 2022 17:51
spiffcs added a commit that referenced this pull request Feb 17, 2022
@spiffcs
Merge branch '510-attach-sbomb-attestation' of https://github.com/anc…
6c2fe7d 
…hore/syft into 510-attach-sbomb-attestation

* '510-attach-sbomb-attestation' of https://github.com/anchore/syft:
  Upgrade install.sh to support installations for previous versions (#830)
  remove duplicate manifest lines (#828)
  bump stereoscope to include functional options (#823)
  update golang crypto library dependency (#815)
  deduplicate SPDX tag-value package IDs (#813)
  Add pURL generation for java packages + fix NPM pURL generation (#812)
spiffcs added a commit that referenced this pull request Feb 17, 2022
@spiffcs
Merge branch 'main' into 510-attach-sbomb-attestation
4f46f92 
* main:
  Upgrade install.sh to support installations for previous versions (#830)
  remove duplicate manifest lines (#828)
  bump stereoscope to include functional options (#823)
  update golang crypto library dependency (#815)
  deduplicate SPDX tag-value package IDs (#813)
  Add pURL generation for java packages + fix NPM pURL generation (#812)

Signed-off-by: Christopher Phillips <[email protected]>
spiffcs added a commit that referenced this pull request Feb 18, 2022
@spiffcs
remove duplicate manifest lines (#828)
7425b3b 
Signed-off-by: Christopher Phillips <[email protected]>
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@spiffcs
remove duplicate manifest lines (anchore#828)
a13e435
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wagoodman wagoodman wagoodman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deduplicate docker image manifests

3 participants

@spiffcs @wagoodman