Fix github-json output option
#967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven Maude <[email protected]>
Signed-off-by: Steven Maude <[email protected]>
|
Two things:
|
|
@StevenMaude this format isn't completely finalized. I'm not sure we should treat it as such until it is finalized, but at such time |
|
@StevenMaude thanks for fixing this. Your PR has one last thing to pass our tests, there is a code formatting issue, to fix it just run the following command from the project directory in your local machine: make lint-fixThen commit the changes and it should be good. I will be here if you need help. |
Signed-off-by: Steven Maude <[email protected]>
|
@jonasagx: thanks for your patience! Hopefully I've wrangled it, I think it was just a |
jonasagx
approved these changes
May 4, 2022
spiffcs
added a commit
that referenced
this pull request
May 6, 2022
* main: feat: add initial dotnet-support (#951) unblock timeout for power-user select CLI tests (#985) golang cataloger - main module version as is (#986) Fix `github-json` output option (#967) read Go main module version as is - (devel) (#981) reduce logging severity for non-Go binaries (#983) golang.org/x/crypto upgrade (#979)
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
* Fix "bad output format" for `github-json` output Signed-off-by: Steven Maude <[email protected]> * Update formats in README Signed-off-by: Steven Maude <[email protected]> * Run `make lint-fix` Signed-off-by: Steven Maude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following problem in Syft 0.44.1: