Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@spiffcs
Copy link
Contributor

@spiffcs spiffcs commented May 2, 2022

Signed-off-by: Christopher Phillips [email protected]

Signed-off-by: Christopher Phillips <[email protected]>
@spiffcs spiffcs changed the title crypto upgrade golang.org/x/crypto upgrade May 2, 2022
@spiffcs spiffcs linked an issue May 2, 2022 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented May 2, 2022

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.18ms ± 1%    1.42ms ± 2%  +19.85%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            3.03ms ± 1%    3.59ms ± 7%  +18.63%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.01ms ± 7%    1.16ms ± 2%  +14.64%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         651µs ± 2%     780µs ± 2%  +19.83%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     784µs ± 1%     942µs ± 2%  +20.18%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      703µs ± 2%     848µs ± 7%  +20.67%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      14.2ms ± 3%    16.6ms ± 5%  +17.13%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.28ms ± 1%    1.42ms ± 4%  +11.60%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          2.20µs ± 1%    2.51µs ± 3%  +13.95%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               184kB ± 0%     184kB ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             897kB ± 0%     895kB ± 0%   -0.26%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     196kB ± 0%     196kB ± 0%     ~     (p=0.548 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         140kB ± 0%     140kB ± 0%     ~     (p=0.151 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     176kB ± 0%     176kB ± 0%   -0.13%  (p=0.024 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      164kB ± 0%     164kB ± 0%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.29MB ± 0%    3.29MB ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.24MB ± 0%    1.24MB ± 0%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            672B ± 0%      672B ± 0%     ~     (all equal)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               3.66k ± 0%     3.66k ± 0%     ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2             14.8k ± 0%     14.8k ± 0%     ~     (p=0.738 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     4.94k ± 0%     4.94k ± 0%     ~     (p=0.881 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         2.72k ± 0%     2.72k ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     3.95k ± 0%     3.95k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                      4.02k ± 0%     4.02k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       52.2k ± 0%     52.2k ± 0%     ~     (p=0.873 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      4.83k ± 0%     4.83k ± 0%     ~     (p=0.365 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            15.0 ± 0%      15.0 ± 0%     ~     (all equal)

Signed-off-by: Christopher Phillips <[email protected]>
@spiffcs spiffcs enabled auto-merge (squash) May 2, 2022 21:19
@spiffcs spiffcs merged commit 03d51c3 into main May 2, 2022
@spiffcs spiffcs deleted the upgrade-go-crypto branch May 2, 2022 21:33
@spiffcs spiffcs added the security related to vulnerability remediation label May 3, 2022
rigzba21 pushed a commit to rigzba21/syft that referenced this pull request May 5, 2022
spiffcs added a commit that referenced this pull request May 6, 2022
* main:
  feat: add initial dotnet-support (#951)
  unblock timeout for power-user select CLI tests (#985)
  golang cataloger - main module version as is (#986)
  Fix `github-json` output option (#967)
  read Go main module version as is - (devel) (#981)
  reduce logging severity for non-Go binaries (#983)
  golang.org/x/crypto upgrade (#979)
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security related to vulnerability remediation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update golang crypto library dependency

3 participants