golang cataloger - main module version as is #986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonas Xavier <[email protected]>
spiffcs
added a commit
that referenced
this pull request
May 6, 2022
* main: feat: add initial dotnet-support (#951) unblock timeout for power-user select CLI tests (#985) golang cataloger - main module version as is (#986) Fix `github-json` output option (#967) read Go main module version as is - (devel) (#981) reduce logging severity for non-Go binaries (#983) golang.org/x/crypto upgrade (#979)
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Signed-off-by: Jonas Xavier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#981 overwrites the main version, which doesn't follow Syft's design philosophy of reading data fields as they are. It just so happens that we know the version and it is a constant.
This PR fixes that behavior by reading the main module version as provided by go's BuildInfo.
Signed-off-by: Jonas Xavier [email protected]