Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: missing references #8207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ematipico merged 2 commits into from
Nov 21, 2025
Merged

docs: missing references #8207

ematipico merged 2 commits into from
Nov 21, 2025

Conversation

@Netail
Copy link
Member

@Netail Netail commented Nov 21, 2025 •
edited
Loading

Summary

Missing rule references

Test Plan

Docs

@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 74d6ad1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Nov 21, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 21, 2025 •
edited
Loading

Walkthrough

The pull request adds additional RuleSource declarations to two lint rules' public exports: UseMaxParams now includes RuleSource::EslintTypeScript("max-params").same() alongside the existing Eslint("max-params") and Clippy("too_many_arguments"); UseJsxKeyInIterable now includes RuleSource::EslintQwik("jsx-key").same() in addition to RuleSource::EslintReact("jsx-key").same(). These are metadata-only changes; no logic, behaviour, or error handling was modified.

Suggested labels: A-Linter

Possibly related PRs

  • docs: rules.rs cleanup #8044 — Adds and renames multiple RuleSource variants (including EslintQwik) and aligns with the new ESLint-style RuleSource usages.

Suggested reviewers

  • dyc3
  • ematipico

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'docs: missing references' is vague and doesn't clearly convey what references are being added. It lacks specificity about which rules or sources are involved. Consider a more descriptive title like 'Add TypeScript ESLint and Qwik sources to lint rules' to better reflect the actual changes made.
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The description 'Missing rule references' is minimalist but does relate to the changeset, which adds rule source references for ESLint TypeScript and Qwik implementations.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9affc94 and 6537473.

📒 Files selected for processing (2)
  • crates/biome_js_analyze/src/lint/correctness/use_jsx_key_in_iterable.rs (1 hunks)
  • crates/biome_js_analyze/src/lint/nursery/use_max_params.rs (1 hunks)
🧰 Additional context used
🧬 Code graph analysis (2)
crates/biome_js_analyze/src/lint/nursery/use_max_params.rs (1)
crates/biome_analyze/src/rule.rs (2)
  • sources (617-620)
  • same (246-251)
crates/biome_js_analyze/src/lint/correctness/use_jsx_key_in_iterable.rs (1)
crates/biome_analyze/src/rule.rs (2)
  • sources (617-620)
  • same (246-251)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
  • GitHub Check: Documentation
  • GitHub Check: End-to-end tests
  • GitHub Check: Test (depot-ubuntu-24.04-arm-16)
  • GitHub Check: Check Dependencies
  • GitHub Check: Test (depot-windows-2022-16)
  • GitHub Check: Lint project (depot-windows-2022)
  • GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
  • GitHub Check: Test Node.js API
  • GitHub Check: autofix
  • GitHub Check: Bench (biome_js_analyze)
  • GitHub Check: Bench (biome_js_parser)
  • GitHub Check: Bench (biome_js_formatter)
🔇 Additional comments (2)
crates/biome_js_analyze/src/lint/correctness/use_jsx_key_in_iterable.rs (1)

65-65: LGTM – Qwik source reference now complete.

The addition of EslintQwik source aligns perfectly with the existing documentation (line 23) and domain declaration (line 68). This completes the metadata.

crates/biome_js_analyze/src/lint/nursery/use_max_params.rs (1)

77-77: LGTM – TypeScript ESLint source reference added.

Correctly adds the TypeScript ESLint source alongside the existing ESLint and Clippy sources. The use of .same() is appropriate as the logic matches.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the A-CLI Area: CLI label Nov 21, 2025
@Jayllyz
Copy link
Contributor

Jayllyz commented Nov 21, 2025

My bad I forgot it when I did this rules, thx for adding it

@Netail Netail force-pushed the docs/ts-version-reference branch from c7f5554 to 6537473 Compare November 21, 2025 15:50
@Netail Netail changed the title docs: reference to ts eslint rule docs: missing references Nov 21, 2025
@ematipico ematipico added this pull request to the merge queue Nov 21, 2025
Merged via the queue into biomejs:main with commit 1b4d796 Nov 21, 2025
16 checks passed
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 21, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8207 will not alter performance

Comparing Netail:docs/ts-version-reference (74d6ad1) with main (cd2edd7)

Summary

✅ 58 untouched
⏩ 95 skipped1

Footnotes

  1. 95 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@coderabbitai coderabbitai bot mentioned this pull request Nov 21, 2025
Merged
ryan-m-walker pushed a commit to ryan-m-walker/biome that referenced this pull request Nov 23, 2025
@Netail @autofix-ci @ryan-m-walker
docs: missing references (biomejs#8207)
6445fc8 
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
@Netail Netail deleted the docs/ts-version-reference branch November 25, 2025 08:49
l0ngvh pushed a commit to l0ngvh/biome that referenced this pull request Dec 21, 2025
@Netail @autofix-ci @l0ngvh
docs: missing references (biomejs#8207)
e520b1c 
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

Assignees

No one assigned

Labels

A-CLI Area: CLI A-Linter Area: linter L-JavaScript Language: JavaScript and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Netail @Jayllyz @ematipico