[WIP] Storage in Image Management #28
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrunalp
reviewed
Sep 17, 2016
cmd/client/main.go
Outdated
| // Set up a connection to the server. | ||
| conn, err := getClientConnection() | ||
| if err != nil { | ||
| return fmt.Errorf("Failed to connect: %v", err) |
Member
There was a problem hiding this comment.
nit: Failed -> failed. We probably need to fix this all over the code.
Member
Author
There was a problem hiding this comment.
I will, probably going to submit a separate PR
Member
Author
There was a problem hiding this comment.
Done here, I'm submitting a separate PR for the other cases
Member
|
Nice! I will test and review in more detail. |
Member
Author
|
@mrunalp great, I haven't tested everything yet on the image management side, will probably do so tomorrow or Monday as I implement the remaining client calls related to images. |
22b7b96 to
0ebd399
Compare
Member
Author
|
added image list and delete functionalities to the cli |
Signed-off-by: Antonio Murdaca <[email protected]>
Flesh out the implementations of various image-related functions. Signed-off-by: Nalin Dahyabhai <[email protected]> Signed-off-by: Antonio Murdaca <[email protected]>
Signed-off-by: Antonio Murdaca <[email protected]>
Signed-off-by: Antonio Murdaca <[email protected]>
Signed-off-by: Antonio Murdaca <[email protected]>
Signed-off-by: Antonio Murdaca <[email protected]>
Signed-off-by: Antonio Murdaca <[email protected]>
Contributor
|
Any movement on this? |
Member
Author
This was referenced Oct 20, 2016
Member
Author
|
@nalind is gonna take this and re-open it. Closing. |
jwcesign
referenced
this pull request
in jwcesign/cri-o
May 1, 2022
bumping knative.dev/hack 11d193b...b284d49: > b284d49 fix the latest_version function (# 101) > 42a2ccb Release use `knative-vX.Y.Z` tag and infer go module tag version automatically (# 98) > a42c72a Update community files (# 95) > 810ab22 Make go_update_deps module-release aware (# 93) > f1228dd Update community files (# 90) Signed-off-by: Knative Automation <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is tackling image management operations from #8.
This work is based on containers/image#63 by vendoring @nalind's branch
add-storage-transporthere and by applying and modifying some of his patches from his ocid branch at https://github.com/nalind/ocid/tree/storage-tests.The last commits add images pull and delete functionalities like so:
Plan is:
This might not be perfect as a whole when taking into account containers rootfs management but it's a start - at least in the direction of image management. Containers' rootfs management will come as part of another PR since this is already huge.
/cc @nalind @mrunalp PTAL
@nalind if you want to carry this please do so - I opened it so we have a WIP branch everyone can test and look around. Also opened this to avoid you re-vendoring everything and rebasing.