[release-1.19] oci: improve error message for verifyPid() #4154
Conversation
Signed-off-by: Peter Hunt <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## release-1.19 #4154 +/- ##
================================================
+ Coverage 41.58% 41.60% +0.01%
================================================
Files 110 110
Lines 9046 9049 +3
================================================
+ Hits 3762 3765 +3
Misses 4944 4944
Partials 340 340 |
| if startTime != c.state.InitStartTime { | ||
| return errors.New("PID running but not the original container. PID wrap may have occurred") | ||
| return errors.Errorf( | ||
| "PID %d is running but has start time of %d, whereas the saved start time is %d. PID wrap may have occurred", |
There was a problem hiding this comment.
I know this is old, but will people know what "pid wrap" is?
There was a problem hiding this comment.
a quick google of pid wrap linux gives me the answer, so I don't think there's any more explaination needed
|
LGTM |
|
/retest |
1 similar comment
|
/retest |
|
/retest |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
this is included in #4166 |
This is an automated cherry-pick of #4139
/assign haircommander