Hi @thanos1983. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: thanos1983
To complete the pull request process, please assign haircommander after the PR has been reviewed.
You can assign the PR to them by writing /assign @haircommander in a comment when ready.

The full list of commands accepted by this bot can be found here.

@haircommander Let me know if there is something that I can help with :).

Codecov Report

Merging #5374 (c8fa1b8) into main (ab99b3d) will decrease coverage by 0.25%.
The diff coverage is 47.19%.

@@            Coverage Diff             @@
##             main    #5374      +/-   ##
==========================================
- Coverage   43.75%   43.49%   -0.26%     
==========================================
  Files         118      118              
  Lines       11737    11786      +49     
==========================================
- Hits         5135     5126       -9     
- Misses       6114     6168      +54     
- Partials      488      492       +4     

hm you seem to have a merge conflict, can you rebase on current main?

/ok-to-test
thanks @thanos1983 !

also can you sign-off the commit with
git commit --amend -s
?

also can you sign-off the commit with git commit --amend -s ?

Will fix the conflict in a bit. :)

hm it seems the commits are a bit off. Can you do:

git fetch upstream
git rebase -i upstream/main

specifically, I think we should be dropping the merge commits

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

• e6b2e31 5368/Adding-documentation-for-certificates Adding documentation for CAs and also for deployment in metrics directly wihtout the need to go through the repo.
• 0f174a4 Merge pull request Remove usge of deprecated apt-key in Ubuntu install #5369 from tadayosi/ubuntu-install
• 6b40049 Merge pull request test: skip certificate check for downloading parallel #5378 from haircommander/test-cert-fix
• 4a0630e 5368/Adding-documentation-for-certificates updating based on comments.
• 52b0fe3 5368/Adding-documentation-for-certificates updating based on comments.
• 4d06d44 5368/Adding-documentation-for-certificates updating based on comments.
• 3849053 5368/Adding-documentation-for-certificates fixing rebase.
• 5d6f29e Merge branch '5368/Adding-documentation-for-certificates' of github.com:thanos1983/cri-o into 5368/Adding-documentation-for-certificates
• 1747eec Merge pull request test: add label for openshift e2e in dockerfile #5384 from haircommander/fix-openshift-e2e
• ee3dfeb Merge pull request build(deps): bump github.com/containerd/containerd from 1.5.5 to 1.5.7 #5381 from cri-o/dependabot/go_modules/github.com/containerd/containerd-1.5.7
• fc8d744 Merge pull request build(deps): bump github.com/opencontainers/selinux from 1.8.5 to 1.9.1 #5385 from cri-o/dependabot/go_modules/github.com/opencontainers/selinux-1.9.1
• c6c4488 Merge pull request build(deps): bump google.golang.org/grpc from 1.40.0 to 1.41.0 #5351 from cri-o/dependabot/go_modules/google.golang.org/grpc-1.41.0
• 6f94575 Merge pull request build(deps): bump github.com/creack/pty from 1.1.15 to 1.1.16 #5355 from cri-o/dependabot/go_modules/github.com/creack/pty-1.1.16
• b393084 Merge pull request server: conditionally relabel volumes given annotation #5373 from haircommander/selinux-maybe
• c8bbae9 Merge pull request build(deps): bump github.com/containers/storage from 1.36.0 to 1.37.0 #5372 from cri-o/dependabot/go_modules/github.com/containers/storage-1.37.0
• ec27c38 Merge pull request Fix runtime handler docs #5395 from saschagrunert/runtime-handler-docs
• 90d9f9c Merge pull request build(deps): bump sigs.k8s.io/yaml from 1.2.0 to 1.3.0 #5350 from cri-o/dependabot/go_modules/sigs.k8s.io/yaml-1.3.0
• 25c9823 Merge pull request test: fix selinux test failures #5400 from haircommander/debug-selinux-test
• b0d0341 Merge pull request Skip volume relabel for super privileged containers #5386 from saschagrunert/skip-relabel-spc_t
• 1c628f7 Merge pull request oci: use c/common signal parsing function #5366 from haircommander/fix-stop-signal
• 30ffc09 Merge pull request Log HTTP response writer message instead an error #5405 from saschagrunert/log-responsewriter
• 1ada8e7 Merge pull request add allowed annotations to workloads #5358 from haircommander/workload-annotations
• bee4f76 Merge pull request build(deps): bump github.com/creack/pty from 1.1.16 to 1.1.17 #5412 from cri-o/dependabot/go_modules/github.com/creack/pty-1.1.17
• 980ebf7 Merge pull request build(deps): bump github.com/Microsoft/go-winio from 0.5.0 to 0.5.1 #5411 from cri-o/dependabot/go_modules/github.com/Microsoft/go-winio-0.5.1
• e39c631 Merge pull request Bump Kubernetes to v1.22.2 #5410 from saschagrunert/k8s-bump
• f585d24 Merge pull request build(deps): bump github.com/containerd/cgroups from 1.0.1 to 1.0.2 #5397 from cri-o/dependabot/go_modules/github.com/containerd/cgroups-1.0.2
• e47206f Merge pull request Refactor internal types to reduce needless copying #5409 from haircommander/types-refactor
• 7163dbb Merge pull request build(deps): bump github.com/onsi/ginkgo from 1.16.4 to 1.16.5 #5398 from cri-o/dependabot/go_modules/github.com/onsi/ginkgo-1.16.5
• 8a6b305 Merge pull request scripts: fix release branch forward script #5388 from haircommander/release-branch-forward
• 22986bd Merge pull request build(deps): bump github.com/containers/image/v5 from 5.15.2 to 5.16.1 #5383 from cri-o/dependabot/go_modules/github.com/containers/image/v5-5.16.1
• c22219b Merge pull request build(deps): bump github.com/containers/common from 0.43.2 to 0.46.0 #5349 from cri-o/dependabot/go_modules/github.com/containers/common-0.46.0
• 6548676 Merge pull request build(deps): bump github.com/containers/podman/v3 from 3.3.1 to 3.4.1 #5416 from cri-o/dependabot/go_modules/github.com/containers/podman/v3-3.4.1
• cf735cf Merge pull request version: bump to 1.23.0 #5417 from haircommander/bump-1.23
• 051da6c 5368/Adding-documentation-for-certificates updating based on comments.

hm it seems the commits are a bit off. Can you do:

git fetch upstream
git rebase -i upstream/main

specifically, I think we should be dropping the merge commits

Hello @haircommander,

I am really bad with the process but I hope now it looks better :).

Let me know if there is anything that I could help with.

BR / Thanos

@thanos1983: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

@thanos1983: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Full PR test history. Your PR dashboard.

Hey @thanos1983, thanks for sticking with it.

i have pulled your branch and squashed the commits into one. you can take a look at github.com/haircommander/cri-o/tree/5368. I recommend doing:

git remote add haircommander [email protected]:haircommander/cri-o.git
git fetch haircommander

git checkout upstream/main
git checkout -b 5368-adding-docs
git cherry-pick 811120076a52550ff38d3b0d11b7eaecd7ec05bc
git push origin 5368-adding-docs

and opening a new PR. This one is able to be used, but the instructions to do so would be more complicated. I hope this helps :)

Closing this PR as unfortunately I messed it up :). Follow new PR Workaround on new CA from Ubuntu. Also minor documentation improvemen… #5420