Thanks to visit codestin.com
Credit goes to github.com

Skip to content

update go to 1.17 in go.mod #5577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 31, 2022
Merged

update go to 1.17 in go.mod #5577

openshift-merge-robot merged 1 commit into from
Jan 31, 2022

Conversation

@QiWang19
Copy link
Member

@QiWang19 QiWang19 commented Jan 27, 2022 •
edited
Loading

Update go to 1.17 in go.mod (Replace #5473)

Signed-off-by: rockmenjack [email protected]
Signed-off-by: Qi Wang [email protected]

What type of PR is this?

/kind dependency-change

What this PR does / why we need it:

golang 1.15 can no longer compile cri-o because kubernetes/client-go@ef1d5d2 has introduced io/fs which comes with golang 1.17

# make binaries
mkdir -p "/root/cri-o/_output/src/github.com/cri-o"
ln -s "/root/cri-o" "/root/cri-o/_output/src/github.com/cri-o/cri-o"
touch "/root/cri-o/_output/.gopathok"
go build -trimpath  -ldflags '-s -w -X github.com/cri-o/cri-o/internal/pkg/criocli.DefaultsPath="" -X github.com/cri-o/cri-o/internal/version.buildDate='2021-11-24T03:40:58Z' -X github.com/cri-o/cri-o/internal/version.gitCommit=2811bd6afea913deb176acd667b904978c273e81 -X github.com/cri-o/cri-o/internal/version.gitTreeState=clean ' -tags "containers_image_ostree_stub  exclude_graphdriver_btrfs btrfs_noversion exclude_graphdriver_devicemapper libdm_no_deferred_remove    " -o bin/crio github.com/cri-o/cri-o/cmd/crio
vendor/k8s.io/client-go/plugin/pkg/client/auth/exec/metrics.go:21:2: cannot find package "." in:
        /root/cri-o/vendor/io/fs
make: *** [Makefile:172: bin/crio] Error 1

Which issue(s) this PR fixes:

this PR just update go.mod to reflect dependency on golang 1.17+

Special notes for your reviewer:

Does this PR introduce a user-facing change?

update go to 1.17 in go.mod

@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 27, 2022
@openshift-ci openshift-ci bot requested review from fidencio and vrothberg January 27, 2022 14:43
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 27, 2022
@codecov
Copy link

codecov bot commented Jan 27, 2022 •
edited
Loading

Codecov Report

Merging #5577 (1fd26ac) into main (1801aea) will not change coverage.
The diff coverage is n/a.

❗ Current head 1fd26ac differs from pull request most recent head ef17460. Consider uploading reports for the commit ef17460 to get more accurate results

@@           Coverage Diff           @@
##             main    #5577   +/-   ##
=======================================
  Coverage   43.22%   43.22%           
=======================================
  Files         123      123           
  Lines       12214    12214           
=======================================
  Hits         5280     5280           
  Misses       6426     6426           
  Partials      508      508

@QiWang19
Copy link
Member Author

QiWang19 commented Jan 27, 2022

@cri-o/cri-o-maintainers PTAL

@haircommander
Copy link
Member

haircommander commented Jan 27, 2022

thanks for taking this over, openshift CI is sad today. if it doesn't get fixed by tomorrow, I'll push this through

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, QiWang19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2022
@haircommander
Copy link
Member

haircommander commented Jan 28, 2022

/retest

@haircommander
Copy link
Member

haircommander commented Jan 31, 2022

can you rebase to fix CI @QiWang19 ?

@rockmenjack @QiWang19
update go to 1.17 in go.mod
ef17460 
Signed-off-by: rockmenjack <[email protected]>
Signed-off-by: Qi Wang <[email protected]>
@haircommander haircommander mentioned this pull request Jan 31, 2022
Closed
@haircommander
Copy link
Member

haircommander commented Jan 31, 2022

/retest
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2022 •
edited
Loading

@QiWang19: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 ef17460 link false /test e2e_cgroupv2
ci/openshift-jenkins/integration_crun_cgroupv2 ef17460 link false /test integration_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

openshift-bot commented Jan 31, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 62cf7fb into cri-o:main Jan 31, 2022
@QiWang19 QiWang19 mentioned this pull request Feb 14, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom

@fidencio fidencio Awaiting requested review from fidencio

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@QiWang19 @haircommander @openshift-bot @openshift-merge-robot @rockmenjack