Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.21] Bug 1977100: retry setting CPU load balancing #5919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
openshift-cherrypick-robot wants to merge 1 commit into from
Closed

[release-1.21] Bug 1977100: retry setting CPU load balancing #5919

openshift-cherrypick-robot wants to merge 1 commit into from

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented May 31, 2022 •
edited by kolyshkin
Loading

This is an automated cherry-pick of #5786

/assign kolyshkin

Fixed failure to start a pod with CPU load balancing disabled (RHBZ 1977100)

Retry to set CPU load balancing before return the error
3ebbc6e 
It possible that the kernel will rebuild sched_domain related files and
because of it enabling or disabling CPU load balancing for container CPUs
will fail with different file errors:

1. lstat /proc/sys/kernel/sched_domain/cpu22/domain1/flags: no such file or directory
2. readdirent /proc/sys/kernel/sched_domain/cpu66/domain0: no such file or directory

Add retry logic around setting CPU load balancing values to reduce possibility of such errors.

Signed-off-by: Artyom Lukianov <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 31, 2022
Merged
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 31, 2022
@openshift-ci openshift-ci bot requested a review from kolyshkin May 31, 2022 18:02
kolyshkin
kolyshkin approved these changes May 31, 2022
View reviewed changes
Copy link
Collaborator

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kolyshkin, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 31, 2022
@kolyshkin
Copy link
Collaborator

kolyshkin commented May 31, 2022

verify / lint failure is being fixed by #5918

@codecov
Copy link

codecov bot commented May 31, 2022 •
edited
Loading

Codecov Report

Merging #5919 (3ebbc6e) into release-1.21 (8ed37a9) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release-1.21    #5919      +/-   ##
================================================
- Coverage         44.97%   44.94%   -0.04%     
================================================
  Files               109      109              
  Lines             11063    11071       +8     
================================================
  Hits               4976     4976              
- Misses             5608     5616       +8     
  Partials            479      479

@haircommander
Copy link
Member

haircommander commented May 31, 2022

I agree we should pull this to 1.21, but we typically pull to all branches before it first. It doesn't seem to be in 1.22 or 1.23 yet

@kolyshkin
Copy link
Collaborator

kolyshkin commented May 31, 2022

It doesn't seem to be in 1.22 or 1.23 yet

1.22: #5920
1.23: #5921

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/e2e_crun 3ebbc6e link true /test e2e_crun
ci/openshift-jenkins/integration_crun_cgroupv2 3ebbc6e link false /test integration_cgroupv2
ci/openshift-jenkins/e2e_crun_cgroupv2 3ebbc6e link false /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 1, 2022
@github-actions
Copy link

github-actions bot commented Oct 25, 2022

Closing this PR since it had no activity in the past 90 days.

@github-actions github-actions bot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 25, 2022
@github-actions github-actions bot closed this Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kolyshkin kolyshkin kolyshkin approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

Assignees

@kolyshkin kolyshkin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@openshift-cherrypick-robot @kolyshkin @haircommander