[1.25] Allow runtimes to be reloaded #6270
Merged
+159
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we want to validate the default runtime separately when reloading the runtime config we factor out default runtime validation into a ValidateDefaultRuntime method. Signed-off-by: Evan Lezar <[email protected]>
This change cleans up the conditional checks in ValidateDefaultRuntime for readability. Signed-off-by: Evan Lezar <[email protected]>
This change includes the update of runtime configs on a config reload. This is currently limited to: * Changing the default runtime * Adding new runtimes Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
Member
Author
|
cc @elezar |
Signed-off-by: Evan Lezar <[email protected]>
d95c224 to
aa329a1
Compare
Contributor
|
Thanks @haircommander. Glad to see that this will make it into 1.25. Do you need anything else from me? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-1.25 #6270 +/- ##
================================================
+ Coverage 43.67% 43.69% +0.01%
================================================
Files 122 122
Lines 13625 13659 +34
================================================
+ Hits 5951 5968 +17
- Misses 7030 7046 +16
- Partials 644 645 +1 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
cherry-pick of #6248 and #6056
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?