Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[1.25] Use containerd v1.7.0-beta.0 #6382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Nov 18, 2022
Merged

[1.25] Use containerd v1.7.0-beta.0 #6382

openshift-merge-robot merged 1 commit into from
Nov 18, 2022

Conversation

@littlejawa
Copy link
Contributor

@littlejawa littlejawa commented Nov 17, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

containerd has released a new version v1.7.0-beta.0, where the gogo/protobuf dependency was removed.
I have tried it with cri-o, and it seems to be working as expected.

This is still a beta release though, so we have to be cautious in using it. But at least, it shows that the next release of containerd should fix our problem.

This is a backport of #6381

Which issue(s) this PR fixes:

Fixes #6350

Does this PR introduce a user-facing change?

None

@littlejawa
Use containerd v1.7.0-beta.0
c431b53 
This version of containerd has removed the dependency on gogo/protobuf from the shim v2 interface.

Signed-off-by: Julien Ropé <[email protected]>
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. labels Nov 17, 2022
@openshift-ci openshift-ci bot requested review from klihub and wgahnagl November 17, 2022 17:10
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2022

Hi @littlejawa. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Member

haircommander commented Nov 17, 2022

/ok-to-test
/approve

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 17, 2022
saschagrunert
saschagrunert approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, littlejawa, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit acbb2d0 into cri-o:release-1.25 Nov 18, 2022
@littlejawa littlejawa mentioned this pull request Jan 26, 2023
Closed
4 tasks
@littlejawa littlejawa deleted the bp_containerd170 branch March 27, 2023 14:53
@yoheiueda yoheiueda mentioned this pull request Jul 24, 2023
Closed
@openshift-ci openshift-ci bot mentioned this pull request Apr 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@fidencio fidencio Awaiting requested review from fidencio fidencio is a code owner

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@klihub klihub Awaiting requested review from klihub

@wgahnagl wgahnagl Awaiting requested review from wgahnagl

Assignees

@saschagrunert saschagrunert

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@littlejawa @haircommander @saschagrunert @openshift-merge-robot