Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[1.25] Update c/common to fix umask bug #6900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 16, 2023
Merged

[1.25] Update c/common to fix umask bug #6900

openshift-merge-robot merged 1 commit into from
May 16, 2023
+80 −19

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented May 10, 2023 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

This fixes the umask 0 bug because it contains: containers/common#1421

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Manual pick of #6843

Refers to https://issues.redhat.com/browse/OCPBUGS-13282

Does this PR introduce a user-facing change?

Fixed bug where CRI-O runs with umask of `0`.

@saschagrunert
Update c/common to fix umask bug
429b5b8 
Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. labels May 10, 2023
@openshift-ci openshift-ci bot requested review from QiWang19 and klihub May 10, 2023 13:03
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2023
@saschagrunert
Copy link
Member Author

saschagrunert commented May 15, 2023 •
edited
Loading

@cri-o/cri-o-maintainers PTAL, 1.26 got verified.

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #6900 (429b5b8) into release-1.25 (592efcd) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files 
@@              Coverage Diff              @@
##           release-1.25    #6900   +/-   ##
=============================================
  Coverage         43.70%   43.70%           
=============================================
  Files               122      122           
  Lines             13675    13675           
=============================================
+ Hits               5976     5977    +1     
+ Misses             7052     7051    -1     
  Partials            647      647

@sohankunkerkar
Copy link
Member

sohankunkerkar commented May 15, 2023

seeing golanglint-ci issues:

Run golangci/golangci-lint-action@v3
prepare environment
run golangci-lint
  Running [/home/runner/golangci-lint-1.49.0-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
  Error: SA1019: validate.LastCap is deprecated: use github.com/opencontainers/runtime-tools/validate/capabilities.LastCap directly.  (staticcheck)
  
  level=warning msg="[linters context] rowserrcheck is disabled because of generics. You can track the evolution of the generics support by following the https://github.com/golangci/golangci-lint/issues/2649."
  level=warning msg="[linters context] sqlclosecheck is disabled because of generics. You can track the evolution of the generics support by following the https://github.com/golangci/golangci-lint/issues/2649."
  
  Error: issues found
  Ran golangci-lint in 338491ms

@haircommander
Copy link
Member

haircommander commented May 15, 2023

/retest
/lgtm

linter failures not related to this PR

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2023
@saschagrunert
Copy link
Member Author

saschagrunert commented May 16, 2023

/override ci/prow/e2e-agnostic
/override ci/prow/e2e-gcp

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 16, 2023

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/e2e-agnostic, ci/prow/e2e-gcp

Details

In response to this:

/override ci/prow/e2e-agnostic
/override ci/prow/e2e-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 7022a8c into cri-o:release-1.25 May 16, 2023
@saschagrunert saschagrunert deleted the 1.25-c-common branch May 16, 2023 07:26
@openshift-ci openshift-ci bot mentioned this pull request Apr 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@klihub klihub Awaiting requested review from klihub

@QiWang19 QiWang19 Awaiting requested review from QiWang19

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@saschagrunert @sohankunkerkar @haircommander @openshift-merge-robot