[Apps] New accordion groups, autocomplete search to filter by existing set of all users with App permissions #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…part 0 of breaking down the group tables into accordions
0b8cb5d to
c440947
Compare
…to roles for users (#176)
…ent when it's in an accordion element
|
Updated:
|
| const handleSearchSubmit = (_: unknown, newValue: string | null) => { | ||
| // Extract email from format "Display Name ([email protected])" | ||
| const emailMatch = newValue?.match(/\(([^)]+)\)/); | ||
| const email = emailMatch ? emailMatch[1].toLowerCase() : ''; |
There was a problem hiding this comment.
This seems widely useful and unspecific to search; might be worth tossing in helpers.tsx next to displayUserName
somethingnew2-0
previously approved these changes
Jun 30, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR refactors several list views to use a shared EmptyListEntry component for empty table states and introduces new components (AppsHeader, AppsAdminActionGroup, AppsAccordionListGroup) to support filterable, collapsible app groups in the Apps detail page.
- Replace manual "None" rows with
EmptyListEntryfor consistency across tables. - Add helper
extractEmailFromDisplayNameand wire up autocomplete search and expand/collapse inReadApp. - Introduce and export three new app-related components under
src/pages/apps/components/.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/users/Read.tsx | Swapped manual empty rows for EmptyListEntry. |
| src/pages/tags/Read.tsx | Same replacement in multiple tag-related tables. |
| src/pages/requests/Read.tsx | Added correct cellProps to EmptyListEntry. |
| src/pages/groups/Read.tsx | Updated empty state with cellProps. |
| src/pages/apps/components/index.tsx | Export new app components. |
| src/pages/apps/components/AppsHeader.tsx | New header UI for app detail. |
| src/pages/apps/components/AppsAdminActionGroup.tsx | New action bar with search & expand controls. |
| src/pages/apps/components/AppsAccordionListGroup.tsx | New accordion list for grouping users under app groups. |
| src/pages/apps/Read.tsx | Composed the above components into ReadApp. |
| src/helpers.tsx | Added extractEmailFromDisplayName helper. |
Comments suppressed due to low confidence (1)
src/pages/apps/components/AppsAccordionListGroup.tsx:29
- [nitpick] Prop
member_listuses snake_case; consider renaming tomemberListto match camelCase conventions used elsewhere.
member_list: any[];
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
somethingnew2-0
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: