refactor diagnostic service to prepare prototype work #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ween old engine and new engine moved some more files around diagnostic incremental analyzer and added option to choose between two engines.
moved v1 engine to its own namespace and updated sources accordingly. also added BaseDiagnosticIncrementalAnalyzer which contains all methods that engine needs to implement to make all other services which consume IDiagnosticAnalyzerService to just work. probably later we will change it but for now, this should let us test v2 engine isolated without too much changes in other part of code base
put middle man in between diagnostic incremental analyzer so that two version can be changed without re-starting VS.
made diagnostic analyzer to clear existing diagnostics that belong to turned off diagnostic analyzer engine
Contributor
Author
There was a problem hiding this comment.
ignore this file. it is for other change and my ignorance on git made me to include it here and not sure how to remove it.
…sticrefactoring
Contributor
Author
|
@srivatsn @shyamnamboodiripad @mavasani can you take a look? I would like to check this in and do some perf test fix. perf test fix is interleaved with this checkin. |
we can end up load analyzers for a language that does not even exist in current solution.
…sticrefactoring
Contributor
There was a problem hiding this comment.
Typo: "IncrementalAnalyzerDelegatee"
Contributor
Author
There was a problem hiding this comment.
I intended to use Delegatee.
…sticrefactoring
Contributor
|
👍 (except one minor issue I commented on in one of the files) |
Contributor
|
As we discussed offline, we need the new engine for one work or other. So its ok if we check this in for prototype work. 👍 |
…sticrefactoring
heejaechang
added a commit
that referenced
this pull request
Feb 12, 2015
refactor diagnostic service to prepare prototype work
Contributor
|
👍 |
dibarbet
pushed a commit
to dibarbet/roslyn
that referenced
this pull request
Nov 21, 2025
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactored existing diagnostic service to make it easy for us to prototype diagnostic analyzer version 2.
basically, an option is added that we can flip on the fly to switch between existing engine and new prototype.
also, added a base type that, if implemented, all existing IDE features should work as it used to.