cpu: Enable PcCountTracker in NULL builds #2684
Merged
+13
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `AbstractBoard` (which is needed for tests) depends on this object So, include this object even in NULL builds Signed-off-by: Jason Lowe-Power <[email protected]>
403a663 to
e94b61b
Compare
BobbyRBruce
approved these changes
Oct 27, 2025
It doesn't do anything in NULL builds, but the AbstractBoard imports the SimObject. The TestBoard depends on AbstractBoard, so even if you're using NULL with the TestBoard, this is required in the binary. The underlying issue is that the typing in AbstractBoard causes us to need a lot of potentially unused SimObjects (PCIBus is another example). We should revisit this at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AbstractBoard(which is needed for tests) depends on this objectSo, include this object even in NULL builds
Signed-off-by: Jason Lowe-Power [email protected]