stdlib: Remove GPU ip_discovery.bin if exists #2690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powerjg
reviewed
Oct 23, 2025
This will prevent the gem5 device specific IP discovery from being symlinked which will cause driver loading to fail and subsequently the application and simulation. The ip_discovery.bin may or may not exist depending on what the user has installed on the disk image, so use the safe option and remove whatever is there and replace with known working gem5 provided discovery files.
55a01cd to
1fc43fe
Compare
powerjg
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent the gem5 device specific IP discovery from being symlinked which will cause driver loading to fail and subsequently the application and simulation.
The ip_discovery.bin may or may not exist depending on what the user has installed on the disk image, so use the safe option and remove whatever is there and replace with known working gem5 provided discovery files.