fix: derive files from tsconfigs which extend #4006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 04dbe7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
Author
|
|
43081j
reviewed
Jul 9, 2023
| const existingOptions: CompilerOptions = {}; | ||
| if (options.exclude !== undefined) { | ||
| (configFile.config.exclude ??= []).push(...options.exclude); | ||
| existingOptions.exclude = options.exclude; |
Collaborator
There was a problem hiding this comment.
Do you know for sure that this doesn't override the excludes in the config file? Maybe you should still concat the two?
Collaborator
Author
There was a problem hiding this comment.
i don't know for sure, but internally, that param is called existingOptions, and it is processed in https://github.com/microsoft/TypeScript/blob/9701f55f7217d7bd56d28e73b250444efcefa8dd/src/compiler/commandLineParser.ts#L2859
43081j
reviewed
Jul 9, 2023
| packagePath /* basePath */, | ||
| undefined /* existingOptions */, | ||
| path.relative(packagePath, configFileName) /* configFileName */ | ||
| ts.sys, |
Collaborator
There was a problem hiding this comment.
Would be nice to keep the comments I think 👀
Collaborator
Author
|
as of a82b0e7, the analyzer picks up on my source files, but it does not seem to parse the tsconfig correctly. namely, I get a bunch of errors which i don't normally get with typescript, probably related to build mode errors |
this change reduced the number of errors when analyzing patternfly-elements from 152 to 79
Collaborator
Author
|
By tweaking my monorepo project's tsconfigs i reduced the number of errors to 17, all of which appear to be rest of the errorsSo with that in mind i think this is ready for review |
Collaborator
|
Tagging in @kevinpschaaf and @rictic both for the review, but also... we need to think about supporting multiple versions of TypeScript. |
Collaborator
Author
|
Just want to record here that declaration augmenting fixed the above errors, but I'm left with this, despite the corresponding declaration being in scope : |
Collaborator
|
I think that is because the analyzer is actually trying to find that file on disk. It should really give up if it can't. |
Collaborator
|
im still curious/mildly concerned of how the error got the analyzer explicitly passes a special lit error code, not could lead to confusion in future if other analyzer errors accidentally end up with typescript error codes... here we don't specify a |
Collaborator
Author
|
here's my calling code: async function analyze(argv: Opts) {
const { packagePath } = argv;
const path = packagePath instanceof URL ? fileURLToPath(packagePath) : join(process.cwd(), packagePath);
const analyzer = createPackageAnalyzer(path as AbsolutePath, {
exclude: [
'**/*.spec.ts',
'**/*.e2e.ts',
'**/*.d.ts',
'**/*.js',
],
});
try {
const p = analyzer.getPackage();
console.log('got package', p);
} catch (e: any) {
if (Array.isArray(e.diagnostics)) {
console.log(e.diagnostics.at(0));
const formattedDiagnostics = formatDiagnostics(e.diagnostics);
console.log(`${formattedDiagnostics}\n${e.diagnostics.length} errors`);
} else {
console.group(`Analyzer error`);
console.error(e);
console.groupEnd();
}
}
}here is the diagnostic object from {
file: <ref *1> SourceFileObject { ... },
start: 566,
length: 21,
category: 1,
code: 2323,
messageText: 'Could not resolve specifier ./BaseAccordion.css to filesystem path.'
}entire diagnostic object |
Collaborator
|
all good @bennypowers , it turns out Peter already fixed it in #3866! non-issue 🥳 i guess it just hasn't been published yet |
| path.relative(packagePath, configFileName) /* configFileName */ | ||
| isDirectory ? packagePath : path.dirname(packagePath) /* basePath */, | ||
| {} /* existingOptions */, | ||
| configFileName /* configFileName */ |
Member
There was a problem hiding this comment.
So, this whole API is really funky, but note early on I had left this comment:
lit/packages/labs/analyzer/src/lib/analyzer.ts
Lines 56 to 60 in 9a7b654
I believe this empirical finding was why the configFileName argument here was being calculated relative to basePath. But I guess if you're not getting the errors I was having with packagePath show up both in basePath and configFileName and the tests are passing, I probably just misjudged what was going on...?
kevinpschaaf
approved these changes
Jul 13, 2023
Member
kevinpschaaf
left a comment
There was a problem hiding this comment.
Ok, with these changes I've confirmed I can generate a CEM from MWC[*] source, which besides the monorepo tests, was the other thing I had been testing analyzer against, so while I can't really explain why the comment I linked from the older code would seem to indicate this change would break something, it doesn't seem to.
So LGTM, and if we find out this breaks something we'll just need to add more tests.
*To get a successful run on MWC, I did need to upgrade the TS version the analyzer was using to match what MWC was using (per known issue in #4018), and then skip over a couple of unresolvable symbols in MWC code added since I last tested (needs more investigation, but wasn't the failure mode this type of change would lead to).
justinfagnani
approved these changes
Jul 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3999