Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Set transport exchange options #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoerivanEngelen opened this issue Jan 16, 2024 · 1 comment · Fixed by #820
Closed

Set transport exchange options #747

JoerivanEngelen opened this issue Jan 16, 2024 · 1 comment · Fixed by #820
Assignees
@luitjansl
Milestone
Multi-solute tran...

Comments

@JoerivanEngelen
Copy link
Contributor 

...
    def _set_exchange_options(self):
        # collect some options that we will auto-set
        for exchange in self["split_exchanges"]:
            model_name_1 = exchange.dataset["model_name_1"].values[()]
            model_1 = self[model_name_1]
            exchange.set_options(
                save_flows=model_1["oc"].is_budget_output,
                dewatered=model_1["npf"].is_dewatered,
                variablecv=model_1["npf"].is_variable_vertical_conductance,
                xt3d=model_1["npf"].get_xt3d_option(),
                newton=model_1.is_use_newton(),
            )
...

Can be renamed to _set_flow_exchange_options. We can add a _set_transport_exchange_options method with the options for:

      [PRINT_INPUT]
      [PRINT_FLOWS]
      [SAVE_FLOWS]
      [ADV_SCHEME <adv_scheme>]
      [DSP_XT3D_OFF]
      [DSP_XT3D_RHS]

IO documentation
@github-project-automation github-project-automation bot moved this to 📯 New in iMOD Suite Jan 16, 2024
@JoerivanEngelen JoerivanEngelen moved this from 📯 New to 🤝 Accepted in iMOD Suite Jan 19, 2024
@luitjansl luitjansl mentioned this issue Feb 1, 2024
Merged
5 tasks
luitjansl added a commit that referenced this issue Feb 5, 2024
@luitjansl @JoerivanEngelen
Issue #765 gwt gwt exchanges (#800)
5f6356c 
Fixes #765 

# Description
creates gwtgwt exchange packages when splitting a simulation that
contains 1 or more transport models. A gwtgwt package is created per
partition boundary and per transport model. (while the geometry
constants are the same for all transport models, the options in the
gwtgwt file are specific to single transport models. However, for now,
these settings are not set; this will be the topic of #747
Also adds tests.

 Checklist

- [X] Links to correct issue
- [ ] Update changelog, if changes affect users
- [X] PR title starts with ``Issue #nr``, e.g. ``Issue #737``
- [X] Unit tests were added
- [ ] **If feature added**: Added/extended example

---------

Co-authored-by: Joeri van Engelen <[email protected]>
@luitjansl luitjansl moved this from 🤝 Accepted to 🏗 In Progress in iMOD Suite Feb 5, 2024
@luitjansl luitjansl self-assigned this Feb 5, 2024
@luitjansl luitjansl mentioned this issue Feb 5, 2024
Merged
5 tasks
@luitjansl luitjansl moved this from 🏗 In Progress to 🧐 In Review in iMOD Suite Feb 5, 2024
luitjansl added a commit that referenced this issue Feb 5, 2024
@luitjansl
Issue #747 transport exchange options (#820)
b790b14 
Fixes #747 

# Description
assigns the advection scheme and dispersion xt3d options to the gwtgwt
package. They are written into the options block of said file.

- [X] Links to correct issue
- [ ] Update changelog, if changes affect users
- [X] PR title starts with ``Issue #nr``, e.g. ``Issue #737``
- [X] Unit tests were added
- [ ] **If feature added**: Added/extended example
@luitjansl luitjansl moved this from 🧐 In Review to ✅ Done in iMOD Suite Feb 5, 2024
@JoerivanEngelen
Copy link
Contributor Author

Merged in #820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luitjansl luitjansl

Labels
None yet
Projects
iMOD Suite
Status: ✅ Done
Milestone
Multi-solute transport model support
Development

Successfully merging a pull request may close this issue.

Issue #747 transport exchange options Deltares/imod-python
2 participants
@JoerivanEngelen @luitjansl