Issue #765 gwt gwt exchanges #800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gwt_exchanges # Conflicts: # imod/mf6/multimodel/exchange_creator.py # imod/mf6/simulation.py # imod/tests/test_mf6/test_multimodel/test_mf6_modelsplitter_transport.py
JoerivanEngelen
requested changes
Feb 2, 2024
review comment Co-authored-by: Joeri van Engelen <[email protected]>
Manangka
approved these changes
Feb 2, 2024
review comment Co-authored-by: Joeri van Engelen <[email protected]>
JoerivanEngelen
approved these changes
Feb 5, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #765
Description
creates gwtgwt exchange packages when splitting a simulation that contains 1 or more transport models. A gwtgwt package is created per partition boundary and per transport model. (while the geometry constants are the same for all transport models, the options in the gwtgwt file are specific to single transport models. However, for now, these settings are not set; this will be the topic of #747
Also adds tests.
Checklist
Issue #nr, e.g.Issue #737