Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add GWTGWT package #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoerivanEngelen opened this issue Jan 22, 2024 · 1 comment · Fixed by #800
Closed

Add GWTGWT package #765

JoerivanEngelen opened this issue Jan 22, 2024 · 1 comment · Fixed by #800
Assignees
@luitjansl
Milestone
Multi-solute tran...

Comments

@JoerivanEngelen
Copy link
Contributor

Steps:

  • Create abstract base class "Exchange" from GWFGWF package.
  • Might be able to do that for GWFGWT as well if very similar. (Not sure anymore if coupling is cellid based or based on modelnames, if the latter, the data is too different to copy package class 1on1).
  • Implement GWTGWT package.

Note: GWTGWT uses the same geometric constants as the GWFGWF package.
@github-project-automation github-project-automation bot moved this to 📯 New in iMOD Suite Jan 22, 2024
@JoerivanEngelen JoerivanEngelen moved this from 📯 New to 📝Refined in iMOD Suite Jan 22, 2024
@luitjansl luitjansl moved this from 📝Refined to 🏗 In Progress in iMOD Suite Jan 26, 2024
@luitjansl luitjansl self-assigned this Jan 26, 2024
@luitjansl luitjansl mentioned this issue Feb 1, 2024
Merged
5 tasks
@luitjansl luitjansl moved this from 🏗 In Progress to 🧐 In Review in iMOD Suite Feb 1, 2024
luitjansl added a commit that referenced this issue Feb 5, 2024
@luitjansl @JoerivanEngelen
Issue #765 gwt gwt exchanges (#800)
5f6356c 
Fixes #765 

# Description
creates gwtgwt exchange packages when splitting a simulation that
contains 1 or more transport models. A gwtgwt package is created per
partition boundary and per transport model. (while the geometry
constants are the same for all transport models, the options in the
gwtgwt file are specific to single transport models. However, for now,
these settings are not set; this will be the topic of #747
Also adds tests.

 Checklist

- [X] Links to correct issue
- [ ] Update changelog, if changes affect users
- [X] PR title starts with ``Issue #nr``, e.g. ``Issue #737``
- [X] Unit tests were added
- [ ] **If feature added**: Added/extended example

---------

Co-authored-by: Joeri van Engelen <[email protected]>
@luitjansl luitjansl moved this from 🧐 In Review to ✅ Done in iMOD Suite Feb 5, 2024
@JoerivanEngelen
Copy link
Contributor Author

Fixed in #800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luitjansl luitjansl

Labels
None yet
Projects
iMOD Suite
Status: ✅ Done
Milestone
Multi-solute transport model support
Development

Successfully merging a pull request may close this issue.

Issue #765 gwt gwt exchanges Deltares/imod-python
2 participants
@JoerivanEngelen @luitjansl