fix: memory leak from detached snap iframes #3790
Open
+24
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Addresses memory leaks in snap execution lifecycle.
IframeExecutionService.terminateJob, cast toHTMLIFrameElement, navigate toabout:blank, then remove the iframe to ensure the prior document unloads (notably for Firefox)BaseSnapExecutor.onTerminate, removeunhandledrejectionanderrorlisteners if registered and clear handler refs to enable garbage collectionWritten by Cursor Bugbot for commit 4e1b218. This will update automatically on new commits. Configure here.
This fix should address:
MetaMask/metamask-extension#38847
MetaMask/metamask-extension#34428
MetaMask/metamask-extension#35567
My profiler showed a firefox extension (Metamask) hogging > 10GB of RAM, and the digging lead to finding event listeners aren't cleaned up on termination