Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: memory leak from detached snap iframes #3790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ocnc wants to merge 2 commits into
base: main
Choose a base branch
from
+24 −1
Open

fix: memory leak from detached snap iframes #3790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0d1d89
fix: memory leak from detached snap iframes
ocnc Dec 31, 2025
4e1b218
not needed. already handled by gc
ocnc Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/snaps-controllers/src/services/iframe/IframeExecutionService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,17 @@ export class IframeExecutionService extends AbstractExecutionService<Window> {
}

protected terminateJob(jobWrapper: TerminateJobArgs<Window>): void {
document.getElementById(jobWrapper.id)?.remove();
const iframe = document.getElementById(
jobWrapper.id,
) as HTMLIFrameElement | null;
if (iframe) {
// Navigate to about:blank before removing to ensure the browser
// unloads the previous document and cleans up its event listeners.
// Without this, Firefox may keep the detached iframe's document alive
// with all its event listeners, causing a memory leak.
iframe.src = 'about:blank';
iframe.remove();
}
}

protected async initEnvStream(snapId: string): Promise<{
Expand Down
13 changes: 13 additions & 0 deletions packages/snaps-execution-environments/src/common/BaseSnapExecutor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,19 @@ export class BaseSnapExecutor {
data.runningEvaluations.forEach((evaluation) => evaluation.stop()),
);
this.snapData.clear();

// Clean up global error handlers to prevent memory leaks.
// Without this, the event listeners keep references to the executor
// and prevent the iframe from being garbage collected.
if (this.snapPromiseErrorHandler) {
removeEventListener('unhandledrejection', this.snapPromiseErrorHandler);
this.snapPromiseErrorHandler = undefined;
}

if (this.snapErrorHandler) {
removeEventListener('error', this.snapErrorHandler);
this.snapErrorHandler = undefined;
}
}

// TODO: Either fix this lint violation or explain why it's necessary to
Expand Down