Codestin Search App

GSadee · 2017-01-09T12:41:36Z

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	yes
Related tickets
License	MIT

CoderMaggie · 2017-01-17T07:51:44Z


 ### Attribute / AttributeBundle

+* `AttributeValue::$localeCode` property was added to make it translatable. Now, every attribute value has a locale code to be properly displaying in different locales. All attribute values are migrated to new concept with migration `Version20170109143010`. Look at [this PR](https://github.com/Sylius/Sylius/pull/7219) if you have any problems with upgrade.


to be displayed properly in different locales; to the new concept;

CoderMaggie · 2017-01-17T07:54:14Z

+        When I switch to the "Polish (Poland)" locale
+        When I view product "T-shirt banana"
+        Then I should see the product attribute "T-shirt material" with value "Skórka banana"
+        Then I should also see the product attribute "T-shirt details" with value "Banana is very good material."


"Banana is a very good material."

Banana is a fruit, not a material :( 🍌

pjedrzejewski · 2017-01-17T10:37:30Z

        * {@inheritdoc}
        */
-       public function hasAttributeByCode($attributeCode)
+       public function hasAttributeByCodeAndLocale($attributeCode, $localeCode)


We could perhaps improve the DX here a bit and make the 2nd parameter optional. If not provided, the entity would use the currentLocale stored on it at the moment of call. WDYT?

NoResponseMate · 2017-01-17T10:41:10Z

+        $defaultLocale = $this->container->getParameter('locale');
+
+        $this->addSql('ALTER TABLE sylius_product_attribute_value ADD locale_code VARCHAR(255) NOT NULL');
+        $this->addSql('UPDATE sylius_product_attribute_value SET locale_code = "'.$defaultLocale.'"');


Why not just use SET DEFAULT in the ALTER clause instead of this?

That would add this default locale to the column definition in the DB. I'd prefer to avoid that.

pamil · 2017-01-17T09:37:40Z

+        $defaultLocale = $this->container->getParameter('locale');
+
+        $this->addSql('ALTER TABLE sylius_product_attribute_value ADD locale_code VARCHAR(255) NOT NULL');
+        $this->addSql('UPDATE sylius_product_attribute_value SET locale_code = "'.$defaultLocale.'"');


Are you sure it works? The first SQL query will probably fail if there are any records in the database.

Yes, I am sure :tested:

pamil · 2017-01-17T09:39:43Z

+        And the store has a product "T-shirt banana"
+        And this product has text attribute "T-shirt material" with value "Banana skin" in "English (United States)" locale
+        And this product has text attribute "T-shirt material" with value "Skórka banana" in "Polish (Poland)" locale
+        And this product has textarea attribute "T-shirt details" with value "Banana is a very good material." in "English (United States)" locale


Is it needed?

Yes, because I want to test if using a fallback locale when attribute has no value in current locale is working correctly ; )

pamil · 2017-01-17T09:41:23Z


    /**
     * @Given /^(this product) has ([^"]+) attribute "([^"]+)" with value "([^"]+)"$/
+     * @Given /^(this product) has ([^"]+) attribute "([^"]+)" with value "([^"]+)" in ("[^"]+" locale)$/


([^"]+) attribute -> (.+?) attribute

Why? What is the difference?

Matching every character except " does not make any sense here, let's match all the characters instead.

pamil · 2017-01-17T09:42:21Z

+     * @param string|null $code
+     *
+     * @return ProductAttributeInterface
+     */


getOrCreate -> provide?

pamil · 2017-01-17T09:44:36Z

-            sprintf('ProductAttribute "%s" should have value "%s" but it does not.', $attribute, $value)
+            $this->updateSimpleProductPage->getAttributeValue($attributeName, $language),
+            sprintf(
+                'Product attribute "%s" should have value "%s" in language "%s" but it does not.',


but it does not

pamil · 2017-01-17T09:46:35Z

+     * @param string[] $localeCodes
     *
-     * @return FormView
+     * @return array


FormView[]

…ext attributes in different locales

…attribute values to a product in different locales

…to a product

…ale on the product page

lchrusciel · 2017-01-18T08:12:17Z

-    {
-        $attribute = $this->createProductAttribute($productAttributeType, $productAttributeName);
-        $attributeValue = $this->createProductAttributeValue($value, $attribute);
+    public function thisProductHasAttributeWithValue(


Wouldn't it be worthy to extract ProductAttributes to separate context?

lchrusciel · 2017-01-18T08:14:15Z

+     * @return ProductAttributeInterface
+     */
+    private function provideProductAttribute($type, $name, $code = null)
+    {


$code = $code?:StringInflector::nameToCode($name);

lchrusciel · 2017-01-18T08:14:49Z

+        if (null !== $productAttribute) {
+            return $productAttribute;
+        }
+


I'm not sure about it. Shouldn't we create an attribute before first usage of it?

lchrusciel · 2017-01-18T08:18:41Z

    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $builder
+            ->add('localeCode')


Shouldn't it be

->add('localeCode', LocaleChoiceType::class, [ 'constraints' => [ new NotBlank(['groups' => ['sylius']]), ], ])

And then we will use a transformer:

$builder->get('localeCode')->addModelTransformer( new ReversedTransformer(new ResourceToIdentifierTransformer($this->localeRepository, 'code')) );

With this solution we will be sure, that locale exist in the repository

lchrusciel · 2017-01-18T08:19:50Z

+        );
+
+        foreach ($attributes as $attribute) {
+            foreach ($localeCodes as $localeCode) {


Can we extract this foreach at least to another private method?

Any idea? When I extract this to another method, this method will have to return array and then I will have to merge arrays.. I know that current solution isn't clear, but I have no simple idea how to do it clearer.

/** * @param FormEvent $event */ public function preSetData(FormEvent $event) { /** @var ProductInterface $product */ $product = $event->getData(); $localeCodes = $this->localeProvider->getDefinedLocalesCodes(); $defaultLocaleCode = $this->localeProvider->getDefaultLocaleCode(); $attributes = $product->getAttributes()->filter( function (ProductAttributeValueInterface $attribute) use ($defaultLocaleCode) { return $attribute->getLocaleCode() === $defaultLocaleCode; } ); foreach ($attributes as $attribute) { $this->resolveLocalizedAttributes($localeCodes, $product, $attribute); } } /** * @param array $localeCodes * @param ProductInterface $product * @param ProductAttributeInterface $productAttribute */ private function resolveLocalizedAttributes(array $localeCodes, ProductInterface $product, ProductAttributeInterface $productAttribute) { foreach ($localeCodes as $localeCode) { if (!$product->hasAttributeByCodeAndLocale($productAttribute->getCode(), $localeCode)) { $attributeValue = $this->createProductAttributeValue($productAttribute->getAttribute(), $localeCode); $product->addAttribute($attributeValue); } } }

or

/** * @param FormEvent $event */ public function preSetData(FormEvent $event) { /** @var ProductInterface $product */ $product = $event->getData(); $defaultLocaleCode = $this->localeProvider->getDefaultLocaleCode(); $attributes = $product->getAttributes()->filter( function (ProductAttributeValueInterface $attribute) use ($defaultLocaleCode) { return $attribute->getLocaleCode() === $defaultLocaleCode; } ); foreach ($attributes as $attribute) { $this->resolveLocalizedAttributes($product, $attribute); } } /** * @param ProductInterface $product * @param ProductAttributeInterface $productAttribute */ private function resolveLocalizedAttributes(ProductInterface $product, ProductAttributeInterface $productAttribute) { $localeCodes = $this->localeProvider->getDefinedLocalesCodes(); foreach ($localeCodes as $localeCode) { if (!$product->hasAttributeByCodeAndLocale($productAttribute->getCode(), $localeCode)) { $attributeValue = $this->createProductAttributeValue($productAttribute->getAttribute(), $localeCode); $product->addAttribute($attributeValue); } } }

Anyway, we should add Assert::isInstanceOf(ProductInterface) just after $product = $event->getData();

lchrusciel · 2017-01-18T08:25:17Z

-            if ($attribute->getAttribute()->getCode() === $attributeCode) {
+            if ($attribute->getAttribute()->getCode() === $attributeCode &&
+                $attribute->getLocaleCode() === $localeCode) {
                return true;


Missing blank line

Didn't notice that the if above has and... My bad. Anyway, the if above will fit one line. And also we have to decide for some convention with multiple conditions in on if statement. Here you have && at the end of first line, and a few lines below the || is at the beginning of a second one...

👍 for convention

lchrusciel · 2017-01-18T08:25:38Z

        foreach ($this->attributes as $attribute) {
-            if ($attributeCode === $attribute->getAttribute()->getCode()) {
+            if ($attribute->getAttribute()->getCode() === $attributeCode &&
+                $attribute->getLocaleCode() === $localeCode) {


Missing blank line

lchrusciel · 2017-01-18T08:25:58Z

-    public function getAttributeByCode($attributeCode)
+    public function getAttributeByCodeAndLocale($attributeCode, $localeCode = null)
    {
+        if (null === $localeCode) {


$localeCode = $localeCode:?$this->getTranslation()->getLocale();

lchrusciel · 2017-01-18T08:28:25Z

+
+        $attributeValueInDifferentLocale = $this->getAttributeByCodeAndLocale($attributeValue->getCode(), $localeCode);
+        if ('' === $attributeValueInDifferentLocale->getValue()
+            || null === $attributeValueInDifferentLocale->getValue()) {


empty($attributeValueInDifferentLocale->getValue()) will be equivalent to this if. And we will remove an or condition

empty('0') === true, so I guess it won't.

lchrusciel · 2017-01-18T08:28:26Z

+
+        $attributeValueInDifferentLocale = $this->getAttributeByCodeAndLocale($attributeValue->getCode(), $localeCode);
+        if ('' === $attributeValueInDifferentLocale->getValue()
+            || null === $attributeValueInDifferentLocale->getValue()) {


empty($attributeValueInDifferentLocale->getValue()) will be equivalent to this if. And we will remove an or condition

empty('0') === true, so I guess it won't.

pjedrzejewski · 2017-01-18T08:31:49Z

Nice work Grzesiu, thank you! Apply @lchrusciel's comments in a separate PR if you agree, please.

GSadee force-pushed the translatable-attribute-value branch from 5248da2 to 2a3884c Compare January 16, 2017 07:16

pjedrzejewski added New Feature labels Jan 16, 2017

GSadee force-pushed the translatable-attribute-value branch 2 times, most recently from b23149d to b2b764c Compare January 17, 2017 07:14

GSadee changed the title ~~[WIP][AttributeValue] Translatable attribute values~~ [AttributeValue][Product] Translatable attribute values Jan 17, 2017

CoderMaggie reviewed Jan 17, 2017

View reviewed changes

GSadee force-pushed the translatable-attribute-value branch from bd4155b to ec752f3 Compare January 17, 2017 09:21

pjedrzejewski reviewed Jan 17, 2017

View reviewed changes

NoResponseMate reviewed Jan 17, 2017

View reviewed changes

pamil reviewed Jan 17, 2017

View reviewed changes

GSadee added 9 commits January 17, 2017 15:58

[Behat][ProductAttributeValue] Add scenarios for adding and viewing t…

43e1ae7

…ext attributes in different locales

[Behat][Admin][ProductAttributeValue] Implement scenarios for adding …

5287919

…attribute values to a product in different locales

[AttributeValue] Add locale code parameter to attribute value entity

5d29860

[AttributeValue] Add migration file

fa48b59

[Admin][ProductAttributeValue] Add attribute values with locale code …

55557c1

…to a product

[Documentation][AttributeValue] Update attribute docs and upgrade file

dcae778

[Fixture][Product] Fix product example factory

81c9c81

[Shop][ProductAttributeValue] Display attribute values by current loc…

b4419d9

…ale on the product page

[ProductAttributeValue] Fix removing attribute values from product

bff14ad

GSadee force-pushed the translatable-attribute-value branch from ec752f3 to dea6b21 Compare January 17, 2017 14:58

Fixes after PR review

111f9ce

GSadee force-pushed the translatable-attribute-value branch from dea6b21 to 111f9ce Compare January 18, 2017 07:34

lchrusciel suggested changes Jan 18, 2017

View reviewed changes

pjedrzejewski merged commit 5008336 into Sylius:master Jan 18, 2017

GSadee mentioned this pull request Jan 18, 2017

[ProductAttribute] Minor fixes associated with products and attributes #7281

Merged

michalmarcinkowski mentioned this pull request Jan 19, 2017

[WIP][AttributeBundle] Attribute value with translations #4512

Closed

GSadee deleted the translatable-attribute-value branch September 22, 2017 08:27


		### Attribute / AttributeBundle

		* `AttributeValue::$localeCode` property was added to make it translatable. Now, every attribute value has a locale code to be properly displaying in different locales. All attribute values are migrated to new concept with migration `Version20170109143010`. Look at [this PR](https://github.com/Sylius/Sylius/pull/7219) if you have any problems with upgrade.

Uh oh!

Conversation

GSadee commented Jan 9, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pamil Jan 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pjedrzejewski commented Jan 18, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

pamil Jan 18, 2017 •

edited

Loading