-
Notifications
You must be signed in to change notification settings - Fork 1.3k
changed msgpack to use ByteStream type annotations #6085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
build-doc is failing for |
I thought i had released circuitpython_typing 1.1.0, but apparently not. I just released it, confirmed it's in pypi.org, and am rerunning the PR jobs. |
I think we can remove @jepler do you think that would work for the stubs generation? I will try this in the morning; it's too late now. |
adafruit/Adafruit_CircuitPython_Typing#6 has some required changes that should then enable further changes here to finish this PR. |
The failing CI checks are all CI glitches. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is OK for now. I updated https://github.com/adafruit/Adafruit_CircuitPython_Typing, and made various build changes and other changes, as you see.
Thanks for initiating this and working with me on this!
And I thought this was going to be an easy one! Thanks so much for seeing this through; I've learned a lot following the various changes you've had to make. |
The IO parameters in msgpack.pack and msgpack.unpack are now named
stream
and annotated ascircuitpython_typing.ByteStream
. Fixes issue #6050.