Thanks to visit codestin.com
Credit goes to github.com

Skip to content

changed msgpack to use ByteStream type annotations #6085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 1, 2022

Conversation

rimwolf-redux
Copy link

The IO parameters in msgpack.pack and msgpack.unpack are now named stream and annotated as circuitpython_typing.ByteStream. Fixes issue #6050.

@rimwolf-redux
Copy link
Author

build-doc is failing for msgpack/__init__.pyi, apparently because shared-bindings/circuitpython_typing/__init__.pyi does not have the new ByteStream definition in it. How do I correct this?

@tannewt tannewt requested a review from dhalbert February 24, 2022 18:14
@dhalbert
Copy link
Collaborator

build-doc is failing for msgpack/__init__.pyi, apparently because shared-bindings/circuitpython_typing/__init__.pyi does not have the new ByteStream definition in it. How do I correct this?

I thought i had released circuitpython_typing 1.1.0, but apparently not. I just released it, confirmed it's in pypi.org, and am rerunning the PR jobs.

@dhalbert
Copy link
Collaborator

dhalbert commented Feb 25, 2022

I think we can remove shared-bindings/circuitpython_typing and instead make it part of requirements-dev.txt (EDIT) and requirements-doc.txt. I thought at first it was a reference to a submodule, but it's just a copy of what was in adafruit-blinka and is now in adafruit-circuitpython-typing.

@jepler do you think that would work for the stubs generation?

I will try this in the morning; it's too late now.

@dhalbert
Copy link
Collaborator

adafruit/Adafruit_CircuitPython_Typing#6 has some required changes that should then enable further changes here to finish this PR.

@dhalbert
Copy link
Collaborator

dhalbert commented Mar 1, 2022

The failing CI checks are all CI glitches.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is OK for now. I updated https://github.com/adafruit/Adafruit_CircuitPython_Typing, and made various build changes and other changes, as you see.

Thanks for initiating this and working with me on this!

@dhalbert dhalbert merged commit 548d6be into adafruit:main Mar 1, 2022
@rimwolf-redux rimwolf-redux deleted the msgpack branch March 1, 2022 15:31
@rimwolf-redux
Copy link
Author

And I thought this was going to be an easy one! Thanks so much for seeing this through; I've learned a lot following the various changes you've had to make.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants