-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Merge branch 'develop' into breaking #13459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add simplification rules for `mod(mul(X, Y), A)` & `mod(add(X, Y), A)`
Co-authored-by: Damian Wechman <[email protected]>
Fix validation error causing ICE with isoltest --test
Currently the documentation suggests that a decimal literal can omit the fractional part [1]: > Decimal fractional literals are formed by a `.` with at least one > number on one side. Examples include `1.`, `.1` and `1.3`. However, commit ac68710 (May 30, 2018) disallowed trailing dots that are not followed by a number [2]. Using decimal literals of the form `1.` will actually result in a `ParserError` and so the docs should no longer recommend this form. [1] https://docs.soliditylang.org/en/v0.8.15/types.html#rational-and-integer-literals [2] ac68710
Add all path locations to the IdentifierPath ASTNode
Fix ICE caused by an immutable struct with mapping
docs: Disallow decimal literals with trailing dots
formatNumberReadable now prints signed integers as well
Add all path declarations in IdentifierPath annotation
…operations Check overflow after add sub operations
By using the last known working commit. Only a temporary measure.
Fix external test ens
Add location for member in MemberAccess ASTNode
Enabled external tests to use relative paths to solc binary.
Update naming of Mainnet
Add whiskers test for weird case
docs: add notice for uint conversion before 0.8.0 docs: edit sentence structure + remove 'result in `address payable`' docs: add keyword 'explicitly' to be more specific for `address payable` docs: edit notice uint to address conversion change since 0.8.0 Co-authored-by: Kamil Śliwak <[email protected]>
docs: add notice about `address` conversion prior to 0.8.0
Fix warning about DOWNLOAD_EXTRACT_TIMESTAMP on CMake 3.24
Clarify effect of memory unsafe assembly
…tion [Tiny] Fix undefined order of evaluation
…_errors added yul exception to compiler error types
Grammer fix
…ication-ast Reduce duplication in AST helpers for finding try/catch clauses
Update issue selector, and remove auto labeling
Add std:: qualifier to move() calls
Author: NoFaceDev <[email protected]> Date: Sat Jul 23 18:22:06 2022 +0400
…lder Placeholder elaboration in function-modifiers.rst
Update SMT tests with z3 4.11.0
Explained Checks-Effects-Interactions and added info on Checks-Effects-Events-Interactions
Update z3 to 4.11.0 in the docker files
Explained Checks-Effects-Interactions
Add detail about limitation in voting contract example
Manual Resolved Conflicts: Changelog.md * Updated changelog test/externalTests/ens.sh * Merged fixes for upstream from both develop and breaking test/libsolidity/semanticTests/inlineAssembly/external_identifier_access_shadowing.sol * Removed in #11735 (breaking) test/libsolidity/semanticTests/inlineAssembly/function_name_clash.sol * Removed in #12209 (breaking) test/libsolidity/semanticTests/storage/mappings_array2d_pop_delete.sol * Removed in #11843 (breaking) test/libsolidity/semanticTests/storage/mappings_array_pop_delete.sol * Removed in #11843 (breaking) test/libsolidity/syntaxTests/inlineAssembly/basefee_berlin_function.sol * Used version of file from #11842 (breaking)
ekpyron
approved these changes
Sep 1, 2022
Collaborator
ekpyron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that the branch is the result of current develop merged into breaking plus fixing the mentioned conflicts, so I'm approving and merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual Resolved Conflicts:
breaking#12209 (breaking)The files listed above are the ones I touched manually and fixed.