chore: extract Expecter into its own package - #25806
Merged
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
spikecurtis
force-pushed
the
spike/internal-1400-expecter
branch
from
May 28, 2026 19:36
8bb24bb to
9729348
Compare
spikecurtis
marked this pull request as ready for review
May 28, 2026 19:43
sreya
approved these changes
May 28, 2026
Contributor
Author
Merge activity
|
f0ssel
added a commit
that referenced
this pull request
Jun 17, 2026
… test The backport of #26418 added cli/server_fix_oidc_links_test.go, which imports github.com/coder/coder/v2/testutil/expecter. That package was extracted on main in #25806 and does not exist on release/2.34, so the backported test failed to compile. The compile failure broke the fmt, gen, lint, and all test-go-pg jobs. Backport the self-contained, test-only expecter package verbatim from main so the test compiles and CI passes. No production code is affected.
f0ssel
pushed a commit
that referenced
this pull request
Jun 17, 2026
Backport of #26418 to release/2.33. Resolved a conflict in the generated coderd/database/queries.sql.go by regenerating the database code (sqlc v1.30.0) from the cherry-picked queries. Only the new query code is added; nothing is removed. Also backports the test-only testutil/expecter package (extracted on main in #25806). The new cli/server_fix_oidc_links_test.go imports it, and it did not exist on this release branch, so without it the fmt, gen, lint, and test-go jobs fail to compile. (cherry picked from commit 1d03e63)
f0ssel
pushed a commit
that referenced
this pull request
Jun 17, 2026
Backport of #26418 to release/2.32. Resolved a conflict in the generated coderd/database/queries.sql.go by regenerating the database code (sqlc v1.30.0) from the cherry-picked queries. Only the new query code is added; nothing is removed. Also backports the test-only testutil/expecter package (extracted on main in #25806). The new cli/server_fix_oidc_links_test.go imports it, and it did not exist on this release branch, so without it the fmt, gen, lint, and test-go jobs fail to compile. (cherry picked from commit 1d03e63)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to coder/internal#1400
Extracts the code that matches command output from the code that sets up a PTY, so it can be used independently.
Subsequent PRs will actually refactor the tests to use this directly over an inmemory pipe.<!--
If you have used AI to produce some or all of this PR, please ensure you have read our AI Contribution guidelines before submitting.
-->