Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Initialize translations for Traditional Chinese#10505

Merged
tiangolo merged 9 commits into
fastapi:masterfrom
hsuanchi:feature/init-zh-hant
Jan 17, 2024
Merged

🌐 Initialize translations for Traditional Chinese#10505
tiangolo merged 9 commits into
fastapi:masterfrom
hsuanchi:feature/init-zh-hant

Conversation

@hsuanchi

Copy link
Copy Markdown
Contributor

No description provided.

@tiangolo

Copy link
Copy Markdown
Member

📝 Docs preview for commit 3a0d383 at: https://15e5624d.fastapitiangolo.pages.dev

@hsuanchi

Copy link
Copy Markdown
Contributor Author

Hello, @tiangolo

We want to create the language for zh-hant (Mandarin), but the language will be limited to 2 letters. What are your recommended approaches for handling languages that have more than two letters?

@tiangolo

Copy link
Copy Markdown
Member

Thanks @hsuanchi! Up to now, I've avoided language localizations as there aren't yet enough translations of the first language, for example, for pt-PT.

The first question would be, how different is it from zh? Would zh not be understandable by people who speak zh-hant?

The second question is, are there others (at least other two, in total with you at least three) that are willing to help with those translations to zh-hant? Because I need to get 2 approvals to merge, and if there are now two variants of zh, it's probably gonna be even more difficult to get approvals for both.

There are currently 63 PRs for zh awaiting for reviewers: https://github.com/tiangolo/fastapi/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+label%3Alang-zh

Let me know what you think!

@hsuanchi

Copy link
Copy Markdown
Contributor Author

Hello @tiangolo ,

Thank you for your swift reply. To address your first question, zh is generally considered to be Simplified Chinese (zh-hans), while zh-hant refers to Traditional Chinese. Although the two variants share similarities, they differ significantly in terms of characters and some terminology. People from regions such as Taiwan, Hong Kong, and Macau typically use zh-hant and may find zh less intuitive to read.

As for your second question, we have a robust team of over 10 developers who use FastAPI on a daily basis. Some of our members have also contributed to the Traditional Chinese translation of Python documentation (python-docs-zh-tw). We're confident that we'll be able to efficiently review and contribute to the zh-hant localization for FastAPI.

Thank you once again, and looking forward to your reply.

@SonnyYou

Copy link
Copy Markdown

Hi @tiangolo ,

I would like to kindly inform you that I am part of the same team as @hsuanchi , and we are wholeheartedly dedicated to supporting the translation of the content into zh-hant. Let's collaborate to make it even more exceptional!

@pths411027

Copy link
Copy Markdown

I'm an avid user of FastAPI and would be thrilled to review @hsuanchi 's translation. Additionally, I'd be honored to contribute to the translation efforts for FastAPI, aiming to make it even more accessible and developer-friendly for the Chinese-speaking community."

@winonachiang

Copy link
Copy Markdown

Fastapi basically consists of my day-to-day life and I'm confident that I can dedicate myself to contributing to the translations to zh-hant as zh-hant is my first language.
It'd be my pleasure to review @hsuanchi's translation and make the development of Fastapi more friendly to the Chinese-speaking community.

@yyl14

yyl14 commented Oct 31, 2023

Copy link
Copy Markdown

Hello @tiangolo,

I am in the same team as @hsuanchi. I am very eager to assist in the zh-hant localization to make FastAPI more accessible for the Traditional Chinese community. Looking forward to hearing from you!

@jsbao0428

Copy link
Copy Markdown

I am a user of FastAPI from Taiwan, and I am very eager to promote FastAPI among Traditional Chinese-speaking users. This way, more users can read the documentation in their native language, which would lower the barrier to entry.

@DavidChen-99

Copy link
Copy Markdown

Hi @tiangolo,

If I could contribute to the translation efforts of FastAPI, making community documents more clear and intuitive for developers using the zh-hant language, I find it highly meaningful.

@enzoapu

enzoapu commented Oct 31, 2023

Copy link
Copy Markdown

Dear @tiangolo,

I am extremely excited and looking forward to seeing FastAPI in Traditional Chinese. The purpose of this initiative is to assist developers in Taiwan in using and understanding FastAPI more easily. We are committed to continuing to support and contribute to FastAPI.

@isaackwok

Copy link
Copy Markdown

As a software engineer from Hong Kong and Taiwan, I can tell that FastAPI is important for Traditional Chinese software community, we have a large community here working on Python with FastAPI in Taiwan.

Can't wait to see more Traditional Chinese resources and contributions so FastAPI can be widely promoted.

@mattwang44

mattwang44 commented Nov 1, 2023

Copy link
Copy Markdown
Contributor

Traditional Chinese (zh_hant) and Simplified Chinese (zh_hans) are different writing systems of Chinese. Both are categorized under the zh code in ISO 639-1, and using this two-character code alone is insufficient to differentiate between the two. (Similarly, I'd say the term "Mandarin" in the PR title is not accurate enough.) They have different histories and cultures. Both are official in their regions and are widely used with rich literature and media. Their users generally have a strong preference for one writing system over the other based on their background. Though Mandarin is mostly spoken in both regions that use Traditional and Simplified Chinese characters, regional variations exist between both systems.

In the field of software technical document translation, many prominent resources offer both Traditional and Simplified Chinese versions simultaneously. Examples include Python docs, MDN docs, Microsoft docs, AWS docs, React docs, Angular docs, and more. Although the momentum for zh_hant translation might not be as extensive as zh_hans, it's undeniable that Traditional Chinese is a legitimate and important language version for software documents.

As a Python backend engineer and a member of the Python document translation community, I'm more than willing to help with translating the FastAPI doc or reviewing for the translation PRs. (Actually, I tried once before lol).

@kylec-88

kylec-88 commented Nov 1, 2023

Copy link
Copy Markdown

Hi @tiangolo ,

I am a software engineer who works with @hsuanchi. I understand your concern about the use of Traditional Chinese (zh-Hant) for translations. Here's a more detailed explanation of why it's essential to consider using zh-Hant for FastAPI translations:

zh-Hant, which represents Traditional Chinese, is crucial for ensuring the accessibility and readability of FastAPI content for a specific audience. Traditional Chinese characters are primarily used in regions like Taiwan, Hong Kong, and among overseas Chinese communities. If your project has users in these areas or if your goal is to be inclusive of these regions, providing translations in zh-Hant is a necessity.

Here's why zh-Hant matters:

  1. Cultural Sensitivity: Using Traditional Chinese characters is a matter of cultural sensitivity and respect. Some users in regions where Traditional Chinese is the norm may find it more comfortable and culturally appropriate when content is presented in zh-Hant.

  2. Audience Reach: Including zh-Hant extends your reach and ensures that FastAPI is accessible to a broader audience. It allows you to engage users who may prefer or are more familiar with Traditional Chinese characters.

  3. User Experience: Users tend to have a better user experience when content is in their preferred language variant. It enhances user satisfaction and encourages adoption.

In summary, providing translations in zh-Hant alongside zh is a strategic move to make FastAPI more inclusive, culturally sensitive, and user-friendly for a wider audience. It demonstrates your commitment to engaging with users from different regions and respecting their language and cultural preferences.

We hope you consider the importance of using zh-Hant as part of the translation efforts for FastAPI. Thank you for your understanding and support.

@hsuanchi

Copy link
Copy Markdown
Contributor Author

Hi @tiangolo, are there any updates? Are we ready to begin work on the Traditional Chinese version?

@tiangolo

Copy link
Copy Markdown
Member

📝 Docs preview for commit 84b953b at: https://3397a9ff.fastapitiangolo.pages.dev

@mattwang44 mattwang44 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the initial review of the translation part.

Comment thread docs/zh-hant/docs/index.md Outdated
Comment thread docs/zh-hant/docs/index.md Outdated
Comment thread docs/zh-hant/docs/index.md Outdated
Comment thread docs/zh-hant/docs/index.md Outdated
Comment thread docs/zh-hant/docs/index.md Outdated
Comment thread docs/zh-hant/docs/index.md Outdated
Comment thread docs/zh-hant/docs/index.md Outdated
Comment thread docs/zh-hant/docs/index.md Outdated
Comment thread docs/zh-hant/docs/index.md Outdated
Comment thread docs/zh-hant/docs/index.md Outdated
@tiangolo

Copy link
Copy Markdown
Member

📝 Docs preview for commit 953ad14 at: https://b5531961.fastapitiangolo.pages.dev

@hsuanchi

Copy link
Copy Markdown
Contributor Author

Here is the initial review of the translation part.

Thanks for helping with the review 🫡🫡🫡, all amendments are now complete.

@mattwang44 mattwang44 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translation review part 2

Comment thread docs/zh-hant/docs/index.md Outdated
Comment thread docs/zh-hant/docs/index.md Outdated
Comment thread docs/zh-hant/docs/index.md Outdated
Comment thread docs/zh-hant/docs/index.md Outdated
Comment thread docs/zh-hant/docs/index.md Outdated
Comment thread docs/zh-hant/docs/index.md Outdated
Comment thread docs/zh-hant/docs/index.md Outdated
Comment thread docs/zh-hant/docs/index.md Outdated
@tiangolo

Copy link
Copy Markdown
Member

📝 Docs preview for commit 73e95a7 at: https://d5229374.fastapitiangolo.pages.dev

@SonnyYou SonnyYou left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some suggestions

Comment thread docs/zh-hant/docs/index.md Outdated
Comment thread docs/zh-hant/docs/index.md Outdated
Comment thread docs/zh-hant/docs/index.md Outdated
Comment thread docs/zh-hant/docs/index.md Outdated
Comment thread docs/zh-hant/docs/index.md
Comment thread docs/zh-hant/docs/index.md Outdated
Comment thread docs/zh-hant/docs/index.md Outdated
Comment thread docs/zh-hant/docs/index.md Outdated
Comment thread docs/zh-hant/docs/index.md Outdated
Comment thread docs/zh-hant/docs/index.md Outdated
Comment thread docs/zh-hant/docs/index.md Outdated
Comment thread docs/zh-hant/docs/index.md Outdated
Comment thread docs/zh-hant/docs/index.md Outdated
@tiangolo

Copy link
Copy Markdown
Member

📝 Docs preview for commit 66cba69 at: https://c9489c35.fastapitiangolo.pages.dev

@tiangolo tiangolo changed the title initialize new language for mandarin 🌐 Initialize translations for Traditional Chinese Jan 12, 2024
@tiangolo tiangolo added awaiting-review lang-zh-hant Traditional Chinese translations lang-all Translations labels Jan 12, 2024
@tiangolo

Copy link
Copy Markdown
Member

Amazing! If you all work together you could have all the FastAPI docs translated to Traditional Chinese in no time! 🎉

I updated the script to handle docs to take this into account, and I added this discussion: #10949

When there's a new PR for Traditional Chinese and I add the label, it will be automatically posted there. You could subscribe to that discussion to get notified when there's a new PR to review. 🤓

Thank you all for your help!

Once this PR is ready and has two approving reviews I'll merge it. The same with the next future PRs. 🚀

@tiangolo

Copy link
Copy Markdown
Member

📝 Docs preview for commit efc2197 at: https://be6f65a0.fastapitiangolo.pages.dev

@mattwang44 mattwang44 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiangolo tiangolo requested a review from SonnyYou January 15, 2024 16:20

@SonnyYou SonnyYou left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiangolo tiangolo merged commit df09e0a into fastapi:master Jan 17, 2024
@tiangolo

Copy link
Copy Markdown
Member

Awesome, thank you @hsuanchi ! 🍰

And thanks for the reviews @SonnyYou, @mattwang44 ☕ 🍪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all Translations lang-zh-hant Traditional Chinese translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.