🌐 Fix incorrect pymdown-extensions option used in CJK characters documentation#12161
Closed
andychucs wants to merge 3 commits into
Closed
🌐 Fix incorrect pymdown-extensions option used in CJK characters documentation#12161andychucs wants to merge 3 commits into
pymdown-extensions option used in CJK characters documentation#12161andychucs wants to merge 3 commits into
Conversation
Contributor
|
📝 Docs preview for commit 9c7d68c at: https://42bebad1.fastapitiangolo.pages.dev |
pymdown-extensions option used in CJK characters documentation
svlandeg
approved these changes
Sep 9, 2024
svlandeg
left a comment
Member
There was a problem hiding this comment.
Thanks for identifying and fixing this issue, @andychucs! This seems like the best way to approach this issue to me.
hard-coders
approved these changes
Sep 12, 2024
|
hi @svlandeg when will it merge? |
Member
|
Hi @sodaMelon, We've currently got this in our internal queue for Tiangolo to perform a final review. Thanks for your patience! |
Contributor
|
📝 Docs preview for commit f75d55a at: https://185c3339.fastapitiangolo.pages.dev |
hard-coders
approved these changes
Oct 16, 2024
sodaMelon
approved these changes
Oct 16, 2024
Member
|
Hi @andychucs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The smart_enable option makes the docs not supported to be displayed when using bold and italics which are in Chinese, Japanese, and Korean.
We basically don’t use whitespace between words in Chinese and Japanese.
It causes a lot of problems with Markdown convert. So it should not be set as
alljust keep default is correct for now.Check the difference here with search '**' in web documents.
Chinese:
after: https://42bebad1.fastapitiangolo.pages.dev/zh/#sponsors
before: https://fastapi.tiangolo.com/zh/#sponsors
Japanese:
after: https://42bebad1.fastapitiangolo.pages.dev/ja/#sponsors
before: https://fastapi.tiangolo.com/ja/#sponsors
Korean case like this one: #12142