-
Notifications
You must be signed in to change notification settings - Fork 28.8k
Make Podfiles use symlinks to local pods #14748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cc @mit-mit who might like to test this in light of #9502 (comment) |
Awesome, cool! I wonder if we can put these symlinks in the /Pods directory to keep them bundled. This way, it 'self documents' too when the users are exploring the directories. Wonder if |
cac668a
to
ad176bc
Compare
Yes, I'll give it a try at least. One may worry that we'll be making assumptions about the detailed workings of |
Awaits merge and roll of flutter/engine#4691 which updates the LICENSE placement in Flutter.podspec. |
@xster , @jakobr-google PTAL |
@@ -40,3 +40,4 @@ Icon? | |||
/ServiceDefinitions.json | |||
|
|||
Pods/ | |||
Symlinks/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need this anymore, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #9502