Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make Podfiles use symlinks to local pods #14748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 19, 2018

Conversation

mravn-google
Copy link
Contributor

Fixes #9502

Copy link
Contributor

@jakobr-google jakobr-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mravn-google
Copy link
Contributor Author

/cc @mit-mit who might like to test this in light of #9502 (comment)

@xster
Copy link
Member

xster commented Feb 16, 2018

Awesome, cool!
LGTM

I wonder if we can put these symlinks in the /Pods directory to keep them bundled. This way, it 'self documents' too when the users are exploring the directories. Wonder if pod deintegrate would clean up everything nicely for us if it were inside /Pods.

@mravn-google
Copy link
Contributor Author

I wonder if we can put these symlinks in the /Pods directory to keep them bundled. This way, it 'self documents' too when the users are exploring the directories. Wonder if pod deintegrate would clean up everything nicely for us if it were inside /Pods.

Yes, I'll give it a try at least. One may worry that we'll be making assumptions about the detailed workings of pod install. Changes to the timing or the extend to which it clears the Pods/ folder could affect correctness down the road.

@mravn-google
Copy link
Contributor Author

mravn-google commented Feb 19, 2018

  • Moved Symlinks folder to Pods/.symlinks
  • Now copying Flutter framework's LICENSE file to sibling of Flutter framework podspecs in cache. This avoids issue with resolving ../../../../../ relative to symlink.

Awaits merge and roll of flutter/engine#4691 which updates the LICENSE placement in Flutter.podspec.

@mravn-google
Copy link
Contributor Author

mravn-google commented Feb 19, 2018

@xster , @jakobr-google PTAL

@@ -40,3 +40,4 @@ Icon?
/ServiceDefinitions.json

Pods/
Symlinks/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need this anymore, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

Copy link
Contributor

@jakobr-google jakobr-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A Flutter app's Podfile.lock should be versionable
4 participants