Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Convert AppPluginLoaderPlugin to Kotlin, and add NativePluginLoaderReflectionBridge to expose it in Kotlin #166027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Apr 2, 2025
Merged

Convert AppPluginLoaderPlugin to Kotlin, and add NativePluginLoaderReflectionBridge to expose it in Kotlin #166027

merged 16 commits into from
Apr 2, 2025

Conversation

gmackall
Copy link
Member

@gmackall gmackall commented Mar 26, 2025 •
edited
Loading

Graph stolen from Barteks comment documenting the existing (pre pr) state:

graph TD;
  flutter.groovy -- import --> native_plugin_loader.groovy;
  flutter.groovy -- import --> BaseApplicationNameHandler.kt;
  module_plugin_loader.groovy -- "ext" --> native_plugin_loader.groovy;
  app_plugin_loader.groovy  -- import --> native_plugin_loader.groovy;
  include_flutter.groovy -- "apply from: " --> module_plugin_loader.groovy;
Loading
  1. Converts the app_plugin_loader.groovy to kotlin source.
  2. Converts the module_plugin_loader.groovy to kotlin script. This can't be changed to kotlin source yet, as we will need to instruct users to make a change to their host app-level gradle files before we can turn down script application of this separate gradle plugin. This is a breaking change, and will need a quarter at least of notice.
  3. Unfortunately, the main Flutter Gradle plugin depends on being able to call methods of the native_plugin_loader, which we could do in groovy via wacky dynamic behavior, calling across the compiled plugin->script plugin barrier. We can't do this in Kotlin source, and we also can't fully convert native_plugin_loader to kotlin source yet because of (2), so I've added a NativePluginLoaderReflectionBridge that allows us to access the methods in the native_plugin_loader.gradle.kts from the Kotlin source files, calling across the compiled plugin->script plugin barrier as we were before.

The plan here is

  1. to follow up by adding a converted native_plugin_loader.gradle.kts in Kotlin source, and migrating all paths but the host-app using a module-as-source to use the converted approach (but not deleting the old way)
  2. maintaining both ways for a release or two, with the script application printing a message notifying users to update to the non-script based application of the module_plugin_loader.
  3. Then we can delete the script based apply, and also the reflection bridge.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Mar 26, 2025
@gmackall gmackall requested a review from a team March 27, 2025 19:58
@gmackall gmackall marked this pull request as ready for review March 27, 2025 19:58
@flutter-dashboard

This comment was marked as resolved.

Sign in to view
@gmackall gmackall requested a review from bartekpacia March 27, 2025 20:02
@stuartmorgan-g
Copy link
Contributor

test-exempt: code refactor with no semantic change

@gmackall gmackall mentioned this pull request Mar 28, 2025
Merged
9 tasks
@gmackall gmackall requested review from ash2moon and a team March 28, 2025 16:49
reidbaker
reidbaker reviewed Apr 2, 2025
View reviewed changes
Gray Mackall added 2 commits April 2, 2025 10:07
add docs
867ec59
Merge remote-tracking branch 'refs/remotes/origin/minimal_plugin_load…
f445c40 
…er_conversion' into minimal_plugin_loader_conversion
@gmackall gmackall requested a review from reidbaker April 2, 2025 17:10
reidbaker
reidbaker approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@reidbaker reidbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add documentation for where the integration test live.
Approved

@auto-submit auto-submit bot added this pull request to the merge queue Apr 2, 2025
@matanlurey matanlurey removed this pull request from the merge queue due to a manual request Apr 2, 2025
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2025
@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2025
@gmackall
Copy link
Member Author

gmackall commented Apr 2, 2025

Re adding to mq as problem is resolved

@auto-submit auto-submit bot added this pull request to the merge queue Apr 2, 2025
Merged via the queue into flutter:master with commit e971379 Apr 2, 2025
138 of 139 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
e971379 Convert AppPluginLoaderPlugin to Kotlin, and add `NativePlu…
91d7646 
…ginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
e971379 Convert AppPluginLoaderPlugin to Kotlin, and add `NativePlu…
dd6897b 
…ginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
e971379 Convert AppPluginLoaderPlugin to Kotlin, and add `NativePlu…
6e53559 
…ginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
e971379 Convert AppPluginLoaderPlugin to Kotlin, and add `NativePlu…
fd6b636 
…ginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
e971379 Convert AppPluginLoaderPlugin to Kotlin, and add `NativePlu…
625be5f 
…ginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
e971379 Convert AppPluginLoaderPlugin to Kotlin, and add `NativePlu…
8814df1 
…ginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
e971379 Convert AppPluginLoaderPlugin to Kotlin, and add `NativePlu…
25bc762 
…ginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Merged
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
Roll Flutter from a0b1b3253416 to 02f13c37841f (37 revisions) (#8996)
267ac7b 
Roll Flutter from a0b1b3253416 to 02f13c37841f (37 revisions)

flutter/flutter@a0b1b32...02f13c3

2025-04-03 [email protected] Roll Packages from 07496eb to 4a36dc6 (3 revisions) (flutter/flutter#166542)
2025-04-03 [email protected] Roll Skia from b67e53719e78 to 5f65df75febd (2 revisions) (flutter/flutter#166538)
2025-04-03 [email protected] Update docs to debug the Android embedder (flutter/flutter#166170)
2025-04-03 [email protected] Roll Dart SDK from 72562ca93bb5 to d174ec16c3ea (1 revision) (flutter/flutter#166525)
2025-04-03 [email protected] [macOS] Implement merged UI and platform thread (flutter/flutter#162883)
2025-04-03 [email protected] Roll Skia from f91412f5d89d to b67e53719e78 (1 revision) (flutter/flutter#166527)
2025-04-03 [email protected] Roll Packages from 125c117 to 07496eb (31 revisions) (flutter/flutter#166457)
2025-04-03 [email protected] Roll Skia from 2be12bc2668b to f91412f5d89d (2 revisions) (flutter/flutter#166517)
2025-04-03 [email protected] Roll Dart SDK from 2a1a13cc3a91 to 72562ca93bb5 (2 revisions) (flutter/flutter#166514)
2025-04-03 [email protected] [native_assets] Roll dependencies (flutter/flutter#166282)
2025-04-03 [email protected] Fix read only TextField focus traversal on macOS (flutter/flutter#166056)
2025-04-03 [email protected] Roll Skia from c106d7831592 to 2be12bc2668b (1 revision) (flutter/flutter#166509)
2025-04-03 [email protected] Roll Fuchsia Linux SDK from v7PGvypiiWLO8PbsZ... to vYisSsIgqw0mqFRVJ... (flutter/flutter#166508)
2025-04-03 [email protected] Roll Dart SDK from b8b4076b1237 to 2a1a13cc3a91 (1 revision) (flutter/flutter#166504)
2025-04-03 [email protected] Roll Skia from 75a0ec473181 to c106d7831592 (1 revision) (flutter/flutter#166499)
2025-04-03 [email protected] Migrate to Theme.brightnessOf method (flutter/flutter#163950)
2025-04-03 [email protected] Fix: Range slider show overlay for both thumbs on hovering one (flutter/flutter#165393)
2025-04-03 [email protected] Deprecate ExpansionTileController (flutter/flutter#166368)
2025-04-03 [email protected] Add styling parameters in `PopupMenuDivider` (flutter/flutter#164790)
2025-04-03 [email protected] Fix ISSUE_TEMPLATE Ordering: `10 < 9`, but `10 > 09` (flutter/flutter#166455)
2025-04-03 [email protected] Skip flaking scheduler test (flutter/flutter#166471)
2025-04-02 [email protected] Roll pub packages (flutter/flutter#166043)
2025-04-02 [email protected] [a11y] add SemanticsValidationResult (flutter/flutter#165935)
2025-04-02 [email protected] Remove unnecessary cache busting mechanism in hot restart (flutter/flutter#166295)
2025-04-02 [email protected] Roll Skia from 52cbb917fffd to 75a0ec473181 (21 revisions) (flutter/flutter#166484)
2025-04-02 [email protected] Started pixel aligning hairlines (flutter/flutter#166351)
2025-04-02 [email protected] Adds semantics role and adjust semantics for navigation bar (flutter/flutter#162467)
2025-04-02 [email protected] Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454)
2025-04-02 [email protected] [dart:ui] Add `Path.addRSuperellipse` (flutter/flutter#166045)
2025-04-02 [email protected] Fix: Hero animation for page transition (flutter/flutter#164469)
2025-04-02 [email protected] Fix: DelegateTransition for cupertino sheet route (flutter/flutter#164675)
2025-04-02 [email protected] Roll Fuchsia Test Scripts from AEdsljKmUiPk92Wvv... to FZdRtNwH7jmADecj6... (flutter/flutter#166383)
2025-04-02 [email protected] [Impeller] cache for text shadows. (flutter/flutter#166228)
2025-04-02 [email protected] Convert `AppPluginLoaderPlugin` to Kotlin, and add `NativePluginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027)
2025-04-02 [email protected] Roll Dart SDK from 4e1f02bc704f to b8b4076b1237 (7 revisions) (flutter/flutter#166474)
2025-04-02 [email protected] Update Roadmap (flutter/flutter#166332)
2025-04-02 [email protected] Update `CODEOWNERS` (flutter/flutter#166444)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
@gmackall gmackall mentioned this pull request Apr 15, 2025
Open
15 tasks
@Piinks Piinks mentioned this pull request Apr 18, 2025
Open
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Roll Flutter from a0b1b3253416 to 02f13c37841f (37 revisions) (#8996)
57f42e1 
Roll Flutter from a0b1b3253416 to 02f13c37841f (37 revisions)

flutter/flutter@a0b1b32...02f13c3

2025-04-03 [email protected] Roll Packages from d10d5af to 95f8e65 (3 revisions) (flutter/flutter#166542)
2025-04-03 [email protected] Roll Skia from b67e53719e78 to 5f65df75febd (2 revisions) (flutter/flutter#166538)
2025-04-03 [email protected] Update docs to debug the Android embedder (flutter/flutter#166170)
2025-04-03 [email protected] Roll Dart SDK from 72562ca93bb5 to d174ec16c3ea (1 revision) (flutter/flutter#166525)
2025-04-03 [email protected] [macOS] Implement merged UI and platform thread (flutter/flutter#162883)
2025-04-03 [email protected] Roll Skia from f91412f5d89d to b67e53719e78 (1 revision) (flutter/flutter#166527)
2025-04-03 [email protected] Roll Packages from 0d5d57b to d10d5af (31 revisions) (flutter/flutter#166457)
2025-04-03 [email protected] Roll Skia from 2be12bc2668b to f91412f5d89d (2 revisions) (flutter/flutter#166517)
2025-04-03 [email protected] Roll Dart SDK from 2a1a13cc3a91 to 72562ca93bb5 (2 revisions) (flutter/flutter#166514)
2025-04-03 [email protected] [native_assets] Roll dependencies (flutter/flutter#166282)
2025-04-03 [email protected] Fix read only TextField focus traversal on macOS (flutter/flutter#166056)
2025-04-03 [email protected] Roll Skia from c106d7831592 to 2be12bc2668b (1 revision) (flutter/flutter#166509)
2025-04-03 [email protected] Roll Fuchsia Linux SDK from v7PGvypiiWLO8PbsZ... to vYisSsIgqw0mqFRVJ... (flutter/flutter#166508)
2025-04-03 [email protected] Roll Dart SDK from b8b4076b1237 to 2a1a13cc3a91 (1 revision) (flutter/flutter#166504)
2025-04-03 [email protected] Roll Skia from 75a0ec473181 to c106d7831592 (1 revision) (flutter/flutter#166499)
2025-04-03 [email protected] Migrate to Theme.brightnessOf method (flutter/flutter#163950)
2025-04-03 [email protected] Fix: Range slider show overlay for both thumbs on hovering one (flutter/flutter#165393)
2025-04-03 [email protected] Deprecate ExpansionTileController (flutter/flutter#166368)
2025-04-03 [email protected] Add styling parameters in `PopupMenuDivider` (flutter/flutter#164790)
2025-04-03 [email protected] Fix ISSUE_TEMPLATE Ordering: `10 < 9`, but `10 > 09` (flutter/flutter#166455)
2025-04-03 [email protected] Skip flaking scheduler test (flutter/flutter#166471)
2025-04-02 [email protected] Roll pub packages (flutter/flutter#166043)
2025-04-02 [email protected] [a11y] add SemanticsValidationResult (flutter/flutter#165935)
2025-04-02 [email protected] Remove unnecessary cache busting mechanism in hot restart (flutter/flutter#166295)
2025-04-02 [email protected] Roll Skia from 52cbb917fffd to 75a0ec473181 (21 revisions) (flutter/flutter#166484)
2025-04-02 [email protected] Started pixel aligning hairlines (flutter/flutter#166351)
2025-04-02 [email protected] Adds semantics role and adjust semantics for navigation bar (flutter/flutter#162467)
2025-04-02 [email protected] Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454)
2025-04-02 [email protected] [dart:ui] Add `Path.addRSuperellipse` (flutter/flutter#166045)
2025-04-02 [email protected] Fix: Hero animation for page transition (flutter/flutter#164469)
2025-04-02 [email protected] Fix: DelegateTransition for cupertino sheet route (flutter/flutter#164675)
2025-04-02 [email protected] Roll Fuchsia Test Scripts from AEdsljKmUiPk92Wvv... to FZdRtNwH7jmADecj6... (flutter/flutter#166383)
2025-04-02 [email protected] [Impeller] cache for text shadows. (flutter/flutter#166228)
2025-04-02 [email protected] Convert `AppPluginLoaderPlugin` to Kotlin, and add `NativePluginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027)
2025-04-02 [email protected] Roll Dart SDK from 4e1f02bc704f to b8b4076b1237 (7 revisions) (flutter/flutter#166474)
2025-04-02 [email protected] Update Roadmap (flutter/flutter#166332)
2025-04-02 [email protected] Update `CODEOWNERS` (flutter/flutter#166444)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
e971379 Convert AppPluginLoaderPlugin to Kotlin, and add `NativePlu…
292fe49 
…ginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
e971379 Convert AppPluginLoaderPlugin to Kotlin, and add `NativePlu…
ff28853 
…ginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
e971379 Convert AppPluginLoaderPlugin to Kotlin, and add `NativePlu…
31aada7 
…ginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbaker reidbaker reidbaker approved these changes

@bartekpacia bartekpacia Awaiting requested review from bartekpacia

@ash2moon ash2moon Awaiting requested review from ash2moon

Assignees
No one assigned
Labels
platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gmackall @stuartmorgan-g @reidbaker @ash2moon