Skwasm heavy #166619
Merged
Skwasm heavy #166619
+755
−250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a reland of flutter#164748, which was reverted here: flutter#165350 It was reverted due to some issues in the flutter packages roller: flutter#165347 The unit test in flutter/packages was modified to be more deterministic and less affected by minor timing differences: flutter/packages#8920 So this is basically being relanded without any significant changes, since the downstream tests have been fixed.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2025
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
May 6, 2025
This produces a build of Skwasm that works on Firefox and Safari. This means we use `SkAnimatedImage` for animated gifs and webps and use builtin ICU data in Skia. I have unit test suites for Safari and Firefox with dart2wasm and both `ui` and `engine` test sets. However, there are a few issues with running these on CI: * Safari+dart2wasm doesn't work yet until the CI bots are upgraded to macOS 15, so these have been disabled on CI for now (but you can run the unit test suite locally). * Firefox+ui doesn't work because our Linux bots have no GPU and therefore no WebGL2 support, so that one is disabled. Firefox+dart2wasm with the `engine` suite is enabled on CI though. I did make some changes to the host page for our unit test harness so that Safari actually works though. Even though we're not running on CI, you can still run locally if you have macOS 15.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 8, 2025
Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions) flutter/flutter@cfb887c...b0f5c8c 2025-05-07 [email protected] Feat: Animate fill for material app bar (flutter/flutter#163913) 2025-05-07 [email protected] Roll Packages from e800da7 to b2ce3b0 (3 revisions) (flutter/flutter#168483) 2025-05-07 [email protected] Allow iOS devicelab tests to run on macOS 15.1 (flutter/flutter#168234) 2025-05-07 [email protected] Roll Skia from c8f54c1bc565 to 14f3e3209b73 (1 revision) (flutter/flutter#168477) 2025-05-07 [email protected] Roll Skia from 55d98def951d to c8f54c1bc565 (1 revision) (flutter/flutter#168452) 2025-05-07 [email protected] Roll Fuchsia Test Scripts from TcALRG6cjvR6RVe4L... to xobrcSN07udKdXOq_... (flutter/flutter#168444) 2025-05-07 [email protected] Roll Skia from 32591be9cd3b to 55d98def951d (2 revisions) (flutter/flutter#168440) 2025-05-07 [email protected] macOS: trailing closures for FlutterRunLoop.perform* (flutter/flutter#168415) 2025-05-07 [email protected] Roll Fuchsia Linux SDK from SOlRUoAtzxSsarx-6... to _GJje-N2Jk51qtBs6... (flutter/flutter#168434) 2025-05-07 [email protected] iOS/macOS: Consistent Flutter copyright headers (flutter/flutter#168390) 2025-05-06 [email protected] Capture errors when running flutter_tools in the entrypoint_dart_registrant devicelab test (flutter/flutter#168411) 2025-05-06 [email protected] Extending timeouts for DDC macrobenchmarks (flutter/flutter#168409) 2025-05-06 [email protected] Roll Skia from 36d1445ad00b to 32591be9cd3b (1 revision) (flutter/flutter#168421) 2025-05-06 [email protected] Ignore pointer on the outgoing route (flutter/flutter#168425) 2025-05-06 [email protected] [skwasm] Dispose underlying picture recorder when ending recording. (flutter/flutter#168384) 2025-05-06 [email protected] [Impeller] libImpeller: Expose access to conservative path bounds. (flutter/flutter#168402) 2025-05-06 [email protected] Roll Skia from 5cf5d0ff46d9 to 36d1445ad00b (1 revision) (flutter/flutter#168401) 2025-05-06 [email protected] Add height and width aspects to MediaQuery. (flutter/flutter#167829) 2025-05-06 [email protected] Roll Packages from e064b04 to e800da7 (2 revisions) (flutter/flutter#168392) 2025-05-06 [email protected] Add `bin/internal/last_engine_commit.sh` and tests. (flutter/flutter#168387) 2025-05-06 [email protected] Update `mac_ios` tests to run on either arm64 or x86 (flutter/flutter#168341) 2025-05-06 [email protected] Roll Skia from 889c5b52227c to 5cf5d0ff46d9 (3 revisions) (flutter/flutter#168378) 2025-05-06 [email protected] Roll Skia from 646573154de6 to 889c5b52227c (1 revision) (flutter/flutter#168363) 2025-05-06 [email protected] Roll Skia from 65fd10118ec2 to 646573154de6 (3 revisions) (flutter/flutter#168360) 2025-05-06 [email protected] feat(SwitchListTile): ensure that 'isThreeLine' can be configured through the theme. (flutter/flutter#166820) 2025-05-06 [email protected] [tool] Refactor WebTemplate to be immutable (flutter/flutter#168201) 2025-05-06 [email protected] Upload `android-arm64-release` treemap to known location (flutter/flutter#168349) 2025-05-06 [email protected] feat(RadioListTile):ensure that 'isThreeLine' can be configured through the (flutter/flutter#166964) 2025-05-06 [email protected] Roll Fuchsia Linux SDK from hjXORaFgiSd6QjK3D... to SOlRUoAtzxSsarx-6... (flutter/flutter#168347) 2025-05-05 [email protected] Revert "Wire up `MenuAnchor`, `MenuBar`, `MenuItem`-related widgets to aria roles (#165596)" (flutter/flutter#168339) 2025-05-05 [email protected] Bumping framework Template Defaults to Android 16 (API 36) (flutter/flutter#166464) 2025-05-05 [email protected] Roll Skia from c0404ac7ea67 to 65fd10118ec2 (3 revisions) (flutter/flutter#168346) 2025-05-05 [email protected] macOS: Support writing Swift in the macOS embedder (flutter/flutter#168174) 2025-05-05 [email protected] Copy Dart SDK _internal/vm/bin sources into the sky_engine package (flutter/flutter#168238) 2025-05-05 [email protected] Using headless=new for Chrome macrobenchmarks (flutter/flutter#168256) 2025-05-05 [email protected] Roll Dart SDK from a1e1e2770c1e to 8dc0ecee5adc (1 revision) (flutter/flutter#168338) 2025-05-05 [email protected] Check for duplicate archive paths in the engine build configuration JSON files (flutter/flutter#168248) 2025-05-05 [email protected] [Widget Inspector] Add on-device button for changing default "tap" behavior (flutter/flutter#167677) 2025-05-05 [email protected] Adding utf-8 encoding to hello world's html template (flutter/flutter#168162) 2025-05-05 [email protected] Update goldens.dart error to point to moved file (flutter/flutter#168319) 2025-05-05 [email protected] Skwasm heavy (flutter/flutter#166619) 2025-05-05 [email protected] Manual roll of Dart from 5c535a368799 to a1e1e2770c1e (flutter/flutter#168317) 2025-05-05 [email protected] Roll Skia from 9e23a55870e9 to c0404ac7ea67 (1 revision) (flutter/flutter#168321) 2025-05-05 [email protected] Cupertino sheet MediaQuery values (flutter/flutter#168041) 2025-05-05 [email protected] Change FGP unit test `expect` to match on process result instead of exit code (flutter/flutter#168278) 2025-05-05 [email protected] [Impeller] Use StrokeParameters anywhere stroke is described (flutter/flutter#168276) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This produces a build of Skwasm that works on Firefox and Safari. This means we use
SkAnimatedImagefor animated gifs and webps and use builtin ICU data in Skia.I have unit test suites for Safari and Firefox with dart2wasm and both
uiandenginetest sets. However, there are a few issues with running these on CI:enginesuite is enabled on CI though.I did make some changes to the host page for our unit test harness so that Safari actually works though. Even though we're not running on CI, you can still run locally if you have macOS 15.