Remove unnecessary setAriaRole('dialog') fallback in SemanticRoute class #168345
+6
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 8, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 8, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 8, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 8, 2025
flutter/flutter@b0f5c8c...02d8c1a 2025-05-08 [email protected] iOS,macOS: Unify iOS,macOS build configs (flutter/flutter#168517) 2025-05-08 [email protected] Roll Packages from b2ce3b0 to ab44c26 (3 revisions) (flutter/flutter#168548) 2025-05-08 [email protected] Remove unnecessary setAriaRole('dialog') fallback in SemanticRoute class (flutter/flutter#168345) 2025-05-08 [email protected] Roll Skia from 4d617bb1bb7d to 43ae814d2d95 (1 revision) (flutter/flutter#168526) 2025-05-08 [email protected] Roll Fuchsia Linux SDK from _GJje-N2Jk51qtBs6... to mqhX1OP8ezmialgqA... (flutter/flutter#168525) 2025-05-08 [email protected] Make MergeSemantics be able to merge customAction (flutter/flutter#168414) 2025-05-08 [email protected] Roll Skia from d787c26f873a to 4d617bb1bb7d (1 revision) (flutter/flutter#168514) 2025-05-08 [email protected] Roll pub packages (flutter/flutter#168509) 2025-05-07 [email protected] Marks Mac_arm64_ios imitation_game_swiftui to be unflaky (flutter/flutter#163114) 2025-05-07 [email protected] Add option to hide trailing icon in DropdownMenu (flutter/flutter#167782) 2025-05-07 [email protected] Roll Skia from 1ea3ec8e7863 to d787c26f873a (6 revisions) (flutter/flutter#168505) 2025-05-07 [email protected] [web] drop more use of deprecated JS functions (flutter/flutter#166157) 2025-05-07 [email protected] docs: Fixed broken links in WidgetStateProperty documentations (flutter/flutter#168191) 2025-05-07 [email protected] Roll Skia from 14f3e3209b73 to 1ea3ec8e7863 (2 revisions) (flutter/flutter#168489) 2025-05-07 [email protected] Use `config: enable-swift-...: false`, remove `disable-swift-...: true`. (flutter/flutter#168433) 2025-05-07 [email protected] Replace MediaQuery.sizeOf with heightOf and widthOf. (flutter/flutter#168479) 2025-05-07 [email protected] Fix stencil buffer leak (flutter/flutter#168448) 2025-05-07 [email protected] Fix framebuffer leak rendering to secondary views. (flutter/flutter#168447) 2025-05-07 [email protected] Fix uninitalized fields in FlutterWindowMetricsEvent (flutter/flutter#168446) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the unnecessary setAriaRole('dialog') fallback in the SemanticRoute class within the Flutter web engine. This line was an old fallback and is no longer needed
Before
https://dialog-0505-before.web.app/
After
https://dialog-050502-after.web.app/
Issue Fixed
This PR addresses GitHub Issue #168247, which proposes reconsidering the application of role="dialog" to arbitrary routes.
Pre-launch Checklist
///).