Thanks to visit codestin.com
Credit goes to github.com

Skip to content

iOS,macOS: Unify iOS,macOS build configs #168517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

cbracken
Copy link
Member

@cbracken cbracken commented May 8, 2025

Merges:

  • //build/config/ios:compiler
  • //build/config/mac:compiler
    Into:
  • //build/config/apple:compiler

Merges:

  • //flutter/shell/platform/darwin/ios:config_ios
  • //flutter/shell/platform/darwin/mac:config_macos
    Into:
  • //flutter/shell/platform/darwin/common:config

Merges:

  • //flutter/shell/platform/darwin/ios:config_ios_test
  • //flutter/shell/platform/darwin/mac:config_macos_test
    Into:
  • //flutter/shell/platform/darwin/common:test_config

This avoids the duplication between iOS and macOS build configs used for building Swift and Objective-C that depends on Swift, and avoids further duplication when we add Swift to //flutter/shell/platform/darwin/common in a followup patch.

Issue: #167592

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken cbracken requested review from a team and vashworth as code owners May 8, 2025 00:22
@github-actions github-actions bot added platform-ios iOS applications specifically engine flutter/engine repository. See also e: labels. a: desktop Running on desktop team-ios Owned by iOS platform team platform-macos labels May 8, 2025
@cbracken cbracken force-pushed the unify-ios-macos-configs branch from 0292176 to d3ba929 Compare May 8, 2025 00:48
@cbracken cbracken requested review from LouiseHsu and hellohuanlin May 8, 2025 01:39
@cbracken cbracken force-pushed the unify-ios-macos-configs branch from d3ba929 to 94a6ced Compare May 8, 2025 02:29
Merges:
* //build/config/ios:compiler
* //build/config/mac:compiler
Into:
* //build/config/apple:compiler

Merges:
* //flutter/shell/platform/darwin/ios:config_ios
* //flutter/shell/platform/darwin/mac:config_macos
Into:
* //flutter/shell/platform/darwin/common:config

Merges:
* //flutter/shell/platform/darwin/ios:config_ios_test
* //flutter/shell/platform/darwin/mac:config_macos_test
Into:
* //flutter/shell/platform/darwin/common:test_config

This avoids the duplication between iOS and macOS build configs used for
building Swift and Objective-C that depends on Swift.

Issue: flutter#167592
@cbracken cbracken force-pushed the unify-ios-macos-configs branch from 94a6ced to 34407c8 Compare May 8, 2025 13:54
Copy link
Contributor

@vashworth vashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label May 8, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 8, 2025
Merged via the queue into flutter:master with commit 02d8c1a May 8, 2025
179 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2025
@cbracken cbracken deleted the unify-ios-macos-configs branch May 8, 2025 19:16
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 8, 2025
flutter/flutter@b0f5c8c...02d8c1a

2025-05-08 [email protected] iOS,macOS: Unify iOS,macOS build configs (flutter/flutter#168517)
2025-05-08 [email protected] Roll Packages from b2ce3b0 to ab44c26 (3 revisions) (flutter/flutter#168548)
2025-05-08 [email protected] Remove unnecessary setAriaRole('dialog') fallback in SemanticRoute class (flutter/flutter#168345)
2025-05-08 [email protected] Roll Skia from 4d617bb1bb7d to 43ae814d2d95 (1 revision) (flutter/flutter#168526)
2025-05-08 [email protected] Roll Fuchsia Linux SDK from _GJje-N2Jk51qtBs6... to mqhX1OP8ezmialgqA... (flutter/flutter#168525)
2025-05-08 [email protected] Make MergeSemantics be able to merge customAction (flutter/flutter#168414)
2025-05-08 [email protected] Roll Skia from d787c26f873a to 4d617bb1bb7d (1 revision) (flutter/flutter#168514)
2025-05-08 [email protected] Roll pub packages (flutter/flutter#168509)
2025-05-07 [email protected] Marks Mac_arm64_ios imitation_game_swiftui to be unflaky (flutter/flutter#163114)
2025-05-07 [email protected] Add option to hide trailing icon in DropdownMenu (flutter/flutter#167782)
2025-05-07 [email protected] Roll Skia from 1ea3ec8e7863 to d787c26f873a (6 revisions) (flutter/flutter#168505)
2025-05-07 [email protected] [web] drop more use of deprecated JS functions (flutter/flutter#166157)
2025-05-07 [email protected] docs: Fixed broken links in WidgetStateProperty documentations (flutter/flutter#168191)
2025-05-07 [email protected] Roll Skia from 14f3e3209b73 to 1ea3ec8e7863 (2 revisions) (flutter/flutter#168489)
2025-05-07 [email protected] Use `config: enable-swift-...: false`, remove `disable-swift-...: true`. (flutter/flutter#168433)
2025-05-07 [email protected] Replace MediaQuery.sizeOf with heightOf and widthOf. (flutter/flutter#168479)
2025-05-07 [email protected] Fix stencil buffer leak (flutter/flutter#168448)
2025-05-07 [email protected] Fix framebuffer leak rendering to secondary views. (flutter/flutter#168447)
2025-05-07 [email protected] Fix uninitalized fields in FlutterWindowMetricsEvent (flutter/flutter#168446)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: desktop Running on desktop engine flutter/engine repository. See also e: labels. platform-ios iOS applications specifically platform-macos team-ios Owned by iOS platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants