This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[in_app_purchase] Deprecated the InAppPurchaseAndroidPlatformAddition.enablePendingPurchases method.
#4527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b94cc98 to
a8de4c5
Compare
mvanbeusekom
commented
Nov 19, 2021
| static bool _enablePendingPurchase = false; | ||
| @Deprecated( | ||
| 'The requirement to call `enablePendingPurchases()` has become obsolete since Google Play no longer accepts app submissions that don\'t support pending purchases.') | ||
| static bool get enablePendingPurchase => true; |
There was a problem hiding this comment.
I wasn't entirely sure about this update (always returning true instead of returning the _enablePendingPurchase variable). However I decided to do the update like this to prevent false expectations where people might think pending purchases are not enabled (because they never called enablePendingPurchases()).
There was a problem hiding this comment.
This makes sense to me.
Deprecates the `InAppPurchaseAndroidPlatformAddition.enablePendingPurchases` method and the `InAppPurchaseAndroidPlatformAddition.enablePendingPurchase` property.
a8de4c5 to
7b296e4
Compare
stuartmorgan-g
approved these changes
Nov 19, 2021
...purchase/in_app_purchase_android/lib/src/billing_client_wrappers/billing_client_wrapper.dart
Outdated
Show resolved
Hide resolved
| static bool _enablePendingPurchase = false; | ||
| @Deprecated( | ||
| 'The requirement to call `enablePendingPurchases()` has become obsolete since Google Play no longer accepts app submissions that don\'t support pending purchases.') | ||
| static bool get enablePendingPurchase => true; |
There was a problem hiding this comment.
This makes sense to me.
..._app_purchase/in_app_purchase_android/lib/src/in_app_purchase_android_platform_addition.dart
Outdated
Show resolved
Hide resolved
..._app_purchase/in_app_purchase_android/lib/src/in_app_purchase_android_platform_addition.dart
Outdated
Show resolved
Hide resolved
0d130ca to
efffbb8
Compare
|
@cyanglaz I have resolved nits mentioned by @stuartmorgan could you please have a look at this PR? |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 1, 2021
…mAddition.enablePendingPurchases` method. (flutter/plugins#4527)
11 tasks
stuartmorgan-g
pushed a commit
that referenced
this pull request
Dec 10, 2021
…urchaseAndroidPlatformAddition.enablePendingPurchases ` method (#4597) This will resolve flutter/flutter#93837 & this work is just the follow-up from #4527 PR. We need to update the documentation in the README.md of the in_app_purchase package to remove the instruction of initialization with the deprecated `InAppPurchaseAndroidPlatformAddition.enablePendingPurchases` method. Fixes flutter/flutter#94977
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
…n.enablePendingPurchases` method. (flutter#4527)
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
…urchaseAndroidPlatformAddition.enablePendingPurchases ` method (flutter#4597) This will resolve flutter/flutter#93837 & this work is just the follow-up from flutter#4527 PR. We need to update the documentation in the README.md of the in_app_purchase package to remove the instruction of initialization with the deprecated `InAppPurchaseAndroidPlatformAddition.enablePendingPurchases` method. Fixes flutter/flutter#94977
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
…n.enablePendingPurchases` method. (flutter#4527)
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
…urchaseAndroidPlatformAddition.enablePendingPurchases ` method (flutter#4597) This will resolve flutter/flutter#93837 & this work is just the follow-up from flutter#4527 PR. We need to update the documentation in the README.md of the in_app_purchase package to remove the instruction of initialization with the deprecated `InAppPurchaseAndroidPlatformAddition.enablePendingPurchases` method. Fixes flutter/flutter#94977
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates the
InAppPurchaseAndroidPlatformAddition.enablePendingPurchasesmethod and theInAppPurchaseAndroidPlatformAddition.enablePendingPurchaseproperty.An additional PR will follow to update the documentation in the README.md of the in_app_purchase package as this needs to be released separately.
Resolves flutter/flutter#93837
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.