Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

next0262
Copy link
Contributor

I think this terraform module doesn't work for creating multiple ebs.
I made some changes to enable allocating multiple ebs to runner.
I guess my changes can resolve the issue #1769 as well.

@npalm
Copy link
Member

npalm commented Mar 15, 2022

@next0262 thanks, did you test the change?

@toast-gear
Copy link
Contributor

toast-gear commented Mar 15, 2022

https://github.com/philips-labs/terraform-aws-github-runner/pull/1807 please don't break the ability to provide null as part of this PR / keep the ability to not map any device

@npalm
Copy link
Member

npalm commented Mar 15, 2022

@toast-gear thanks for the note. Maybe I overlook something. But providing the default [] empty array results in the same behavior as null in PR #1807

@next0262
Copy link
Contributor Author

next0262 commented Mar 16, 2022

@toast-gear Thanks for your correction. I fixed it for keeping the ability on null.
@npalm yes, I did some tests with github and aws and i checked there is no problem.

@toast-gear
Copy link
Contributor

toast-gear commented Mar 16, 2022

I haven't tried your build I just wanted to highlight not to cause a regression with this change (i.e. reintroduce #1769), if an empty list doesn't then crack on with removing null!

@next0262
Copy link
Contributor Author

next0262 commented Mar 16, 2022

@toast-gear I understand. Thank you for your advice. Please tell me if my additional change still has a problem.

@npalm
Copy link
Member

npalm commented Mar 16, 2022

cc @Hunqer woould you have time for a quick chck of this PR, to be sure it not conflicts your work

@next0262
Copy link
Contributor Author

@Hunqer I am so looking forward to your check. I would really appreciate it .

@Hankier
Copy link
Contributor

Hankier commented Mar 17, 2022

@npalm @next0262 Will check that today, and come back to you.

Hankier
Hankier previously approved these changes Mar 17, 2022
Copy link
Contributor

@Hankier Hankier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my test looks like it not broking our workflow. @next0262 @npalm

@next0262
Copy link
Contributor Author

next0262 commented Mar 18, 2022

@npalm I want to ask you to approve my changes if there is no problem

@npalm
Copy link
Member

npalm commented Mar 18, 2022

Will review and check the PR asap

@npalm npalm self-requested a review March 18, 2022 08:25
@next0262
Copy link
Contributor Author

@npalm Your check is done?

@next0262
Copy link
Contributor Author

next0262 commented Mar 25, 2022

@ScottGuymer @npalm I modified block_device_mappings of ubuntu example based on new type constraints. check please

@npalm npalm merged commit 7a2ca0d into github-aws-runners:develop Mar 25, 2022
ulich pushed a commit to ulich/terraform-aws-github-runner that referenced this pull request Mar 31, 2022
* add possibility to create multiple ebs

* keep the ability to not map any device

* add type constraint on block_device_mappings

* modify block_device_mappings of ubuntu example based on type constraints
npalm added a commit that referenced this pull request Oct 11, 2022
* chore(release): 0.17.0 [skip ci]

* Adding support for new workflow_job event. ([#1019](https://github.com/philips-labs/terraform-aws-github-runner/issues/1019)) ([a74e10b](philips-labs/terraform-aws-github-runner@a74e10b))

* chore(release): 0.18.0 [skip ci]

* add format checking for lambdas in CI ([#899](https://github.com/philips-labs/terraform-aws-github-runner/issues/899)) ([#1080](https://github.com/philips-labs/terraform-aws-github-runner/issues/1080)) ([ae9c277](philips-labs/terraform-aws-github-runner@ae9c277))
* add option to overwrite / disable egress [#748](https://github.com/philips-labs/terraform-aws-github-runner/issues/748) ([#1112](https://github.com/philips-labs/terraform-aws-github-runner/issues/1112)) ([9c2548d](philips-labs/terraform-aws-github-runner@9c2548d))

* replace depcrated 'request' dependency by 'node-fetch' ([#903](https://github.com/philips-labs/terraform-aws-github-runner/issues/903)) ([#1082](https://github.com/philips-labs/terraform-aws-github-runner/issues/1082)) ([fb51756](philips-labs/terraform-aws-github-runner@fb51756))

* chore(release): 0.18.1 [skip ci]

* webhook labels for `workflow_job` ([#1133](https://github.com/philips-labs/terraform-aws-github-runner/issues/1133)) ([4b39fb9](philips-labs/terraform-aws-github-runner@4b39fb9))

* chore(release): 0.19.0 [skip ci]

* **scale-down:** Update Owner Logic ([#1065](https://github.com/philips-labs/terraform-aws-github-runner/issues/1065)) ([ba2536b](philips-labs/terraform-aws-github-runner@ba2536b)), closes [#2](philips-labs/terraform-aws-github-runner#2)

* explicit set region for downloading runner distribution from S3 ([#1204](https://github.com/philips-labs/terraform-aws-github-runner/issues/1204)) ([439fb1b](philips-labs/terraform-aws-github-runner@439fb1b))
* upgrade jest  ([#1219](https://github.com/philips-labs/terraform-aws-github-runner/issues/1219)) ([c8b8139](philips-labs/terraform-aws-github-runner@c8b8139))
* use dynamic block to ignore null market opts ([#1202](https://github.com/philips-labs/terraform-aws-github-runner/issues/1202)) ([df9bd78](philips-labs/terraform-aws-github-runner@df9bd78))
* use dynamic block to ignore null market opts ([#1202](https://github.com/philips-labs/terraform-aws-github-runner/issues/1202)) ([06a5598](philips-labs/terraform-aws-github-runner@06a5598))
* **logging:** Additional Logging ([#1135](https://github.com/philips-labs/terraform-aws-github-runner/issues/1135)) ([f7f194d](philips-labs/terraform-aws-github-runner@f7f194d))
* **scale-down:** Clearing cache between runs ([#1164](https://github.com/philips-labs/terraform-aws-github-runner/issues/1164)) ([e72227b](philips-labs/terraform-aws-github-runner@e72227b))

* chore(release): 0.19.1 [skip ci]

* `instance_types` from a Set to a List, so instance order preference is preserved ([#1154](https://github.com/philips-labs/terraform-aws-github-runner/issues/1154)) ([150d227](philips-labs/terraform-aws-github-runner@150d227))

* chore(release): 0.20.0 [skip ci]

* Add option to disable SSL verification support for GitHub Enterprise Server ([#1216](https://github.com/philips-labs/terraform-aws-github-runner/issues/1216)) ([3c3ef19](philips-labs/terraform-aws-github-runner@3c3ef19)), closes [#1207](https://github.com/philips-labs/terraform-aws-github-runner/issues/1207)

* chore(release): 0.20.1 [skip ci]

* Upgrade lambda runtime to node 14.x ([#1203](https://github.com/philips-labs/terraform-aws-github-runner/issues/1203)) ([570949a](philips-labs/terraform-aws-github-runner@570949a))
* **webhook:** remove node fetch ([ca14ac5](philips-labs/terraform-aws-github-runner@ca14ac5))
* **webhook:** replace node-fetch by axios [#1247](https://github.com/philips-labs/terraform-aws-github-runner/issues/1247) ([80fff4b](philips-labs/terraform-aws-github-runner@80fff4b))
* added more detailed logging for scaling up and down ([#1222](https://github.com/philips-labs/terraform-aws-github-runner/issues/1222)) ([9aa7456](philips-labs/terraform-aws-github-runner@9aa7456))

* chore(release): 0.21.0 [skip ci]

* Ignore github managed labels and add check disable option ([#1244](https://github.com/philips-labs/terraform-aws-github-runner/issues/1244)) ([859fa38](philips-labs/terraform-aws-github-runner@859fa38))
* remove unused app client since SSH key is used to secure app authorization ([#1223](https://github.com/philips-labs/terraform-aws-github-runner/issues/1223)) ([4cb5cf1](philips-labs/terraform-aws-github-runner@4cb5cf1))
* upgrade Terraform version of module 1.0.x ([#1254](https://github.com/philips-labs/terraform-aws-github-runner/issues/1254)) ([2a817dc](philips-labs/terraform-aws-github-runner@2a817dc))

* chore(release): 0.21.1 [skip ci]

* **logging:** Adjusting scale logging messages and levels ([#1286](https://github.com/philips-labs/terraform-aws-github-runner/issues/1286)) ([665e1a6](philips-labs/terraform-aws-github-runner@665e1a6))
* **logging:** Adjusting webhook logs and levels ([#1287](https://github.com/philips-labs/terraform-aws-github-runner/issues/1287)) ([9df5fb8](philips-labs/terraform-aws-github-runner@9df5fb8))
* Update launch template to use metadata service v2 ([#1278](https://github.com/philips-labs/terraform-aws-github-runner/issues/1278)) ([ef16287](philips-labs/terraform-aws-github-runner@ef16287))

* chore(release): 0.22.0 [skip ci]

* adding message retention seconds ([#1354](https://github.com/philips-labs/terraform-aws-github-runner/issues/1354)) ([a19929f](philips-labs/terraform-aws-github-runner@a19929f))
* adding var for tags for ec2s ([#1357](https://github.com/philips-labs/terraform-aws-github-runner/issues/1357)) ([31cf02d](philips-labs/terraform-aws-github-runner@31cf02d))

* add validation to distribution_bucket_name variable ([#1356](https://github.com/philips-labs/terraform-aws-github-runner/issues/1356)) ([6522317](philips-labs/terraform-aws-github-runner@6522317))

* chore(release): 0.23.0 [skip ci]

* add option to format logging in JSON for lambdas ([#1228](https://github.com/philips-labs/terraform-aws-github-runner/issues/1228)) ([a250b96](philips-labs/terraform-aws-github-runner@a250b96))
* add option to specify SSE config for dist bucket ([#1324](https://github.com/philips-labs/terraform-aws-github-runner/issues/1324)) ([ae84302](philips-labs/terraform-aws-github-runner@ae84302))

* reducing verbosity of role and profile ([#1358](https://github.com/philips-labs/terraform-aws-github-runner/issues/1358)) ([922ef99](philips-labs/terraform-aws-github-runner@922ef99))

* chore(release): 0.23.1 [skip ci]

* configurable metadata options for runners ([#1377](https://github.com/philips-labs/terraform-aws-github-runner/issues/1377)) ([f37df23](philips-labs/terraform-aws-github-runner@f37df23))

* chore(release): 0.24.0 [skip ci]

* support single line for app private key ([#1368](https://github.com/philips-labs/terraform-aws-github-runner/issues/1368)) ([14183ac](philips-labs/terraform-aws-github-runner@14183ac))

* update return codes, no error code for job that are ignored ([#1381](https://github.com/philips-labs/terraform-aws-github-runner/issues/1381)) ([f9f705f](philips-labs/terraform-aws-github-runner@f9f705f))

* chore(release): 0.25.0 [skip ci]

* Add option to configure concurrent running scale up lambda ([#1415](https://github.com/philips-labs/terraform-aws-github-runner/issues/1415)) ([23ee630](philips-labs/terraform-aws-github-runner@23ee630))

* clean up non used variables in examples ([#1416](https://github.com/philips-labs/terraform-aws-github-runner/issues/1416)) ([fe65a5f](philips-labs/terraform-aws-github-runner@fe65a5f))

* chore(release): 0.25.1 [skip ci]

* Add required providers to module ssm ([#1423](https://github.com/philips-labs/terraform-aws-github-runner/issues/1423)) ([5b68b7b](philips-labs/terraform-aws-github-runner@5b68b7b))

* chore(release): 0.25.2 [skip ci]

* add logging context to runner lambda ([#1399](https://github.com/philips-labs/terraform-aws-github-runner/issues/1399)) ([0ba0930](philips-labs/terraform-aws-github-runner@0ba0930))
* **logging:** Add context to webhook logs ([#1401](https://github.com/philips-labs/terraform-aws-github-runner/issues/1401)) ([8094576](philips-labs/terraform-aws-github-runner@8094576))

* chore(release): 0.26.0 [skip ci]

* Add hooks for prebuilt images (AMI), including amazon linux packer example ([#1444](https://github.com/philips-labs/terraform-aws-github-runner/issues/1444)) ([060daac](philips-labs/terraform-aws-github-runner@060daac))

* add runners binaries bucket as terraform output ([5809fee](philips-labs/terraform-aws-github-runner@5809fee))

* chore(release): 0.26.1 [skip ci]

* Download lambda ([#1480](https://github.com/philips-labs/terraform-aws-github-runner/issues/1480)) ([f1b99d9](philips-labs/terraform-aws-github-runner@f1b99d9))
* **syncer:** Add tests, coverage report, and refactor lambda / naming ([#1478](https://github.com/philips-labs/terraform-aws-github-runner/issues/1478)) ([8266442](philips-labs/terraform-aws-github-runner@8266442))
* install_config_runner -> install_runner ([#1479](https://github.com/philips-labs/terraform-aws-github-runner/issues/1479)) ([de5b93f](philips-labs/terraform-aws-github-runner@de5b93f))

* chore(release): 0.27.0 [skip ci]

* add windows support ([#1476](https://github.com/philips-labs/terraform-aws-github-runner/issues/1476)) ([dbba705](philips-labs/terraform-aws-github-runner@dbba705))

* chore(release): 0.27.1 [skip ci]

* add --preserve-env to start-runner.sh to enable RUNNER_ALLOW_RUNASROOT ([#1537](https://github.com/philips-labs/terraform-aws-github-runner/issues/1537)) ([1cd9cd3](philips-labs/terraform-aws-github-runner@1cd9cd3))
* remove export from install script. ([#1538](https://github.com/philips-labs/terraform-aws-github-runner/issues/1538)) ([d32ca1b](philips-labs/terraform-aws-github-runner@d32ca1b))

* chore(release): 0.27.2 [skip ci]

* Dowload lambda see [#1541](https://github.com/philips-labs/terraform-aws-github-runner/issues/1541) for details. ([#1542](https://github.com/philips-labs/terraform-aws-github-runner/issues/1542)) ([7cb73c8](philips-labs/terraform-aws-github-runner@7cb73c8))

* chore(release): 0.28.0 [skip ci]

* add option ephemeral runners ([#1374](https://github.com/philips-labs/terraform-aws-github-runner/issues/1374)) ([2f323d6](philips-labs/terraform-aws-github-runner@2f323d6)), closes [#1399](https://github.com/philips-labs/terraform-aws-github-runner/issues/1399) [#1444](https://github.com/philips-labs/terraform-aws-github-runner/issues/1444)
* Change default location of runner to `/opt` and fix Ubuntu example ([#1572](https://github.com/philips-labs/terraform-aws-github-runner/issues/1572)) ([77f350b](philips-labs/terraform-aws-github-runner@77f350b))
* Replace run instance API by create fleet API ([#1556](https://github.com/philips-labs/terraform-aws-github-runner/issues/1556)) ([27e974d](philips-labs/terraform-aws-github-runner@27e974d))
* Support t4g Graviton instance type ([#1561](https://github.com/philips-labs/terraform-aws-github-runner/issues/1561)) ([3fa5896](philips-labs/terraform-aws-github-runner@3fa5896))

* Add config for windows ami ([#1525](https://github.com/philips-labs/terraform-aws-github-runner/issues/1525)) ([7907984](philips-labs/terraform-aws-github-runner@7907984))

* chore(release): 0.29.0 [skip ci]

* Strict label check and replace disable_check_wokflow_job_labels by opt in enable_workflow_job_labels_check ([#1591](https://github.com/philips-labs/terraform-aws-github-runner/issues/1591)) ([405b11d](philips-labs/terraform-aws-github-runner@405b11d))

* chore(release): 0.30.0 [skip ci]

* Add scheduled / pull based scaling for org level runners ([#1577](https://github.com/philips-labs/terraform-aws-github-runner/issues/1577)) ([8197432](philips-labs/terraform-aws-github-runner@8197432))

* chore(release): 0.30.1 [skip ci]

* **runnrs:** Pool runners to allow multiple pool_config objects ([#1621](https://github.com/philips-labs/terraform-aws-github-runner/issues/1621)) ([c9c7c69](philips-labs/terraform-aws-github-runner@c9c7c69))

* chore(release): 0.31.0 [skip ci]

* **packer:** add vars and minor clean up ([#1611](https://github.com/philips-labs/terraform-aws-github-runner/issues/1611)) ([1c897a4](philips-labs/terraform-aws-github-runner@1c897a4))

* **webhook:** depcrated warning on ts-jest mocked ([#1615](https://github.com/philips-labs/terraform-aws-github-runner/issues/1615)) ([56c1ece](philips-labs/terraform-aws-github-runner@56c1ece))

* chore(release): 0.32.0 [skip ci]

* **runner:** Replace patch by install ICU package for ARM runners ([#1624](https://github.com/philips-labs/terraform-aws-github-runner/issues/1624)) ([74cfa51](philips-labs/terraform-aws-github-runner@74cfa51))

* **images:** use new runner install location ([#1628](https://github.com/philips-labs/terraform-aws-github-runner/issues/1628)) ([36c1bf5](philips-labs/terraform-aws-github-runner@36c1bf5))
* **packer:** Add missing RUNNER_ARCHITECTURE for amazn-linux2 ([#1647](https://github.com/philips-labs/terraform-aws-github-runner/issues/1647)) ([ec497a2](philips-labs/terraform-aws-github-runner@ec497a2))

* chore(release): 0.33.0 [skip ci]

* **images:** Added ubuntu-focual example packer configuration ([#1644](https://github.com/philips-labs/terraform-aws-github-runner/issues/1644)) ([997b171](philips-labs/terraform-aws-github-runner@997b171))

* **examples:** Update AMI filter ([#1673](https://github.com/philips-labs/terraform-aws-github-runner/issues/1673)) ([39c019c](philips-labs/terraform-aws-github-runner@39c019c))

* chore(release): 0.34.0 [skip ci]

* Add output image id used in launch template ([#1676](https://github.com/philips-labs/terraform-aws-github-runner/issues/1676)) ([a49fab4](philips-labs/terraform-aws-github-runner@a49fab4))

* chore(release): 0.34.1 [skip ci]

* **syncer:** Fix for windows binaries in action runner syncer ([#1716](https://github.com/philips-labs/terraform-aws-github-runner/issues/1716)) ([63e0e27](philips-labs/terraform-aws-github-runner@63e0e27))

* chore(release): 0.34.2 [skip ci]

* Limit AWS Terraform Provider to 3.* ([#1741](https://github.com/philips-labs/terraform-aws-github-runner/issues/1741)) ([0cf2b5d](philips-labs/terraform-aws-github-runner@0cf2b5d))
* **runner:** Cannot disable cloudwatch agent ([#1738](https://github.com/philips-labs/terraform-aws-github-runner/issues/1738)) ([0f798ca](philips-labs/terraform-aws-github-runner@0f798ca))

* chore(release): 0.35.0 [skip ci]

* Parameterise delete_on_termination ([#1758](https://github.com/philips-labs/terraform-aws-github-runner/issues/1758)) ([6282351](philips-labs/terraform-aws-github-runner@6282351)), closes [#1745](https://github.com/philips-labs/terraform-aws-github-runner/issues/1745)
* **runner:** Ability to disable default runner security group creation ([#1718](https://github.com/philips-labs/terraform-aws-github-runner/issues/1718)) ([94779f8](philips-labs/terraform-aws-github-runner@94779f8))

* chore(release): 0.36.0 [skip ci]

* **runner:** Add option to disable auto update ([#1791](https://github.com/philips-labs/terraform-aws-github-runner/issues/1791)) ([c2a834f](philips-labs/terraform-aws-github-runner@c2a834f))

* chore(release): 0.37.0 [skip ci]

*  Add associate_public_ip_address variable to windows AMI too ([#1819](https://github.com/philips-labs/terraform-aws-github-runner/issues/1819)) ([0b8e1fc](philips-labs/terraform-aws-github-runner@0b8e1fc)), closes [/github.com/philips-labs/terraform-aws-github-runner/pull/1816#issuecomment-1060650668](https://github.com/philips-labs//github.com/philips-labs/terraform-aws-github-runner/pull/1816/issues/issuecomment-1060650668)
* Add associate_public_ip_address variable ([#1816](https://github.com/philips-labs/terraform-aws-github-runner/issues/1816)) ([052e9f8](philips-labs/terraform-aws-github-runner@052e9f8))
* Add option for KMS encryption for cloudwatch log groups ([#1833](https://github.com/philips-labs/terraform-aws-github-runner/issues/1833)) ([3f1a67f](philips-labs/terraform-aws-github-runner@3f1a67f))
* Add SQS queue resource policy to improve security ([#1798](https://github.com/philips-labs/terraform-aws-github-runner/issues/1798)) ([96def9a](philips-labs/terraform-aws-github-runner@96def9a))
* Add Support for Alternative Partitions in ARNs (like govcloud) ([#1815](https://github.com/philips-labs/terraform-aws-github-runner/issues/1815)) ([0ba06c8](philips-labs/terraform-aws-github-runner@0ba06c8))
* Add variable to specify custom commands while building the AMI ([#1838](https://github.com/philips-labs/terraform-aws-github-runner/issues/1838)) ([8f9c342](philips-labs/terraform-aws-github-runner@8f9c342))

* Autoupdate should be disabled by default ([#1797](https://github.com/philips-labs/terraform-aws-github-runner/issues/1797)) ([828bed6](philips-labs/terraform-aws-github-runner@828bed6))
* Create SQS DLQ policy only if DLQ is created ([#1839](https://github.com/philips-labs/terraform-aws-github-runner/issues/1839)) ([c88a005](philips-labs/terraform-aws-github-runner@c88a005))
* Upgrade Amazon base AMI to Amazon Linux 2 kernel 5x ([#1812](https://github.com/philips-labs/terraform-aws-github-runner/issues/1812)) ([9aa5532](philips-labs/terraform-aws-github-runner@9aa5532))

* chore(release): 0.38.0 [skip ci]

* Add option for ephemeral to check builds status before scaling ([#1854](https://github.com/philips-labs/terraform-aws-github-runner/issues/1854)) ([7eb0bda](philips-labs/terraform-aws-github-runner@7eb0bda))

* Retention days was used instead of kms key id for pool ([#1855](https://github.com/philips-labs/terraform-aws-github-runner/issues/1855)) ([aa29d93](philips-labs/terraform-aws-github-runner@aa29d93))

* chore(release): 0.39.0 [skip ci]

* Add possibility to create multiple ebs ([#1845](https://github.com/philips-labs/terraform-aws-github-runner/issues/1845)) ([7a2ca0d](philips-labs/terraform-aws-github-runner@7a2ca0d))

* Don't delete busy runners ([#1832](https://github.com/philips-labs/terraform-aws-github-runner/issues/1832)) ([0e9b083](philips-labs/terraform-aws-github-runner@0e9b083))

* chore(release): 0.40.0 [skip ci]

* Support multi runner process support for runner scale down. ([#1859](https://github.com/philips-labs/terraform-aws-github-runner/issues/1859)) ([3658d6a](philips-labs/terraform-aws-github-runner@3658d6a))

* Set the minimal AWS provider to 3.50 ([#1937](https://github.com/philips-labs/terraform-aws-github-runner/issues/1937)) ([16095d8](philips-labs/terraform-aws-github-runner@16095d8))

* chore(release): 0.40.1 [skip ci]

* Avoid non semantic commontes can be merged. ([#1969](https://github.com/philips-labs/terraform-aws-github-runner/issues/1969)) ([ad1c872](philips-labs/terraform-aws-github-runner@ad1c872))

* chore(release): 0.40.2 [skip ci]

* Outputs for pool need to account for complexity ([#1970](https://github.com/philips-labs/terraform-aws-github-runner/issues/1970)) ([2d92906](philips-labs/terraform-aws-github-runner@2d92906))

* chore(release): 0.40.3 [skip ci]

* Volume size is ingored ([#2014](https://github.com/philips-labs/terraform-aws-github-runner/issues/2014)) ([b733248](philips-labs/terraform-aws-github-runner@b733248)), closes [#1954](https://github.com/philips-labs/terraform-aws-github-runner/issues/1954)

* chore(release): 0.40.4 [skip ci]

* Wrong block device mapping ([#2019](https://github.com/philips-labs/terraform-aws-github-runner/issues/2019)) ([c42a467](philips-labs/terraform-aws-github-runner@c42a467))

* chore(release): 1.0.0 [skip ci]

* var.volume_size replaced by var.block_device_mappings
* The module is upgraded to AWS Terraform provider 4.x

* Improve syncer s3 kms encryption ([38ed5be](philips-labs/terraform-aws-github-runner@38ed5be))
* Remove var.volume_size in favour of var.block_device_mappings ([4e97048](philips-labs/terraform-aws-github-runner@4e97048))
* Support AWS 4.x Terraform provider ([#1739](https://github.com/philips-labs/terraform-aws-github-runner/issues/1739)) ([cfb6da2](philips-labs/terraform-aws-github-runner@cfb6da2))

* Wrong block device mapping ([#2019](https://github.com/philips-labs/terraform-aws-github-runner/issues/2019)) ([185ef20](philips-labs/terraform-aws-github-runner@185ef20))

* chore(release): 1.1.0 [skip ci]

* Add option to enable detailed monitoring for runner launch template ([#2024](https://github.com/philips-labs/terraform-aws-github-runner/issues/2024)) ([e73a267](philips-labs/terraform-aws-github-runner@e73a267))

* chore(release): 1.1.1 [skip ci]

* **runner:** Don't treat the string "false" as true. ([#2051](https://github.com/philips-labs/terraform-aws-github-runner/issues/2051)) ([b67c7dc](philips-labs/terraform-aws-github-runner@b67c7dc))

* chore(release): 1.2.0 [skip ci]

* Replace environment variable by prefix ([#1858](https://github.com/philips-labs/terraform-aws-github-runner/issues/1858)) ([e2f9a27](philips-labs/terraform-aws-github-runner@e2f9a27))

* docs: fix hyperlinks in the Terraform Registry documentation (#2085)

This makes the hyperlink correct in the Terraform Registry documentation

* chore(release): 1.3.0 [skip ci]

* Support arm64 lambda functions ([#2121](https://github.com/philips-labs/terraform-aws-github-runner/issues/2121)) ([9e2a7b6](philips-labs/terraform-aws-github-runner@9e2a7b6))
* Support Node16 for AWS Lambda ([#2073](https://github.com/philips-labs/terraform-aws-github-runner/issues/2073)) ([68a2014](philips-labs/terraform-aws-github-runner@68a2014))

* replaced old environment variable ([#2146](https://github.com/philips-labs/terraform-aws-github-runner/issues/2146)) ([f2072f7](philips-labs/terraform-aws-github-runner@f2072f7))
* set explicit permissions on s3 for syncer lambda ([#2145](https://github.com/philips-labs/terraform-aws-github-runner/issues/2145)) ([aa7edd1](philips-labs/terraform-aws-github-runner@aa7edd1))
* set kms key on aws_s3_object when encryption is enabled ([#2147](https://github.com/philips-labs/terraform-aws-github-runner/issues/2147)) ([b4dc706](philips-labs/terraform-aws-github-runner@b4dc706))

* chore(release): 1.4.0 [skip ci]

* Add option to match some of the labes instead of all [#2122](https://github.com/philips-labs/terraform-aws-github-runner/issues/2122) ([#2123](https://github.com/philips-labs/terraform-aws-github-runner/issues/2123)) ([c5e3c21](philips-labs/terraform-aws-github-runner@c5e3c21))

* don't apply extra labels unless defined ([#2181](https://github.com/philips-labs/terraform-aws-github-runner/issues/2181)) ([c0b11bb](philips-labs/terraform-aws-github-runner@c0b11bb))
* Remove asterik in permission for runner lambda to describe instances ([9b9da03](philips-labs/terraform-aws-github-runner@9b9da03))

* chore(release): 1.4.1 [skip ci]

* added server_side_encryption key to download trigger for distribution ([#2207](https://github.com/philips-labs/terraform-aws-github-runner/issues/2207)) ([404e3b6](philips-labs/terraform-aws-github-runner@404e3b6))

* chore(release): 1.5.0 [skip ci]

* Add ubuntu-jammy example image based on existing ubuntu-focal ([#2102](https://github.com/philips-labs/terraform-aws-github-runner/issues/2102)) ([486ae91](philips-labs/terraform-aws-github-runner@486ae91))

* **images:** avoid wrong AMI could be selected for ubuntu focal ([#2214](https://github.com/philips-labs/terraform-aws-github-runner/issues/2214)) ([76be94b](philips-labs/terraform-aws-github-runner@76be94b))

* chore(release): 1.6.0 [skip ci]

* Add options extra option to ebs block device mapping ([#2052](https://github.com/philips-labs/terraform-aws-github-runner/issues/2052)) ([7cd2524](philips-labs/terraform-aws-github-runner@7cd2524))
* Enable node16 default ([#2074](https://github.com/philips-labs/terraform-aws-github-runner/issues/2074)) ([58aa5ed](philips-labs/terraform-aws-github-runner@58aa5ed))

* Incorrect path of Runner logs ([#2233](https://github.com/philips-labs/terraform-aws-github-runner/issues/2233)) ([98eff98](philips-labs/terraform-aws-github-runner@98eff98))
* Preventing that lambda webhook fails when it tries to process an installation_repositories event ([#2288](https://github.com/philips-labs/terraform-aws-github-runner/issues/2288)) ([8656c83](philips-labs/terraform-aws-github-runner@8656c83))
* Update ubuntu example to fix /opt/hostedtoolcache ([#2302](https://github.com/philips-labs/terraform-aws-github-runner/issues/2302)) ([8eea748](philips-labs/terraform-aws-github-runner@8eea748))
* Webhook lambda misleading log ([#2291](https://github.com/philips-labs/terraform-aws-github-runner/issues/2291)) ([c6275f9](philips-labs/terraform-aws-github-runner@c6275f9))

* chore(release): 1.7.0 [skip ci]

* Webhook accept jobs where not all labels are provided in job. ([#2209](https://github.com/philips-labs/terraform-aws-github-runner/issues/2209)) ([6d9116f](philips-labs/terraform-aws-github-runner@6d9116f))

* Ignore case for runner labels. ([#2315](https://github.com/philips-labs/terraform-aws-github-runner/issues/2315)) ([014985a](philips-labs/terraform-aws-github-runner@014985a))

* chore(release): 1.8.0 [skip ci]

* Add option to disable lambda to sync runner binaries ([#2314](https://github.com/philips-labs/terraform-aws-github-runner/issues/2314)) ([9f7d32d](philips-labs/terraform-aws-github-runner@9f7d32d))

* **examples:** Upgrading ubuntu example to 22.04 ([#2250](https://github.com/philips-labs/terraform-aws-github-runner/issues/2250)) ([d4b7650](philips-labs/terraform-aws-github-runner@d4b7650)), closes [#2103](https://github.com/philips-labs/terraform-aws-github-runner/issues/2103)

* chore(release): 1.8.1 [skip ci]

* **runners:** Pass allocation strategy ([#2345](https://github.com/philips-labs/terraform-aws-github-runner/issues/2345)) ([68d3445](philips-labs/terraform-aws-github-runner@68d3445))

* chore(release): 1.9.0 [skip ci]

* Add option to enable access log for API gateway ([#2387](https://github.com/philips-labs/terraform-aws-github-runner/issues/2387)) ([fcd9fba](philips-labs/terraform-aws-github-runner@fcd9fba))
* add s3_location_runner_distribution var as expandable for userdata ([#2371](https://github.com/philips-labs/terraform-aws-github-runner/issues/2371)) ([05fe737](philips-labs/terraform-aws-github-runner@05fe737))
* Encrypted data at REST on SQS by default ([#2431](https://github.com/philips-labs/terraform-aws-github-runner/issues/2431)) ([7f3f4bf](philips-labs/terraform-aws-github-runner@7f3f4bf))
* **images:** Allow passing instance type when building windows image ([#2369](https://github.com/philips-labs/terraform-aws-github-runner/issues/2369)) ([eca23bf](philips-labs/terraform-aws-github-runner@eca23bf))

* **runners:** Fetch instance environment tag though metadata ([#2346](https://github.com/philips-labs/terraform-aws-github-runner/issues/2346)) ([27db290](philips-labs/terraform-aws-github-runner@27db290))
* **runners:** Set the default Windows AMI to Server 2022 ([#2325](https://github.com/philips-labs/terraform-aws-github-runner/issues/2325)) ([78e99d1](philips-labs/terraform-aws-github-runner@78e99d1))

* chore(release): 1.9.1 [skip ci]

* **webhook:** Use `x-hub-signature-256` header as default ([#2434](https://github.com/philips-labs/terraform-aws-github-runner/issues/2434)) ([9c3e495](philips-labs/terraform-aws-github-runner@9c3e495))

* chore(release): 1.10.0 [skip ci]

* Download runner release via latest release API ([#2455](https://github.com/philips-labs/terraform-aws-github-runner/issues/2455)) ([e75e092](philips-labs/terraform-aws-github-runner@e75e092))

* fix: Execute runner in own process, mask token in logs

* Add option to disable user_data logging

* Enforcing debug is disabled, and introduce option to enable debug logging.

* add section related to security considerations

* add section related to security considerations

Co-authored-by: semantic-release-bot <[email protected]>
Co-authored-by: Derek Crosson <[email protected]>
forest-releaser bot pushed a commit that referenced this pull request Oct 12, 2022
## [1.12.0](philips-labs/terraform-aws-github-runner@v1.11.0...v1.12.0) (2022-10-12)

### Features

* Added the AMI to machine setup info to runner workflows. ([#2451](https://github.com/philips-labs/terraform-aws-github-runner/issues/2451)) ([e197cbd](philips-labs/terraform-aws-github-runner@e197cbd))
* **images:** add ami for windows core 2022 ([#2390](https://github.com/philips-labs/terraform-aws-github-runner/issues/2390)) ([97707c2](philips-labs/terraform-aws-github-runner@97707c2))
* Log workflow id in webhook ([#2511](https://github.com/philips-labs/terraform-aws-github-runner/issues/2511)) ([204acf1](philips-labs/terraform-aws-github-runner@204acf1))
* Security improvements, add option to disable userdata logging ([9a9e2ee](philips-labs/terraform-aws-github-runner@9a9e2ee)), closes [#1019](https://github.com/philips-labs/terraform-aws-github-runner/issues/1019) [#899](https://github.com/philips-labs/terraform-aws-github-runner/issues/899) [#1080](https://github.com/philips-labs/terraform-aws-github-runner/issues/1080) [#748](https://github.com/philips-labs/terraform-aws-github-runner/issues/748) [#1112](https://github.com/philips-labs/terraform-aws-github-runner/issues/1112) [#903](https://github.com/philips-labs/terraform-aws-github-runner/issues/903) [#1082](https://github.com/philips-labs/terraform-aws-github-runner/issues/1082) [#1133](https://github.com/philips-labs/terraform-aws-github-runner/issues/1133) [#2](philips-labs/terraform-aws-github-runner#2) [#1204](https://github.com/philips-labs/terraform-aws-github-runner/issues/1204) [#1219](https://github.com/philips-labs/terraform-aws-github-runner/issues/1219) [#1202](https://github.com/philips-labs/terraform-aws-github-runner/issues/1202) [#1202](https://github.com/philips-labs/terraform-aws-github-runner/issues/1202) [#1135](https://github.com/philips-labs/terraform-aws-github-runner/issues/1135) [#1164](https://github.com/philips-labs/terraform-aws-github-runner/issues/1164) [#1154](https://github.com/philips-labs/terraform-aws-github-runner/issues/1154) [#1207](https://github.com/philips-labs/terraform-aws-github-runner/issues/1207) [#1203](https://github.com/philips-labs/terraform-aws-github-runner/issues/1203) [#1247](https://github.com/philips-labs/terraform-aws-github-runner/issues/1247) [#1222](https://github.com/philips-labs/terraform-aws-github-runner/issues/1222) [#1244](https://github.com/philips-labs/terraform-aws-github-runner/issues/1244) [#1223](https://github.com/philips-labs/terraform-aws-github-runner/issues/1223) [#1254](https://github.com/philips-labs/terraform-aws-github-runner/issues/1254) [#1286](https://github.com/philips-labs/terraform-aws-github-runner/issues/1286) [#1287](https://github.com/philips-labs/terraform-aws-github-runner/issues/1287) [#1278](https://github.com/philips-labs/terraform-aws-github-runner/issues/1278) [#1354](https://github.com/philips-labs/terraform-aws-github-runner/issues/1354) [#1357](https://github.com/philips-labs/terraform-aws-github-runner/issues/1357) [#1356](https://github.com/philips-labs/terraform-aws-github-runner/issues/1356) [#1228](https://github.com/philips-labs/terraform-aws-github-runner/issues/1228) [#1324](https://github.com/philips-labs/terraform-aws-github-runner/issues/1324) [#1358](https://github.com/philips-labs/terraform-aws-github-runner/issues/1358) [#1377](https://github.com/philips-labs/terraform-aws-github-runner/issues/1377) [#1368](https://github.com/philips-labs/terraform-aws-github-runner/issues/1368) [#1381](https://github.com/philips-labs/terraform-aws-github-runner/issues/1381) [#1415](https://github.com/philips-labs/terraform-aws-github-runner/issues/1415) [#1416](https://github.com/philips-labs/terraform-aws-github-runner/issues/1416) [#1423](https://github.com/philips-labs/terraform-aws-github-runner/issues/1423) [#1399](https://github.com/philips-labs/terraform-aws-github-runner/issues/1399) [#1401](https://github.com/philips-labs/terraform-aws-github-runner/issues/1401) [#1444](https://github.com/philips-labs/terraform-aws-github-runner/issues/1444) [#1480](https://github.com/philips-labs/terraform-aws-github-runner/issues/1480) [#1478](https://github.com/philips-labs/terraform-aws-github-runner/issues/1478) [#1479](https://github.com/philips-labs/terraform-aws-github-runner/issues/1479) [#1476](https://github.com/philips-labs/terraform-aws-github-runner/issues/1476) [#1537](https://github.com/philips-labs/terraform-aws-github-runner/issues/1537) [#1538](https://github.com/philips-labs/terraform-aws-github-runner/issues/1538) [#1541](https://github.com/philips-labs/terraform-aws-github-runner/issues/1541) [#1542](https://github.com/philips-labs/terraform-aws-github-runner/issues/1542) [#1399](https://github.com/philips-labs/terraform-aws-github-runner/issues/1399) [#1444](https://github.com/philips-labs/terraform-aws-github-runner/issues/1444) [#1572](https://github.com/philips-labs/terraform-aws-github-runner/issues/1572) [#1556](https://github.com/philips-labs/terraform-aws-github-runner/issues/1556) [#1561](https://github.com/philips-labs/terraform-aws-github-runner/issues/1561) [#1525](https://github.com/philips-labs/terraform-aws-github-runner/issues/1525) [#1591](https://github.com/philips-labs/terraform-aws-github-runner/issues/1591) [#1577](https://github.com/philips-labs/terraform-aws-github-runner/issues/1577) [#1621](https://github.com/philips-labs/terraform-aws-github-runner/issues/1621) [#1611](https://github.com/philips-labs/terraform-aws-github-runner/issues/1611) [#1615](https://github.com/philips-labs/terraform-aws-github-runner/issues/1615) [#1624](https://github.com/philips-labs/terraform-aws-github-runner/issues/1624) [#1628](https://github.com/philips-labs/terraform-aws-github-runner/issues/1628) [#1647](https://github.com/philips-labs/terraform-aws-github-runner/issues/1647) [#1644](https://github.com/philips-labs/terraform-aws-github-runner/issues/1644) [#1673](https://github.com/philips-labs/terraform-aws-github-runner/issues/1673) [#1676](https://github.com/philips-labs/terraform-aws-github-runner/issues/1676) [#1716](https://github.com/philips-labs/terraform-aws-github-runner/issues/1716) [#1741](https://github.com/philips-labs/terraform-aws-github-runner/issues/1741) [#1738](https://github.com/philips-labs/terraform-aws-github-runner/issues/1738) [#1745](https://github.com/philips-labs/terraform-aws-github-runner/issues/1745) [#1718](https://github.com/philips-labs/terraform-aws-github-runner/issues/1718) [#1791](https://github.com/philips-labs/terraform-aws-github-runner/issues/1791) [github.com/philips-labs/terraform-aws-github-runner/pull/1816#issuecomment-1060650668](https://github.com/philips-labs/github.com/philips-labs/terraform-aws-github-runner/pull/1816/issues/issuecomment-1060650668) [#1816](https://github.com/philips-labs/terraform-aws-github-runner/issues/1816) [#1833](https://github.com/philips-labs/terraform-aws-github-runner/issues/1833) [#1798](https://github.com/philips-labs/terraform-aws-github-runner/issues/1798) [#1815](https://github.com/philips-labs/terraform-aws-github-runner/issues/1815) [#1838](https://github.com/philips-labs/terraform-aws-github-runner/issues/1838) [#1797](https://github.com/philips-labs/terraform-aws-github-runner/issues/1797) [#1839](https://github.com/philips-labs/terraform-aws-github-runner/issues/1839) [#1812](https://github.com/philips-labs/terraform-aws-github-runner/issues/1812) [#1854](https://github.com/philips-labs/terraform-aws-github-runner/issues/1854) [#1855](https://github.com/philips-labs/terraform-aws-github-runner/issues/1855) [#1845](https://github.com/philips-labs/terraform-aws-github-runner/issues/1845) [#1832](https://github.com/philips-labs/terraform-aws-github-runner/issues/1832) [#1859](https://github.com/philips-labs/terraform-aws-github-runner/issues/1859) [#1937](https://github.com/philips-labs/terraform-aws-github-runner/issues/1937) [#1969](https://github.com/philips-labs/terraform-aws-github-runner/issues/1969) [#1970](https://github.com/philips-labs/terraform-aws-github-runner/issues/1970) [#1954](https://github.com/philips-labs/terraform-aws-github-runner/issues/1954) [#2019](https://github.com/philips-labs/terraform-aws-github-runner/issues/2019) [#1739](https://github.com/philips-labs/terraform-aws-github-runner/issues/1739) [#2019](https://github.com/philips-labs/terraform-aws-github-runner/issues/2019) [#2024](https://github.com/philips-labs/terraform-aws-github-runner/issues/2024) [#2051](https://github.com/philips-labs/terraform-aws-github-runner/issues/2051) [#1858](https://github.com/philips-labs/terraform-aws-github-runner/issues/1858) [#2085](https://github.com/philips-labs/terraform-aws-github-runner/issues/2085) [#2121](https://github.com/philips-labs/terraform-aws-github-runner/issues/2121) [#2073](https://github.com/philips-labs/terraform-aws-github-runner/issues/2073) [#2146](https://github.com/philips-labs/terraform-aws-github-runner/issues/2146) [#2145](https://github.com/philips-labs/terraform-aws-github-runner/issues/2145) [#2147](https://github.com/philips-labs/terraform-aws-github-runner/issues/2147) [#2122](https://github.com/philips-labs/terraform-aws-github-runner/issues/2122) [#2123](https://github.com/philips-labs/terraform-aws-github-runner/issues/2123) [#2181](https://github.com/philips-labs/terraform-aws-github-runner/issues/2181) [#2207](https://github.com/philips-labs/terraform-aws-github-runner/issues/2207) [#2102](https://github.com/philips-labs/terraform-aws-github-runner/issues/2102) [#2214](https://github.com/philips-labs/terraform-aws-github-runner/issues/2214) [#2052](https://github.com/philips-labs/terraform-aws-github-runner/issues/2052) [#2074](https://github.com/philips-labs/terraform-aws-github-runner/issues/2074) [#2233](https://github.com/philips-labs/terraform-aws-github-runner/issues/2233) [#2288](https://github.com/philips-labs/terraform-aws-github-runner/issues/2288) [#2302](https://github.com/philips-labs/terraform-aws-github-runner/issues/2302) [#2291](https://github.com/philips-labs/terraform-aws-github-runner/issues/2291) [#2209](https://github.com/philips-labs/terraform-aws-github-runner/issues/2209) [#2315](https://github.com/philips-labs/terraform-aws-github-runner/issues/2315) [#2314](https://github.com/philips-labs/terraform-aws-github-runner/issues/2314) [#2103](https://github.com/philips-labs/terraform-aws-github-runner/issues/2103) [#2345](https://github.com/philips-labs/terraform-aws-github-runner/issues/2345) [#2387](https://github.com/philips-labs/terraform-aws-github-runner/issues/2387) [#2371](https://github.com/philips-labs/terraform-aws-github-runner/issues/2371) [#2431](https://github.com/philips-labs/terraform-aws-github-runner/issues/2431) [#2369](https://github.com/philips-labs/terraform-aws-github-runner/issues/2369) [#2346](https://github.com/philips-labs/terraform-aws-github-runner/issues/2346) [#2325](https://github.com/philips-labs/terraform-aws-github-runner/issues/2325) [#2434](https://github.com/philips-labs/terraform-aws-github-runner/issues/2434) [#2455](https://github.com/philips-labs/terraform-aws-github-runner/issues/2455)

### Bug Fixes

* Remove resource group from module ([#2512](https://github.com/philips-labs/terraform-aws-github-runner/issues/2512)) ([2628352](philips-labs/terraform-aws-github-runner@2628352))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants