Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jerop
Copy link
Contributor

@jerop jerop commented Sep 10, 2025

  • Explicitly specify event type 'COMMENT' for MCP tool submit_pending_pull_request_review
  • Add clear instructions listing all available event types (APPROVE, REQUEST_CHANGES, COMMENT)
  • Explicitly prohibit use of APPROVE and REQUEST_CHANGES event types
  • Ensures bot only comments on PRs and never approves them automatically
  • Note: Best practices already recommend branch protection rules and PR approval restrictions (see docs/best-practices.md)

- Explicitly specify event type 'COMMENT' for MCP tool submit_pending_pull_request_review
- Add clear instructions listing all available event types (APPROVE, REQUEST_CHANGES, COMMENT)
- Explicitly prohibit use of APPROVE and REQUEST_CHANGES event types
- Ensures bot only comments on PRs and never approves them automatically
- Note: Best practices already recommend branch protection rules and PR approval restrictions (see docs/best-practices.md)
@jerop jerop requested review from a team as code owners September 10, 2025 19:48
@gemini-cli
Copy link

gemini-cli bot commented Sep 10, 2025

🤖 Hi @jerop, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@jerop jerop linked an issue Sep 10, 2025 that may be closed by this pull request
@jerop
Copy link
Contributor Author

jerop commented Sep 10, 2025

@dan-ri implemented your suggestions in #169, thank you!

@jerop jerop enabled auto-merge (squash) September 10, 2025 19:49
@jerop jerop merged commit b8dcd5f into main Sep 10, 2025
23 checks passed
@jerop jerop deleted the fix/mcp-tool-event-type-comment-only branch September 10, 2025 19:59
google-github-actions-bot added a commit that referenced this pull request Oct 9, 2025
## What's Changed
* chore: script to generate examples by @leehagoodjames in
#244
* chore: update readme to state user must copy gemini-dispatch.yml by
@leehagoodjames in
#249
* Relax node requirement and bump actions-utils by @sethvargo in
#253
* feat: support /fix slash command and workflow by @leehagoodjames in
#190
* feat(docs): improve manual setup instructions for workflows by @jerop
in #263
* feat: improve action input descriptions by @jerop in
#264
* fix: enforce COMMENT event type for submit_pending_pull_request_review
by @jerop in
#271
* docs: add fork support documentation for PR review workflow by @jerop
in #268
* feat(action): add support for preview and nightly versions by @jerop
in #281
* feat(workflows): add gemini_cli_version to all workflows by @jerop in
#279
* feat: migrate to new Gemini CLI configuration format by @jerop in
#284
* feat: clean up temp fix for empty API key by @jerop in
#285
* Sort inputs alphabetically in action.yml by @jerop in
#286
* chore: organize workflow inputs alphabetically and add missing
parameters by @jerop in
#288
* feat: add auth input validation by @jerop in
#289
* fix(action): correct quoting in workflow expressions by @jerop in
#293
* fix(validation): improve validation error messages by @jerop in
#297
* fix(validate-inputs): surface errors in logs, annotation, and step
summary by @jerop in
#299
* feat(validate-inputs): downgrade validation failures to warnings by
@jerop in
#300
* fix(validate-inputs): use env-based bash shebang for portability by
@jerop in
#303
* feat: simplify input validation logic by @jerop in
#304
* fix(action): correct input validation script behavior by @jerop in
#309
* feat: add command substitution security warning by @jerop in
#306
* fix(triage): correct duplicate step numbering in workflow by @aladh in
#331
* feat: Optionally install extensions by @CallumHYoung in
#329
* docs(extensions): add documentation for extensions by @jerop in
#340
* chore(workflows): Apply formatting and fix example prompt by @jerop in
#339
* refactor(workflows): improve prompts to use env vars directly by
@jerop in
#342
* fix(review): Remove --source argument to match CLI 8.0 release by
@CallumHYoung in
#347

## New Contributors
* @aladh made their first contribution in
#331
* @CallumHYoung made their first contribution in
#329

**Full Changelog**:
v0.1.12...v0.1.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

PR Review Workflow can approve PR

3 participants