Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

caesarxuchao
Copy link
Contributor

addressed the comments in @lavalamp's PR #9966.

@nikhiljindal @bgrant0607 @lavalamp @liggitt

@liggitt
Copy link
Member

liggitt commented Jun 19, 2015

LGTM

@k8s-bot
Copy link

k8s-bot commented Jun 19, 2015

GCE e2e build/test passed for commit 5673f73.

@bgrant0607 bgrant0607 added this to the v1.0 milestone Jun 19, 2015
@bgrant0607
Copy link
Member

Looks reasonable to me, also.

@caesarxuchao
Copy link
Contributor Author

I will fix the Shippable.

@caesarxuchao
Copy link
Contributor Author

Close and reopen to trigger Shippable

@nikhiljindal
Copy link
Contributor

LGTM, thanks!

@nikhiljindal nikhiljindal added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2015
satnam6502 added a commit that referenced this pull request Jun 19, 2015
based on #9966: fix annoying 'please check...' messages; remove v1beta1&2 ref
@satnam6502 satnam6502 merged commit 078e85c into kubernetes:master Jun 19, 2015
@lavalamp
Copy link
Contributor

Thanks!

@dragon9783
Copy link

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants